Re: [RFC][PATCH 00/12] mm: tweak page cache migration

2020-10-07 Thread Dave Hansen
On 10/7/20 8:52 AM, Yang Shi wrote: > On Wed, Oct 7, 2020 at 2:55 AM David Hildenbrand wrote: >> On 07.10.20 11:52, Michal Hocko wrote: >>> Am I the only one missing patch 1-5? lore.k.o doesn't seem to link them >>> under this message id either. >> I received no patches via linux-mm, only the

Re: [RFC][PATCH 00/12] mm: tweak page cache migration

2020-10-07 Thread Yang Shi
On Wed, Oct 7, 2020 at 2:55 AM David Hildenbrand wrote: > > On 07.10.20 11:52, Michal Hocko wrote: > > Am I the only one missing patch 1-5? lore.k.o doesn't seem to link them > > under this message id either. > > I received no patches via linux-mm, only the cover letter and Dave's > reply. (maybe

Re: [RFC][PATCH 00/12] mm: tweak page cache migration

2020-10-07 Thread David Hildenbrand
On 07.10.20 11:52, Michal Hocko wrote: > Am I the only one missing patch 1-5? lore.k.o doesn't seem to link them > under this message id either. I received no patches via linux-mm, only the cover letter and Dave's reply. (maybe some are still in flight ...) -- Thanks, David / dhildenb

Re: [RFC][PATCH 00/12] mm: tweak page cache migration

2020-10-07 Thread Michal Hocko
Am I the only one missing patch 1-5? lore.k.o doesn't seem to link them under this message id either. On Tue 06-10-20 13:51:03, Dave Hansen wrote: > First of all, I think this little slice of code is a bit > under-documented. Perhaps this will help clarify things. > > I'm pretty confident the

Re: [RFC][PATCH 00/12] mm: tweak page cache migration

2020-10-06 Thread Dave Hansen
Ugh, sorry about that. I fat-fingered the wrong cover letter! This should have been Subject: [v4] Migrate Pages in lieu of discard -- Changes since (automigrate-20200818): * Fall back to normal reclaim when demotion fails The full series is also available here:

[RFC][PATCH 00/12] mm: tweak page cache migration

2020-10-06 Thread Dave Hansen
First of all, I think this little slice of code is a bit under-documented. Perhaps this will help clarify things. I'm pretty confident the page_count() check in the first patch is right, which is why I removed it outright. The xas_load() check is a bit murkier, so I just left a warning in for