Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-31 Thread Josh Poimboeuf
On Thu, May 30, 2019 at 04:52:19PM -0700, Matt Helsley wrote: > > > objtool orc+mcount ? > > > > > > That is, have '+' be a separator for cmd thingies. That would of course > > > require all other arguments to be shared between all commands, which is > > > currently already so, but I've not

Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-30 Thread Matt Helsley
On Wed, May 29, 2019 at 09:11:45AM -0500, Josh Poimboeuf wrote: > On Wed, May 29, 2019 at 03:41:52PM +0200, Peter Zijlstra wrote: > > On Tue, May 28, 2019 at 09:43:28AM -0500, Josh Poimboeuf wrote: > > > Would it be feasible to eventually combine subcommands so that objtool > > > could do both ORC

Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-29 Thread Josh Poimboeuf
On Wed, May 29, 2019 at 03:41:52PM +0200, Peter Zijlstra wrote: > On Tue, May 28, 2019 at 09:43:28AM -0500, Josh Poimboeuf wrote: > > Would it be feasible to eventually combine subcommands so that objtool > > could do both ORC and mcount generation in a single invocation? I > > wonder what what

Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-29 Thread Peter Zijlstra
On Tue, May 28, 2019 at 09:43:28AM -0500, Josh Poimboeuf wrote: > Would it be feasible to eventually combine subcommands so that objtool > could do both ORC and mcount generation in a single invocation? I > wonder what what the interface would look like. objtool orc+mcount ? That is, have '+'

Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-28 Thread Steven Rostedt
On Tue, 28 May 2019 09:43:28 -0500 Josh Poimboeuf wrote: > Thanks for the patches. This looks like a good step in the right > direction. Good to hear. > > What's the performance difference between the old recordmcount and the > new version which relies on elf_open()? It would be useful to

Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-28 Thread Josh Poimboeuf
On Wed, May 22, 2019 at 05:03:23PM -0700, Matt Helsley wrote: > This series cleans up recordmcount and then makes it into > an objtool subcommand. > > The series starts with 8 cleanup patches which make recordmcount > easier to review and integrate with objtool. The final 5 patches > show the

[RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-22 Thread Matt Helsley
This series cleans up recordmcount and then makes it into an objtool subcommand. The series starts with 8 cleanup patches which make recordmcount easier to review and integrate with objtool. The final 5 patches show the beginning steps of converting recordmcount to use objtool's ELF code rather