Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

On Fri, Apr 22, 2016 at 01:09:38PM +0200, Geert Uytterhoeven wrote: > On Fri, Apr 22, 2016 at 11:04 AM, Peter Zijlstra wrote: > > All the atomic operations have their arguments the wrong way around; > > s/wrong/other/? Nah, I find they really are the wrong way around. I

Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

On Fri, Apr 22, 2016 at 01:09:38PM +0200, Geert Uytterhoeven wrote: > On Fri, Apr 22, 2016 at 11:04 AM, Peter Zijlstra wrote: > > All the atomic operations have their arguments the wrong way around; > > s/wrong/other/? Nah, I find they really are the wrong way around. I forever write:

Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

On Fri, Apr 22, 2016 at 11:04 AM, Peter Zijlstra wrote: > All the atomic operations have their arguments the wrong way around; s/wrong/other/? > make atomic_fetch_or() consistent and flip them. BTW, there are a few other inconsistencies: atomic_add_unless()

Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

On Fri, Apr 22, 2016 at 11:04 AM, Peter Zijlstra wrote: > All the atomic operations have their arguments the wrong way around; s/wrong/other/? > make atomic_fetch_or() consistent and flip them. BTW, there are a few other inconsistencies: atomic_add_unless() atomic_cmpxchg()

Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

On Fri, Apr 22, 2016 at 11:04:14AM +0200, Peter Zijlstra wrote: > All the atomic operations have their arguments the wrong way around; > make atomic_fetch_or() consistent and flip them. > > Signed-off-by: Peter Zijlstra (Intel) > --- > include/linux/atomic.h |4 ++--

Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

On Fri, Apr 22, 2016 at 11:04:14AM +0200, Peter Zijlstra wrote: > All the atomic operations have their arguments the wrong way around; > make atomic_fetch_or() consistent and flip them. > > Signed-off-by: Peter Zijlstra (Intel) > --- > include/linux/atomic.h |4 ++-- >

[RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

All the atomic operations have their arguments the wrong way around; make atomic_fetch_or() consistent and flip them. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/atomic.h |4 ++-- kernel/time/tick-sched.c |4 ++-- 2 files changed, 4 insertions(+), 4

[RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

All the atomic operations have their arguments the wrong way around; make atomic_fetch_or() consistent and flip them. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/atomic.h |4 ++-- kernel/time/tick-sched.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ---