Re: [RFC][PATCH 1/4] time: Fix clock->read(clock) race around clocksource changes

2017-05-27 Thread Ingo Molnar
* John Stultz wrote: > In some testing on arm64 platforms, I was seeing null ptr > crashes in the kselftest/timers clocksource-switch test. > > This was happening in a read function like: > u64 clocksource_mmio_readl_down(struct clocksource *c) > { > return

Re: [RFC][PATCH 1/4] time: Fix clock->read(clock) race around clocksource changes

2017-05-27 Thread Ingo Molnar
* John Stultz wrote: > In some testing on arm64 platforms, I was seeing null ptr > crashes in the kselftest/timers clocksource-switch test. > > This was happening in a read function like: > u64 clocksource_mmio_readl_down(struct clocksource *c) > { > return

[RFC][PATCH 1/4] time: Fix clock->read(clock) race around clocksource changes

2017-05-26 Thread John Stultz
In some testing on arm64 platforms, I was seeing null ptr crashes in the kselftest/timers clocksource-switch test. This was happening in a read function like: u64 clocksource_mmio_readl_down(struct clocksource *c) { return ~(u64)readl_relaxed(to_mmio_clksrc(c)->reg) & c->mask; } Where the

[RFC][PATCH 1/4] time: Fix clock->read(clock) race around clocksource changes

2017-05-26 Thread John Stultz
In some testing on arm64 platforms, I was seeing null ptr crashes in the kselftest/timers clocksource-switch test. This was happening in a read function like: u64 clocksource_mmio_readl_down(struct clocksource *c) { return ~(u64)readl_relaxed(to_mmio_clksrc(c)->reg) & c->mask; } Where the