On Thu, 2012-07-19 at 16:07 -0700, H. Peter Anvin wrote:
> On 07/19/2012 04:04 PM, Steven Rostedt wrote:
>
> > Basically, all we want to do is add 8 to the stack pointer. And this is
> > for the x86_32 version of whatever hardware is in use.
> >
>
> What I'm telling you is that it depends on
On 07/19/2012 04:04 PM, Steven Rostedt wrote:
> On Thu, 2012-07-19 at 15:53 -0700, H. Peter Anvin wrote:
>
>> lea is not typically faster than add, but in the case of Atom, it is
>> done in an earlier pipeline stage (AGU instead of ALU) which means lea
>> is faster if its inputs are already
On Thu, 2012-07-19 at 15:53 -0700, H. Peter Anvin wrote:
> lea is not typically faster than add, but in the case of Atom, it is
> done in an earlier pipeline stage (AGU instead of ALU) which means lea
> is faster if its inputs are already available as address expressions and
> is consumed by
On 07/19/2012 05:58 AM, Steven Rostedt wrote:
>>
>> also, because lea is faster than add (and doesn't even modify flags), I
>> changed the last part to use lea instead of addl.
>
> Now I'm told that this is not always the case (at least not for Atom),
> so I reverted this part and put back the
On Thu, 2012-07-19 at 08:52 -0400, Steven Rostedt wrote:
> On Thu, 2012-07-19 at 11:20 +0900, Masami Hiramatsu wrote:
> > (2012/07/19 0:59), Steven Rostedt wrote:
> > > On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
> > >
> > > Masami, can you give your Reviewed-by tag for this version?
On Thu, 2012-07-19 at 08:52 -0400, Steven Rostedt wrote:
>
> GLOBAL(ftrace_regs_call)
> call ftrace_stub
> @@ -1195,8 +1194,8 @@ GLOBAL(ftrace_regs_call)
> popl %es
> popl %fs
> popl %gs
> - addl $8, %esp /* Skip orig_ax and ip */
> - popf
On Thu, 2012-07-19 at 11:20 +0900, Masami Hiramatsu wrote:
> (2012/07/19 0:59), Steven Rostedt wrote:
> > On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
> >
> > Masami, can you give your Reviewed-by tag for this version? Or is there
> > something else needing to be fixed?
>
> No, that
On Thu, 2012-07-19 at 11:20 +0900, Masami Hiramatsu wrote:
(2012/07/19 0:59), Steven Rostedt wrote:
On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
Masami, can you give your Reviewed-by tag for this version? Or is there
something else needing to be fixed?
No, that is OK for
On Thu, 2012-07-19 at 08:52 -0400, Steven Rostedt wrote:
GLOBAL(ftrace_regs_call)
call ftrace_stub
@@ -1195,8 +1194,8 @@ GLOBAL(ftrace_regs_call)
popl %es
popl %fs
popl %gs
- addl $8, %esp /* Skip orig_ax and ip */
- popf/*
On Thu, 2012-07-19 at 08:52 -0400, Steven Rostedt wrote:
On Thu, 2012-07-19 at 11:20 +0900, Masami Hiramatsu wrote:
(2012/07/19 0:59), Steven Rostedt wrote:
On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
Masami, can you give your Reviewed-by tag for this version? Or is there
On 07/19/2012 05:58 AM, Steven Rostedt wrote:
also, because lea is faster than add (and doesn't even modify flags), I
changed the last part to use lea instead of addl.
Now I'm told that this is not always the case (at least not for Atom),
so I reverted this part and put back the addl. But
On Thu, 2012-07-19 at 15:53 -0700, H. Peter Anvin wrote:
lea is not typically faster than add, but in the case of Atom, it is
done in an earlier pipeline stage (AGU instead of ALU) which means lea
is faster if its inputs are already available as address expressions and
is consumed by address
On 07/19/2012 04:04 PM, Steven Rostedt wrote:
On Thu, 2012-07-19 at 15:53 -0700, H. Peter Anvin wrote:
lea is not typically faster than add, but in the case of Atom, it is
done in an earlier pipeline stage (AGU instead of ALU) which means lea
is faster if its inputs are already available as
On Thu, 2012-07-19 at 16:07 -0700, H. Peter Anvin wrote:
On 07/19/2012 04:04 PM, Steven Rostedt wrote:
Basically, all we want to do is add 8 to the stack pointer. And this is
for the x86_32 version of whatever hardware is in use.
What I'm telling you is that it depends on the
(2012/07/19 0:59), Steven Rostedt wrote:
> On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
>
> Masami, can you give your Reviewed-by tag for this version? Or is there
> something else needing to be fixed?
No, that is OK for me. I've just missed that...
Reviewed-by: Masami Hiramatsu
On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
Masami, can you give your Reviewed-by tag for this version? Or is there
something else needing to be fixed?
Thanks!
-- Steve
> From: Steven Rostedt
> Date: Tue, 5 Jun 2012 20:00:11 -0400
> Subject: [PATCH] ftrace/x86: Add save_regs for
On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
Masami, can you give your Reviewed-by tag for this version? Or is there
something else needing to be fixed?
Thanks!
-- Steve
From: Steven Rostedt srost...@redhat.com
Date: Tue, 5 Jun 2012 20:00:11 -0400
Subject: [PATCH] ftrace/x86:
(2012/07/19 0:59), Steven Rostedt wrote:
On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote:
Masami, can you give your Reviewed-by tag for this version? Or is there
something else needing to be fixed?
No, that is OK for me. I've just missed that...
Reviewed-by: Masami Hiramatsu
(2012/07/17 12:05), Steven Rostedt wrote:
> On Tue, 2012-07-17 at 11:08 +0900, Masami Hiramatsu wrote:
>
>>> I found that regs_get_register() doesn't honor this either. Thus,
>>> kprobes in tracing gets this:
>>>
>>> # echo 'p:ftrace sys_read+4 s=%sp' > /debug/tracing/kprobe_events
>>> # echo 1
On Tue, 2012-07-17 at 11:08 +0900, Masami Hiramatsu wrote:
> > I found that regs_get_register() doesn't honor this either. Thus,
> > kprobes in tracing gets this:
> >
> > # echo 'p:ftrace sys_read+4 s=%sp' > /debug/tracing/kprobe_events
> > # echo 1 > /debug/tracing/events/kprobes/enable
> >
(2012/07/14 3:47), Steven Rostedt wrote:
> On Thu, 2012-07-12 at 21:39 +0900, Masami Hiramatsu wrote:
>
>> /*
>> * X86_32 CPUs don't save ss and esp if the CPU is already in kernel mode
>> * when it traps. The previous stack will be directly underneath the saved
>> * registers, and 'sp/ss'
(2012/07/14 3:47), Steven Rostedt wrote:
On Thu, 2012-07-12 at 21:39 +0900, Masami Hiramatsu wrote:
/*
* X86_32 CPUs don't save ss and esp if the CPU is already in kernel mode
* when it traps. The previous stack will be directly underneath the saved
* registers, and 'sp/ss' won't even
On Tue, 2012-07-17 at 11:08 +0900, Masami Hiramatsu wrote:
I found that regs_get_register() doesn't honor this either. Thus,
kprobes in tracing gets this:
# echo 'p:ftrace sys_read+4 s=%sp' /debug/tracing/kprobe_events
# echo 1 /debug/tracing/events/kprobes/enable
# cat trace
(2012/07/17 12:05), Steven Rostedt wrote:
On Tue, 2012-07-17 at 11:08 +0900, Masami Hiramatsu wrote:
I found that regs_get_register() doesn't honor this either. Thus,
kprobes in tracing gets this:
# echo 'p:ftrace sys_read+4 s=%sp' /debug/tracing/kprobe_events
# echo 1
I'm slowly getting this patch set into working order ;-)
On Thu, 2012-07-12 at 21:39 +0900, Masami Hiramatsu wrote:
>
> > +ENTRY(ftrace_regs_caller)
> > + pushf /* push flags before compare (in ss location) */
> > + cmpl $0, function_trace_stop
> > + jne ftrace_restore_flags
> > +
> >
(2012/07/12 4:50), Steven Rostedt wrote:
> From: Steven Rostedt
>
> Add saving full regs for function tracing on i386.
> The saving of regs was influenced by patches sent out by
> Masami Hiramatsu.
>
> Cc: Masami Hiramatsu
> Signed-off-by: Steven Rostedt
> ---
> arch/x86/include/asm/ftrace.h
(2012/07/12 4:50), Steven Rostedt wrote:
From: Steven Rostedt srost...@redhat.com
Add saving full regs for function tracing on i386.
The saving of regs was influenced by patches sent out by
Masami Hiramatsu.
Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Signed-off-by: Steven
I'm slowly getting this patch set into working order ;-)
On Thu, 2012-07-12 at 21:39 +0900, Masami Hiramatsu wrote:
+ENTRY(ftrace_regs_caller)
+ pushf /* push flags before compare (in ss location) */
+ cmpl $0, function_trace_stop
+ jne ftrace_restore_flags
+
+ pushl
From: Steven Rostedt
Add saving full regs for function tracing on i386.
The saving of regs was influenced by patches sent out by
Masami Hiramatsu.
Cc: Masami Hiramatsu
Signed-off-by: Steven Rostedt
---
arch/x86/include/asm/ftrace.h |2 --
arch/x86/kernel/entry_32.S| 58
From: Steven Rostedt srost...@redhat.com
Add saving full regs for function tracing on i386.
The saving of regs was influenced by patches sent out by
Masami Hiramatsu.
Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Signed-off-by: Steven Rostedt rost...@goodmis.org
---
30 matches
Mail list logo
