Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Dan Streetman
On Wed, Jun 10, 2015 at 8:59 PM, Sergey Senozhatsky wrote: > On (06/10/15 17:48), Joe Perches wrote: > [..] >> > > > For consistency, tweak zpool_destroy_pool() and NULL-check the >> > > > pointer there. >> > > > >> > > > Proposed by Andrew Morton. >> > > > >> > > > Signed-off-by: Sergey

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Sergey Senozhatsky
On (06/10/15 17:48), Joe Perches wrote: [..] > > > > For consistency, tweak zpool_destroy_pool() and NULL-check the > > > > pointer there. > > > > > > > > Proposed by Andrew Morton. > > > > > > > > Signed-off-by: Sergey Senozhatsky > > > > Reported-by: Andrew Morton > > > > LKML-reference:

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Joe Perches
On Thu, 2015-06-11 at 08:58 +0900, Sergey Senozhatsky wrote: > On (06/10/15 16:59), Dan Streetman wrote: > > On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky > > wrote: > > > zpool_destroy_pool() does not tolerate a NULL zpool pointer > > > argument and performs a NULL-pointer dereference.

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Sergey Senozhatsky
On (06/10/15 16:59), Dan Streetman wrote: > On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky > wrote: > > zpool_destroy_pool() does not tolerate a NULL zpool pointer > > argument and performs a NULL-pointer dereference. Although > > there is only one zpool_destroy_pool() user (as of 4.1), > >

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Dan Streetman
On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky wrote: > zpool_destroy_pool() does not tolerate a NULL zpool pointer > argument and performs a NULL-pointer dereference. Although > there is only one zpool_destroy_pool() user (as of 4.1), > still update it to be coherent with the corresponding >

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Dan Streetman
On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky sergey.senozhat...@gmail.com wrote: zpool_destroy_pool() does not tolerate a NULL zpool pointer argument and performs a NULL-pointer dereference. Although there is only one zpool_destroy_pool() user (as of 4.1), still update it to be coherent

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Sergey Senozhatsky
On (06/10/15 16:59), Dan Streetman wrote: On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky sergey.senozhat...@gmail.com wrote: zpool_destroy_pool() does not tolerate a NULL zpool pointer argument and performs a NULL-pointer dereference. Although there is only one zpool_destroy_pool()

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Sergey Senozhatsky
On (06/10/15 17:48), Joe Perches wrote: [..] For consistency, tweak zpool_destroy_pool() and NULL-check the pointer there. Proposed by Andrew Morton. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com Reported-by: Andrew Morton a...@linux-foundation.org

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Dan Streetman
On Wed, Jun 10, 2015 at 8:59 PM, Sergey Senozhatsky sergey.senozhatsky.w...@gmail.com wrote: On (06/10/15 17:48), Joe Perches wrote: [..] For consistency, tweak zpool_destroy_pool() and NULL-check the pointer there. Proposed by Andrew Morton. Signed-off-by: Sergey

Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-10 Thread Joe Perches
On Thu, 2015-06-11 at 08:58 +0900, Sergey Senozhatsky wrote: On (06/10/15 16:59), Dan Streetman wrote: On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky sergey.senozhat...@gmail.com wrote: zpool_destroy_pool() does not tolerate a NULL zpool pointer argument and performs a NULL-pointer

[RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-09 Thread Sergey Senozhatsky
zpool_destroy_pool() does not tolerate a NULL zpool pointer argument and performs a NULL-pointer dereference. Although there is only one zpool_destroy_pool() user (as of 4.1), still update it to be coherent with the corresponding destroy() functions of the remainig pool-allocators (slab, mempool,

[RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()

2015-06-09 Thread Sergey Senozhatsky
zpool_destroy_pool() does not tolerate a NULL zpool pointer argument and performs a NULL-pointer dereference. Although there is only one zpool_destroy_pool() user (as of 4.1), still update it to be coherent with the corresponding destroy() functions of the remainig pool-allocators (slab, mempool,