Re: [RFC] Status of orinoco_usb

2020-10-06 Thread Dan Williams
On Tue, 2020-10-06 at 08:40 -0400, Jes Sorensen wrote: > On 10/6/20 3:45 AM, Arend Van Spriel wrote: > > + Jes > > > > On 10/5/2020 4:12 PM, Kalle Valo wrote: > > > Greg Kroah-Hartman writes: > > > > > > > On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej > > > > Siewior > > > > wrote:

Re: [RFC] Status of orinoco_usb

2020-10-06 Thread Jes Sorensen
On 10/6/20 3:45 AM, Arend Van Spriel wrote: > + Jes > > On 10/5/2020 4:12 PM, Kalle Valo wrote: >> Greg Kroah-Hartman writes: >> >>> On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior >>> wrote: On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote: >> Is it possible

Re: [RFC] Status of orinoco_usb

2020-10-06 Thread Arend Van Spriel
+ Jes On 10/5/2020 4:12 PM, Kalle Valo wrote: Greg Kroah-Hartman writes: On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior wrote: On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote: Is it possible to end up here in softirq context or is this a relic? I think it's a

Re: [RFC] Status of orinoco_usb

2020-10-05 Thread Kalle Valo
Greg Kroah-Hartman writes: > On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior wrote: >> On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote: >> > > Is it possible to end up here in softirq context or is this a relic? >> > >> > I think it's a relic of where USB host contro

Re: [RFC] Status of orinoco_usb

2020-10-02 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 01:53:58PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote: > > > Is it possible to end up here in softirq context or is this a relic? > > > > I think it's a relic of where USB host controllers completed their urbs > > in h

Re: [RFC] Status of orinoco_usb

2020-10-02 Thread Sebastian Andrzej Siewior
On 2020-10-02 13:37:25 [+0200], Greg Kroah-Hartman wrote: > > Is it possible to end up here in softirq context or is this a relic? > > I think it's a relic of where USB host controllers completed their urbs > in hard-irq mode. The BH/tasklet change is a pretty recent change. But the BH thingy fo

Re: [RFC] Status of orinoco_usb

2020-10-02 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 12:35:17PM +0200, Sebastian Andrzej Siewior wrote: > I was trying to get rid of the in in_softirq() in ezusb_req_ctx_wait() > within the orinoco usb driver, > drivers/net/wireless/intersil/orinoco/orinoco_usb.c. A small snippet: > > | static void ezusb_req_ctx_wait(struct e

[RFC] Status of orinoco_usb

2020-10-02 Thread Sebastian Andrzej Siewior
I was trying to get rid of the in in_softirq() in ezusb_req_ctx_wait() within the orinoco usb driver, drivers/net/wireless/intersil/orinoco/orinoco_usb.c. A small snippet: | static void ezusb_req_ctx_wait(struct ezusb_priv *upriv, |struct request_context *ctx) … |