Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-15 Thread Ingo Molnar
On Fri, 13 Oct 2000, Linus Torvalds wrote: > Ingo, I'd like you to comment on all the PAE issues just in case, but > I personally don't have any real issues any more. [...] there is one small thing apart of the issue Stephen noticed, barrier() between the two 32-bit writes should IMO be

Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-15 Thread Ingo Molnar
On Sat, 14 Oct 2000, Stephen Tweedie wrote: > Looks good. The only trouble I can see left is that pte_clear() is > still using set_pte(), which doesn't work right for PAE36. set_pte() > is setting the high word first, which is fine for installing a new > pte, but if you do that to clear a pte

Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-14 Thread Stephen Tweedie
Hi, On Fri, Oct 13, 2000 at 08:17:42PM -0400, Ben LaHaise wrote: > > Below is take two of the patch making pte_clear use atomic xchg in an > effort to avoid the loss of dirty bits. PAE no longer uses cmpxchg8 for > updates; set_pte is two ordered long writes with a barrier. Looks good. The

Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-14 Thread David S. Miller
Date:Fri, 13 Oct 2000 18:43:47 -0700 (PDT) From: Linus Torvalds <[EMAIL PROTECTED]> I dislike the "__HAVE_ARCH_xxx" approach, and considering that most architectures will probably want to do something specific anyway I wonder if we should get rid of that and just make

Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-14 Thread David S. Miller
Date:Fri, 13 Oct 2000 18:43:47 -0700 (PDT) From: Linus Torvalds [EMAIL PROTECTED] I dislike the "__HAVE_ARCH_xxx" approach, and considering that most architectures will probably want to do something specific anyway I wonder if we should get rid of that and just make

Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-14 Thread Stephen Tweedie
Hi, On Fri, Oct 13, 2000 at 08:17:42PM -0400, Ben LaHaise wrote: Below is take two of the patch making pte_clear use atomic xchg in an effort to avoid the loss of dirty bits. PAE no longer uses cmpxchg8 for updates; set_pte is two ordered long writes with a barrier. Looks good. The only

Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-13 Thread Linus Torvalds
On Fri, 13 Oct 2000, Ben LaHaise wrote: > > Hey folks Me likee. This looks much nicer. The hack turned into something that looks quite ddesigned. Ingo, I'd like you to comment on all the PAE issues just in case, but I personally don't have any real issues any more. Small nit: I dislike the

[RFC] atomic pte updates and pae changes, take 2

2000-10-13 Thread Ben LaHaise
Hey folks Below is take two of the patch making pte_clear use atomic xchg in an effort to avoid the loss of dirty bits. PAE no longer uses cmpxchg8 for updates; set_pte is two ordered long writes with a barrier. The use of long long for ptes is also removed; gcc should generate better code

[RFC] atomic pte updates and pae changes, take 2

2000-10-13 Thread Ben LaHaise
Hey folks Below is take two of the patch making pte_clear use atomic xchg in an effort to avoid the loss of dirty bits. PAE no longer uses cmpxchg8 for updates; set_pte is two ordered long writes with a barrier. The use of long long for ptes is also removed; gcc should generate better code

Re: [RFC] atomic pte updates and pae changes, take 2

2000-10-13 Thread Linus Torvalds
On Fri, 13 Oct 2000, Ben LaHaise wrote: Hey folks Me likee. This looks much nicer. The hack turned into something that looks quite ddesigned. Ingo, I'd like you to comment on all the PAE issues just in case, but I personally don't have any real issues any more. Small nit: I dislike the