Re: [RFC] gpio: add set_active_low() function to gpio_chip

2015-03-27 Thread Linus Walleij
On Wed, Mar 18, 2015 at 9:16 PM, David Cohen wrote: > +++ b/drivers/gpio/gpiolib-sysfs.c > @@ -289,11 +289,15 @@ static DEVICE_ATTR(edge, 0644, gpio_edge_show, > gpio_edge_store); > static int sysfs_set_active_low(struct gpio_desc *desc, struct device *dev, >

Re: [RFC] gpio: add set_active_low() function to gpio_chip

2015-03-27 Thread Linus Walleij
On Wed, Mar 18, 2015 at 9:16 PM, David Cohen david.a.co...@linux.intel.com wrote: +++ b/drivers/gpio/gpiolib-sysfs.c @@ -289,11 +289,15 @@ static DEVICE_ATTR(edge, 0644, gpio_edge_show, gpio_edge_store); static int sysfs_set_active_low(struct gpio_desc *desc, struct device *dev,

Re: [RFC] gpio: add set_active_low() function to gpio_chip

2015-03-19 Thread Stephen Warren
On 03/18/2015 08:07 PM, Alexandre Courbot wrote: On Thu, Mar 19, 2015 at 5:16 AM, David Cohen wrote: Some gpio controllers are capable of programming its pins' active-low state. Let's add this new gpio_chip function for such cases and use it in gpiolib. When set_active_low() is implemented,

Re: [RFC] gpio: add set_active_low() function to gpio_chip

2015-03-19 Thread Stephen Warren
On 03/18/2015 08:07 PM, Alexandre Courbot wrote: On Thu, Mar 19, 2015 at 5:16 AM, David Cohen david.a.co...@linux.intel.com wrote: Some gpio controllers are capable of programming its pins' active-low state. Let's add this new gpio_chip function for such cases and use it in gpiolib. When

Re: [RFC] gpio: add set_active_low() function to gpio_chip

2015-03-18 Thread Alexandre Courbot
On Thu, Mar 19, 2015 at 5:16 AM, David Cohen wrote: > Some gpio controllers are capable of programming its pins' active-low > state. Let's add this new gpio_chip function for such cases and use it > in gpiolib. > > When set_active_low() is implemented, we no longer need to do soft flips > on

[RFC] gpio: add set_active_low() function to gpio_chip

2015-03-18 Thread David Cohen
Some gpio controllers are capable of programming its pins' active-low state. Let's add this new gpio_chip function for such cases and use it in gpiolib. When set_active_low() is implemented, we no longer need to do soft flips on values from non-raw get functions. Signed-off-by: David Cohen ---

Re: [RFC] gpio: add set_active_low() function to gpio_chip

2015-03-18 Thread Alexandre Courbot
On Thu, Mar 19, 2015 at 5:16 AM, David Cohen david.a.co...@linux.intel.com wrote: Some gpio controllers are capable of programming its pins' active-low state. Let's add this new gpio_chip function for such cases and use it in gpiolib. When set_active_low() is implemented, we no longer need to

[RFC] gpio: add set_active_low() function to gpio_chip

2015-03-18 Thread David Cohen
Some gpio controllers are capable of programming its pins' active-low state. Let's add this new gpio_chip function for such cases and use it in gpiolib. When set_active_low() is implemented, we no longer need to do soft flips on values from non-raw get functions. Signed-off-by: David Cohen