Re: [RFC] init.h: mark init functions hot instead of cold

2015-05-09 Thread Josh Triplett
On Sat, May 09, 2015 at 02:17:39AM -0700, Andi Kleen wrote: > On Sat, May 09, 2015 at 12:45:01AM +0200, Rasmus Villemoes wrote: > > attribute((cold)) causes gcc to optimize the function for size rather > > than speed. But since __init functions will be discarded anyway, I > > don't see why memory

Re: [RFC] init.h: mark init functions hot instead of cold

2015-05-09 Thread Andi Kleen
On Sat, May 09, 2015 at 12:45:01AM +0200, Rasmus Villemoes wrote: > attribute((cold)) causes gcc to optimize the function for size rather > than speed. But since __init functions will be discarded anyway, I > don't see why memory should be a concern. On the contrary, everybody It makes the

Re: [RFC] init.h: mark init functions hot instead of cold

2015-05-09 Thread Josh Triplett
On Sat, May 09, 2015 at 02:17:39AM -0700, Andi Kleen wrote: On Sat, May 09, 2015 at 12:45:01AM +0200, Rasmus Villemoes wrote: attribute((cold)) causes gcc to optimize the function for size rather than speed. But since __init functions will be discarded anyway, I don't see why memory should

Re: [RFC] init.h: mark init functions hot instead of cold

2015-05-09 Thread Andi Kleen
On Sat, May 09, 2015 at 12:45:01AM +0200, Rasmus Villemoes wrote: attribute((cold)) causes gcc to optimize the function for size rather than speed. But since __init functions will be discarded anyway, I don't see why memory should be a concern. On the contrary, everybody It makes the bzImage

[RFC] init.h: mark init functions hot instead of cold

2015-05-08 Thread Rasmus Villemoes
attribute((cold)) causes gcc to optimize the function for size rather than speed. But since __init functions will be discarded anyway, I don't see why memory should be a concern. On the contrary, everybody wants their box to boot faster. Using the opposite attribute, hot, causes gcc to optimize

[RFC] init.h: mark init functions hot instead of cold

2015-05-08 Thread Rasmus Villemoes
attribute((cold)) causes gcc to optimize the function for size rather than speed. But since __init functions will be discarded anyway, I don't see why memory should be a concern. On the contrary, everybody wants their box to boot faster. Using the opposite attribute, hot, causes gcc to optimize