Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Andrew Lunn
On Wed, Oct 12, 2016 at 10:05:33AM -0500, Kyle Roeschley wrote: > On Wed, Oct 12, 2016 at 02:13:06AM -0700, Florian Fainelli wrote: > > On 10/10/2016 10:41 AM, Kyle Roeschley wrote: > > > Because the SMSC PHY completes auto-negotiation before the driver is > > > ready to handle interrupts, the PHY

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Kyle Roeschley
On Tue, Oct 11, 2016 at 09:32:30AM -0500, Jeremy Linton wrote: > On 10/10/2016 12:41 PM, Kyle Roeschley wrote: > > Because the SMSC PHY completes auto-negotiation before the driver is > > ready to handle interrupts, the PHY state machine never realizes that we > > have a link. Clear the ANENABLE bi

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Kyle Roeschley
On Wed, Oct 12, 2016 at 02:13:06AM -0700, Florian Fainelli wrote: > On 10/10/2016 10:41 AM, Kyle Roeschley wrote: > > Because the SMSC PHY completes auto-negotiation before the driver is > > ready to handle interrupts, the PHY state machine never realizes that we > > have a link. Clear the ANENABLE

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Florian Fainelli
On 10/10/2016 10:41 AM, Kyle Roeschley wrote: > Because the SMSC PHY completes auto-negotiation before the driver is > ready to handle interrupts, the PHY state machine never realizes that we > have a link. Clear the ANENABLE bit on initialization, which lets > genphy_config_aneg do its thing when

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-11 Thread Jeremy Linton
On 10/10/2016 12:41 PM, Kyle Roeschley wrote: Because the SMSC PHY completes auto-negotiation before the driver is ready to handle interrupts, the PHY state machine never realizes that we have a link. Clear the ANENABLE bit on initialization, which lets genphy_config_aneg do its thing when that c

[RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-10 Thread Kyle Roeschley
Because the SMSC PHY completes auto-negotiation before the driver is ready to handle interrupts, the PHY state machine never realizes that we have a link. Clear the ANENABLE bit on initialization, which lets genphy_config_aneg do its thing when that code is hit later. While this patch does fix the