Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-06-15 Thread Song Liu
Hi Steven, > On Jun 5, 2020, at 3:02 PM, Steven Rostedt wrote: > > On Fri, 5 Jun 2020 21:58:48 + > Song Liu wrote: > >> >> How does this work in your tests? > > I started it, but got distracted by other work. It did not crash with > the little testing I did do. I wanted to also look at

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-06-05 Thread Steven Rostedt
On Fri, 5 Jun 2020 21:58:48 + Song Liu wrote: > > How does this work in your tests? I started it, but got distracted by other work. It did not crash with the little testing I did do. I wanted to also look at my patch that adds tracing to the ftrace directory too. I'll try to remember to

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-06-05 Thread Song Liu
Hi Steven, > On May 26, 2020, at 3:04 PM, Steven Rostedt wrote: > > On Tue, 26 May 2020 23:54:15 +0200 > Peter Zijlstra wrote: > >> On Tue, May 26, 2020 at 09:46:29PM +, Song Liu wrote: >>> >>> On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: On Tue, May 26, 2020 at

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-27 Thread Song Liu
> On May 26, 2020, at 10:40 PM, Masami Hiramatsu wrote: > > On Tue, 26 May 2020 21:46:29 + > Song Liu wrote: > >> >> >>> On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: >>> >>> On Tue, May 26, 2020 at 02:28:26PM -0700, Song Liu wrote: It is useful to trace functions in

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Masami Hiramatsu
On Tue, 26 May 2020 21:46:29 + Song Liu wrote: > > > > On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: > > > > On Tue, May 26, 2020 at 02:28:26PM -0700, Song Liu wrote: > >> It is useful to trace functions in kernel/event/core.c. Allow ftrace for > >> them by removing

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Song Liu
> On May 26, 2020, at 3:04 PM, Steven Rostedt wrote: > > On Tue, 26 May 2020 23:54:15 +0200 > Peter Zijlstra wrote: > >> On Tue, May 26, 2020 at 09:46:29PM +, Song Liu wrote: >>> >>> On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: On Tue, May 26, 2020 at 02:28:26PM

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Song Liu
> On May 26, 2020, at 2:54 PM, Peter Zijlstra wrote: > > On Tue, May 26, 2020 at 09:46:29PM +, Song Liu wrote: >> >> >>> On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: >>> >>> On Tue, May 26, 2020 at 02:28:26PM -0700, Song Liu wrote: It is useful to trace functions in

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Steven Rostedt
On Tue, 26 May 2020 18:04:37 -0400 Steven Rostedt wrote: > > In the early days there was a lot of issues with recursions, but I added a > lot of recursion protection since then. I'll give this patch a spin and see > if I can make it crash. I also have some patches that make both perf and the

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Steven Rostedt
On Tue, 26 May 2020 23:54:15 +0200 Peter Zijlstra wrote: > On Tue, May 26, 2020 at 09:46:29PM +, Song Liu wrote: > > > > > > > On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: > > > > > > On Tue, May 26, 2020 at 02:28:26PM -0700, Song Liu wrote: > > >> It is useful to trace

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Peter Zijlstra
On Tue, May 26, 2020 at 09:46:29PM +, Song Liu wrote: > > > > On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: > > > > On Tue, May 26, 2020 at 02:28:26PM -0700, Song Liu wrote: > >> It is useful to trace functions in kernel/event/core.c. Allow ftrace for > >> them by removing

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Song Liu
> On May 26, 2020, at 2:39 PM, Peter Zijlstra wrote: > > On Tue, May 26, 2020 at 02:28:26PM -0700, Song Liu wrote: >> It is useful to trace functions in kernel/event/core.c. Allow ftrace for >> them by removing $(CC_FLAGS_FTRACE) from Makefile. > > Did you try using the ftrace event with

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-05-26 Thread Peter Zijlstra
On Tue, May 26, 2020 at 02:28:26PM -0700, Song Liu wrote: > It is useful to trace functions in kernel/event/core.c. Allow ftrace for > them by removing $(CC_FLAGS_FTRACE) from Makefile. Did you try using the ftrace event with perf with this on?