Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Cyrill Gorcunov
On Wed, Apr 04, 2018 at 08:54:59AM -0700, Yang Shi wrote: > > Yeah, let's just drop it and have the patch in linux-next (via mmotm) > > for 2 release cycles and see whether somebody complains. > > BTW, I will do my v3 on top of the patch (drop off prctl_set_mm). Sorry for delay, will do in a

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Cyrill Gorcunov
On Wed, Apr 04, 2018 at 08:54:59AM -0700, Yang Shi wrote: > > Yeah, let's just drop it and have the patch in linux-next (via mmotm) > > for 2 release cycles and see whether somebody complains. > > BTW, I will do my v3 on top of the patch (drop off prctl_set_mm). Sorry for delay, will do in a

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Yang Shi
On 4/3/18 10:35 PM, Michal Hocko wrote: On Tue 03-04-18 16:15:20, Yang Shi wrote: On 4/3/18 3:37 PM, Cyrill Gorcunov wrote: An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Yang Shi
On 4/3/18 10:35 PM, Michal Hocko wrote: On Tue 03-04-18 16:15:20, Yang Shi wrote: On 4/3/18 3:37 PM, Cyrill Gorcunov wrote: An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Cyrill Gorcunov
On Wed, Apr 04, 2018 at 07:35:41AM +0200, Michal Hocko wrote: > > > Or we can simply drop it off because PR_SET_MM_MAP covers all needs, > > > and I would rather prefer to do that asap. > > > > Thanks for making it deprecated. I'd prefer just drop it off if nobody > > objects. The change will get

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Cyrill Gorcunov
On Wed, Apr 04, 2018 at 07:35:41AM +0200, Michal Hocko wrote: > > > Or we can simply drop it off because PR_SET_MM_MAP covers all needs, > > > and I would rather prefer to do that asap. > > > > Thanks for making it deprecated. I'd prefer just drop it off if nobody > > objects. The change will get

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-03 Thread Michal Hocko
On Tue 03-04-18 16:15:20, Yang Shi wrote: > > > On 4/3/18 3:37 PM, Cyrill Gorcunov wrote: > > An ability to manipulate mm_struct fields was introduced in > > sake of CRIU in first place. Later we provide more suitable > > and safe operation PR_SET_MM_MAP where all fields to be modifed > > are

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-03 Thread Michal Hocko
On Tue 03-04-18 16:15:20, Yang Shi wrote: > > > On 4/3/18 3:37 PM, Cyrill Gorcunov wrote: > > An ability to manipulate mm_struct fields was introduced in > > sake of CRIU in first place. Later we provide more suitable > > and safe operation PR_SET_MM_MAP where all fields to be modifed > > are

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-03 Thread Yang Shi
On 4/3/18 3:37 PM, Cyrill Gorcunov wrote: An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all fields to be modifed are passed in one structure which allows us to make more detailed

Re: [RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-03 Thread Yang Shi
On 4/3/18 3:37 PM, Cyrill Gorcunov wrote: An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all fields to be modifed are passed in one structure which allows us to make more detailed

[RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-03 Thread Cyrill Gorcunov
An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all fields to be modifed are passed in one structure which allows us to make more detailed verification. Still old interface remains

[RFC] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-03 Thread Cyrill Gorcunov
An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all fields to be modifed are passed in one structure which allows us to make more detailed verification. Still old interface remains