James Hogan writes:
> On 14/03/13 04:00, Rusty Russell wrote:
>> From: Rusty Russell
>> Subject: CONFIG_SYMBOL_PREFIX: cleanup.
...
> Reviewed-by: James Hogan
> Tested-by: James Hogan (metag)
Thanks.
> The only other special case of symbol prefixing I'm aware of is in
> scripts/genksyms/genks
On 14/03/13 04:00, Rusty Russell wrote:
> From: Rusty Russell
> Subject: CONFIG_SYMBOL_PREFIX: cleanup.
>
> We have CONFIG_SYMBOL_PREFIX, which three archs define to the string
> "_". But Al Viro broke this in "consolidate cond_syscall and
> SYSCALL_ALIAS declarations" (in linux-next), and he's
Sam Ravnborg writes:
>> actually, y'know, proof-read it.
> Hmm..
>> + $(KERNELRELEASE) "$(patsubst
>> y,_,$(CONFIG_HAVE_SYMBOL_PREFIX_UNDERSCORE))"
>>
>> +config HAVE_UNDERSCORE_SYMBOL_PREFIX
>
> HAVE_UNDERSCORE_... or HAVE_SYMBOL_... confusion.
> I prefer the HAVE_SYMBOL_...
On Wed, Mar 13, 2013 at 09:21:01AM +, James Hogan wrote:
> Hi Sam,
>
> On 13/03/13 06:31, Sam Ravnborg wrote:
> >> /* Some toolchains use a `_' prefix for all user symbols. */
> >> -#ifdef CONFIG_SYMBOL_PREFIX
> >> -#define MODULE_SYMBOL_PREFIX CONFIG_SYMBOL_PREFIX
> >> +#ifdef CONFIG_HAVE_UN
Hi Sam,
On 13/03/13 06:31, Sam Ravnborg wrote:
>> /* Some toolchains use a `_' prefix for all user symbols. */
>> -#ifdef CONFIG_SYMBOL_PREFIX
>> -#define MODULE_SYMBOL_PREFIX CONFIG_SYMBOL_PREFIX
>> +#ifdef CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX
>> +#define __VMLINUX_SYMBOL(x) _##x
>> +#define __V
> actually, y'know, proof-read it.
Hmm..
> + $(KERNELRELEASE) "$(patsubst
> y,_,$(CONFIG_HAVE_SYMBOL_PREFIX_UNDERSCORE))"
>
> +config HAVE_UNDERSCORE_SYMBOL_PREFIX
HAVE_UNDERSCORE_... or HAVE_SYMBOL_... confusion.
I prefer the HAVE_SYMBOL_... variant but no strong feelings..
Stephen Rothwell writes:
> Hi Rusty,
>
> Looks partly better. You seem to be using
> CONFIG_SYMBOL_PREFIX_UNDERSCORE but selecting
> CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX. One trivial comment below.
>
> Maybe this was an unfinished version of the patch?
Indeed. It was crap now I've applie
Hi Rusty,
On 12/03/13 04:48, Rusty Russell wrote:
> v2: Rename CONFIG_SYMBOL_PREFIX_UNDERSCORE to
> CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX,
> which is defined in arch/Kconfig and selected by the 3 archs which need
> it.
Sorry I didn't get a chance to try your patch yesterday.
> Subject: CONF
Hi Rusty,
Looks partly better. You seem to be using
CONFIG_SYMBOL_PREFIX_UNDERSCORE but selecting
CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX. One trivial comment below.
Maybe this was an unfinished version of the patch?
On Tue, 12 Mar 2013 15:18:15 +1030 Rusty Russell wrote:
>
> diff --git a/arch/
Stephen Rothwell writes:
> Hi Rusty,
>
> On Mon, 11 Mar 2013 17:05:17 +1030 Rusty Russell
> wrote:
>>
>> diff --git a/arch/blackfin/Kconfig b/arch/blackfin/Kconfig
>> index 600494c..cd0f7c7 100644
>> --- a/arch/blackfin/Kconfig
>> +++ b/arch/blackfin/Kconfig
>> @@ -1,6 +1,5 @@
>> -config SYMBOL
Hi Rusty,
On Mon, 11 Mar 2013 17:05:17 +1030 Rusty Russell wrote:
>
> diff --git a/arch/blackfin/Kconfig b/arch/blackfin/Kconfig
> index 600494c..cd0f7c7 100644
> --- a/arch/blackfin/Kconfig
> +++ b/arch/blackfin/Kconfig
> @@ -1,6 +1,5 @@
> -config SYMBOL_PREFIX
> - string
> - default "_"
James Hogan writes:
> Hi Rusty,
>
> On 08/03/13 00:03, Rusty Russell wrote:
>> James Hogan writes:
>>> Also the definition of SYMBOL_PREFIX in is removed as
>>> it conflicts, isn't used anywhere, and is defined as a string so differs
>>> from the assembly definition.
>>
>> So now, if CONFIG_SY
Hi Rusty,
On 08/03/13 00:03, Rusty Russell wrote:
> James Hogan writes:
>> Also the definition of SYMBOL_PREFIX in is removed as
>> it conflicts, isn't used anywhere, and is defined as a string so differs
>> from the assembly definition.
>
> So now, if CONFIG_SYMBOL_PREFIX, SYMBOL_PREFIX is def
James Hogan writes:
> The commit "consolidate cond_syscall and SYSCALL_ALIAS declarations"
> broke the build on blackfin and metag due to the following code:
>
> #ifndef SYMBOL_NAME
> #ifdef CONFIG_SYMBOL_PREFIX
> #define SYMBOL_NAME(x) CONFIG_SYMBOL_PREFIX ## x
> #else
> #define SYMBOL_
The commit "consolidate cond_syscall and SYSCALL_ALIAS declarations"
broke the build on blackfin and metag due to the following code:
#ifndef SYMBOL_NAME
#ifdef CONFIG_SYMBOL_PREFIX
#define SYMBOL_NAME(x) CONFIG_SYMBOL_PREFIX ## x
#else
#define SYMBOL_NAME(x) x
#endif
#endif
#defin
15 matches
Mail list logo
