Re: [RFC 01/15] drivers/base: add track framework

2014-12-15 Thread Andrzej Hajda
On 12/15/2014 01:55 PM, Mark Brown wrote: > On Sat, Dec 13, 2014 at 12:12:19AM +0100, AH wrote: >> Mark Brown wrote on 12.12.2014 17:36: >>> On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: + kfree(ptask); + + if (empty) + break;

Re: [RFC 01/15] drivers/base: add track framework

2014-12-15 Thread Mark Brown
On Sat, Dec 13, 2014 at 12:12:19AM +0100, AH wrote: > Mark Brown wrote on 12.12.2014 17:36: > >On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: > >>+ kfree(ptask); > >>+ > >>+ if (empty) > >>+ break; > >>+ > >>+

Re: [RFC 01/15] drivers/base: add track framework

2014-12-15 Thread Mark Brown
On Sat, Dec 13, 2014 at 12:12:19AM +0100, AH wrote: Mark Brown wrote on 12.12.2014 17:36: On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: + kfree(ptask); + + if (empty) + break; + + track_process_task(track, task); ...we

Re: [RFC 01/15] drivers/base: add track framework

2014-12-15 Thread Andrzej Hajda
On 12/15/2014 01:55 PM, Mark Brown wrote: On Sat, Dec 13, 2014 at 12:12:19AM +0100, AH wrote: Mark Brown wrote on 12.12.2014 17:36: On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: + kfree(ptask); + + if (empty) + break; + +

Re: [RFC 01/15] drivers/base: add track framework

2014-12-12 Thread AH
Hi Mark, Thanks for review. Mark Brown wrote on 12.12.2014 17:36: On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: track is a generic framework for safe tracking presence of any kernel objects having an id. There are no special requirements about type of object or its id. Id

Re: [RFC 01/15] drivers/base: add track framework

2014-12-12 Thread Mark Brown
On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: > track is a generic framework for safe tracking presence of any kernel objects > having an id. There are no special requirements about type of object or its > id. Id shall be unique. This is pretty confusing, when it talks about

Re: [RFC 01/15] drivers/base: add track framework

2014-12-12 Thread Mark Brown
On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: track is a generic framework for safe tracking presence of any kernel objects having an id. There are no special requirements about type of object or its id. Id shall be unique. This is pretty confusing, when it talks about kernel

Re: [RFC 01/15] drivers/base: add track framework

2014-12-12 Thread AH
Hi Mark, Thanks for review. Mark Brown wrote on 12.12.2014 17:36: On Wed, Dec 10, 2014 at 04:48:19PM +0100, Andrzej Hajda wrote: track is a generic framework for safe tracking presence of any kernel objects having an id. There are no special requirements about type of object or its id. Id

[RFC 01/15] drivers/base: add track framework

2014-12-10 Thread Andrzej Hajda
track is a generic framework for safe tracking presence of any kernel objects having an id. There are no special requirements about type of object or its id. Id shall be unique. Typical usage of the framework by consumer looks as follow: 1. Consumer registers notifier callback for objects with

[RFC 01/15] drivers/base: add track framework

2014-12-10 Thread Andrzej Hajda
track is a generic framework for safe tracking presence of any kernel objects having an id. There are no special requirements about type of object or its id. Id shall be unique. Typical usage of the framework by consumer looks as follow: 1. Consumer registers notifier callback for objects with