Re: [RFC 1/3] Slab infrastructure for array operations

2015-02-03 Thread Jesper Dangaard Brouer
On Thu, 29 Jan 2015 16:44:43 +0900 Joonsoo Kim wrote: > On Wed, Jan 28, 2015 at 09:30:56AM -0600, Christoph Lameter wrote: > > On Wed, 28 Jan 2015, Joonsoo Kim wrote: > > [...] > > > > The default when no options are specified is to first exhaust the node > > partial objects, then allocate new

Re: [RFC 1/3] Slab infrastructure for array operations

2015-02-03 Thread Jesper Dangaard Brouer
On Thu, 29 Jan 2015 16:44:43 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jan 28, 2015 at 09:30:56AM -0600, Christoph Lameter wrote: On Wed, 28 Jan 2015, Joonsoo Kim wrote: [...] The default when no options are specified is to first exhaust the node partial objects, then

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-28 Thread Joonsoo Kim
On Wed, Jan 28, 2015 at 09:30:56AM -0600, Christoph Lameter wrote: > On Wed, 28 Jan 2015, Joonsoo Kim wrote: > > > > GFP_SLAB_ARRAY new is best for large quantities in either allocator since > > > SLAB also has to construct local metadata structures. > > > > In case of SLAB, there is just a

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-28 Thread Christoph Lameter
On Wed, 28 Jan 2015, Joonsoo Kim wrote: > > GFP_SLAB_ARRAY new is best for large quantities in either allocator since > > SLAB also has to construct local metadata structures. > > In case of SLAB, there is just a little more work to construct local metadata > so > GFP_SLAB_ARRAY_NEW would not

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-28 Thread Christoph Lameter
On Wed, 28 Jan 2015, Joonsoo Kim wrote: GFP_SLAB_ARRAY new is best for large quantities in either allocator since SLAB also has to construct local metadata structures. In case of SLAB, there is just a little more work to construct local metadata so GFP_SLAB_ARRAY_NEW would not show

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-28 Thread Joonsoo Kim
On Wed, Jan 28, 2015 at 09:30:56AM -0600, Christoph Lameter wrote: On Wed, 28 Jan 2015, Joonsoo Kim wrote: GFP_SLAB_ARRAY new is best for large quantities in either allocator since SLAB also has to construct local metadata structures. In case of SLAB, there is just a little more work

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-27 Thread Joonsoo Kim
2015-01-28 1:57 GMT+09:00 Christoph Lameter : > On Tue, 27 Jan 2015, Joonsoo Kim wrote: > >> IMHO, exposing these options is not a good idea. It's really >> implementation specific. And, this flag won't show consistent performance >> according to specific slab implementation. For example, to get

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-27 Thread Christoph Lameter
On Tue, 27 Jan 2015, Joonsoo Kim wrote: > IMHO, exposing these options is not a good idea. It's really > implementation specific. And, this flag won't show consistent performance > according to specific slab implementation. For example, to get best > performance, if SLAB is used,

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-27 Thread Joonsoo Kim
On Fri, Jan 23, 2015 at 03:37:28PM -0600, Christoph Lameter wrote: > This patch adds the basic infrastructure for alloc / free operations > on pointer arrays. It includes a fallback function that can perform > the array operations using the single alloc and free that every > slab allocator

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-27 Thread Joonsoo Kim
On Fri, Jan 23, 2015 at 03:37:28PM -0600, Christoph Lameter wrote: This patch adds the basic infrastructure for alloc / free operations on pointer arrays. It includes a fallback function that can perform the array operations using the single alloc and free that every slab allocator performs.

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-27 Thread Joonsoo Kim
2015-01-28 1:57 GMT+09:00 Christoph Lameter c...@linux.com: On Tue, 27 Jan 2015, Joonsoo Kim wrote: IMHO, exposing these options is not a good idea. It's really implementation specific. And, this flag won't show consistent performance according to specific slab implementation. For example, to

Re: [RFC 1/3] Slab infrastructure for array operations

2015-01-27 Thread Christoph Lameter
On Tue, 27 Jan 2015, Joonsoo Kim wrote: IMHO, exposing these options is not a good idea. It's really implementation specific. And, this flag won't show consistent performance according to specific slab implementation. For example, to get best performance, if SLAB is used, GFP_SLAB_ARRAY_LOCAL

[RFC 1/3] Slab infrastructure for array operations

2015-01-23 Thread Christoph Lameter
This patch adds the basic infrastructure for alloc / free operations on pointer arrays. It includes a fallback function that can perform the array operations using the single alloc and free that every slab allocator performs. Allocators must define _HAVE_SLAB_ALLOCATOR_OPERATIONS in their header

[RFC 1/3] Slab infrastructure for array operations

2015-01-23 Thread Christoph Lameter
This patch adds the basic infrastructure for alloc / free operations on pointer arrays. It includes a fallback function that can perform the array operations using the single alloc and free that every slab allocator performs. Allocators must define _HAVE_SLAB_ALLOCATOR_OPERATIONS in their header