Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chuck Ebbert
On 07/20/2007 12:36 PM, Stefan Richter wrote: +config STABLE + bool "Stable kernel" > > PS: Imagine the headlines at Slashdot, CNET et al when this gets in. I think this really should be called CONFIG_EXTRA_CHECKS. It's a lot clearer what that means... - To unsubscribe from

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Stefan Richter
Chris Snook wrote: > There are many different ways you can use it. If I'm writing a configurable > feature, I could make it depend on !CONFIG_STABLE, or I could ifdef my code > out > if CONFIG_STABLE is set, unless a more granular option is also set. The > maintainer of the code that uses

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Stefan Richter
>>> +config STABLE >>> + bool "Stable kernel" PS: Imagine the headlines at Slashdot, CNET et al when this gets in. -- Stefan Richter -=-=-=== -=== =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Stefan Richter
(I missed the original post, hence am replying to te reply...) > On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> Introduce CONFIG_STABLE to control checks only useful for development. >> >> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> >> [...] >> menu "General setup" >> >>

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: >> Satyam Sharma wrote: >> > [ Just cleaning up my inbox, and stumbled across this thread ... ] >> > >> > >> > On 5/31/07, [EMAIL PROTECTED] <[EMAIL

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: >> Satyam Sharma wrote: >> > [ Just cleaning up my inbox, and stumbled across this thread ... ] >> > >> > >> > On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >>

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > [ Just cleaning up my inbox, and stumbled across this thread ... ] > > > On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> Introduce CONFIG_STABLE to control checks only useful for

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > [ Just cleaning up my inbox, and stumbled across this thread ... ] > > > On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> Introduce CONFIG_STABLE to control checks only useful for development. >> >>

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: [ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> [...] menu "General

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
[ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> [...] menu "General setup" +config STABLE +

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
On 7/20/07, Chris Snook [EMAIL PROTECTED] wrote: Satyam Sharma wrote: [ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: [ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] [...] menu General setup

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: On 7/20/07, Chris Snook [EMAIL PROTECTED] wrote: Satyam Sharma wrote: [ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Introduce CONFIG_STABLE to control checks only useful for development.

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
On 7/20/07, Chris Snook [EMAIL PROTECTED] wrote: Satyam Sharma wrote: On 7/20/07, Chris Snook [EMAIL PROTECTED] wrote: Satyam Sharma wrote: [ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Introduce

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: On 7/20/07, Chris Snook [EMAIL PROTECTED] wrote: Satyam Sharma wrote: On 7/20/07, Chris Snook [EMAIL PROTECTED] wrote: Satyam Sharma wrote: [ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Stefan Richter
(I missed the original post, hence am replying to te reply...) On 5/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] [...] menu General setup +config STABLE +

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Stefan Richter
+config STABLE + bool Stable kernel PS: Imagine the headlines at Slashdot, CNET et al when this gets in. -- Stefan Richter -=-=-=== -=== =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Stefan Richter
Chris Snook wrote: There are many different ways you can use it. If I'm writing a configurable feature, I could make it depend on !CONFIG_STABLE, or I could ifdef my code out if CONFIG_STABLE is set, unless a more granular option is also set. The maintainer of the code that uses the

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chuck Ebbert
On 07/20/2007 12:36 PM, Stefan Richter wrote: +config STABLE + bool Stable kernel PS: Imagine the headlines at Slashdot, CNET et al when this gets in. I think this really should be called CONFIG_EXTRA_CHECKS. It's a lot clearer what that means... - To unsubscribe from this list: send

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
[ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] [...] menu General setup +config STABLE +

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Sam Ravnborg
On Fri, Jun 01, 2007 at 04:30:06PM -0400, Dave Jones wrote: > On Fri, Jun 01, 2007 at 10:22:02PM +0200, Sam Ravnborg wrote: > > On Fri, Jun 01, 2007 at 02:02:00PM -0400, Dave Jones wrote: > > > On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: > > > > > + sym =

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Dave Jones
On Fri, Jun 01, 2007 at 10:22:02PM +0200, Sam Ravnborg wrote: > On Fri, Jun 01, 2007 at 02:02:00PM -0400, Dave Jones wrote: > > On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: > > > > + sym = sym_lookup("DEVEL_KERNEL", 0); > > > > + sym->type = S_BOOLEAN; > > > > +

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Sam Ravnborg
> > With the following behaviour: > > DEVEL_KERNEL = 0 in Makefile: > > DEVEL_KERNEL=n in Kconfig > CONFIG_DEVEL_KERNEL is not set in cpp > > DEVEL_KERNEL = 1 in Makefile: > > DEVEL_KERNEL=y in Kconfig > CONFIG_DEVEL_KERNEL is set in cpp > > however the above patch

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Sam Ravnborg
On Fri, Jun 01, 2007 at 02:02:00PM -0400, Dave Jones wrote: > On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: > > > +sym = sym_lookup("DEVEL_KERNEL", 0); > > > +sym->type = S_BOOLEAN; > > > +sym->flags |= SYMBOL_AUTO; > > > +p =

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Christoph Lameter
On Fri, 1 Jun 2007, Dave Jones wrote: > > Disabling SLUB_DEBUG should only be done for embedded systems. That is why > > the option is in CONFIG_EMBEDDED. > > Something I'd really love to have is a CONFIG option to decide if > slub_debug is set or not by default. The reasoning behind this is

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Dave Jones
On Wed, May 30, 2007 at 05:49:56PM -0700, Christoph Lameter wrote: > On Thu, 31 May 2007, young dave wrote: > > > Hi Christoph, > > > > > Introduce CONFIG_STABLE to control checks only useful for development. > > > > What about control checks only as SLUB_DEBUG is set? > > Debug code

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Dave Jones
On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: > > + sym = sym_lookup("DEVEL_KERNEL", 0); > > + sym->type = S_BOOLEAN; > > + sym->flags |= SYMBOL_AUTO; > > + p = getenv("DEVEL_KERNEL"); > > + if (p && atoi(p)) > > + sym_add_default(sym, "y"); > > + else > > +

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Dave Jones
On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: + sym = sym_lookup(DEVEL_KERNEL, 0); + sym-type = S_BOOLEAN; + sym-flags |= SYMBOL_AUTO; + p = getenv(DEVEL_KERNEL); + if (p atoi(p)) + sym_add_default(sym, y); + else +

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Dave Jones
On Wed, May 30, 2007 at 05:49:56PM -0700, Christoph Lameter wrote: On Thu, 31 May 2007, young dave wrote: Hi Christoph, Introduce CONFIG_STABLE to control checks only useful for development. What about control checks only as SLUB_DEBUG is set? Debug code is always

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Christoph Lameter
On Fri, 1 Jun 2007, Dave Jones wrote: Disabling SLUB_DEBUG should only be done for embedded systems. That is why the option is in CONFIG_EMBEDDED. Something I'd really love to have is a CONFIG option to decide if slub_debug is set or not by default. The reasoning behind this is that

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Sam Ravnborg
On Fri, Jun 01, 2007 at 02:02:00PM -0400, Dave Jones wrote: On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: +sym = sym_lookup(DEVEL_KERNEL, 0); +sym-type = S_BOOLEAN; +sym-flags |= SYMBOL_AUTO; +p = getenv(DEVEL_KERNEL); +

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Sam Ravnborg
With the following behaviour: DEVEL_KERNEL = 0 in Makefile: DEVEL_KERNEL=n in Kconfig CONFIG_DEVEL_KERNEL is not set in cpp DEVEL_KERNEL = 1 in Makefile: DEVEL_KERNEL=y in Kconfig CONFIG_DEVEL_KERNEL is set in cpp however the above patch doesn't do this

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Dave Jones
On Fri, Jun 01, 2007 at 10:22:02PM +0200, Sam Ravnborg wrote: On Fri, Jun 01, 2007 at 02:02:00PM -0400, Dave Jones wrote: On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: + sym = sym_lookup(DEVEL_KERNEL, 0); + sym-type = S_BOOLEAN; + sym-flags |=

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-06-01 Thread Sam Ravnborg
On Fri, Jun 01, 2007 at 04:30:06PM -0400, Dave Jones wrote: On Fri, Jun 01, 2007 at 10:22:02PM +0200, Sam Ravnborg wrote: On Fri, Jun 01, 2007 at 02:02:00PM -0400, Dave Jones wrote: On Thu, May 31, 2007 at 11:30:46PM +0200, Sam Ravnborg wrote: + sym = sym_lookup(DEVEL_KERNEL, 0);

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Sam Ravnborg
> > So something like this: > > diff -puN Makefile~a Makefile > --- a/Makefile~a > +++ a/Makefile > @@ -3,6 +3,7 @@ PATCHLEVEL = 6 > SUBLEVEL = 22 > EXTRAVERSION = -rc3 > NAME = Jeff Thinks I Should Change This, But To What? > +DEVEL_KERNEL = 1 Could we name this: KERNELDEVEL to fit with

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Christoph Lameter
On Thu, 31 May 2007, Andrew Morton wrote: > however the above patch doesn't do this correctly and I got bored of > fiddling with it. Help? Will get something like what you described into the next release if no one else has anything to add. - To unsubscribe from this list: send the line

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Andrew Morton
On Wed, 30 May 2007 17:20:48 -0700 [EMAIL PROTECTED] wrote: > Introduce CONFIG_STABLE to control checks only useful for development. > > Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> > > --- > init/Kconfig |7 +++ > 1 file changed, 7 insertions(+) > > Index: slub/init/Kconfig >

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Stefan Richter
>> menu "General setup" >> >> +config STABLE >> +bool "Stable kernel" [...] > a) Why in Kconfig, why not in Makefile? > > b) Of course nobody wants STABLE=n. :-) How about: > > config RELEASE > bool "Build for release" > help > If the kernel is declared as a release

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread David Miller
From: Stefan Richter <[EMAIL PROTECTED]> Date: Thu, 31 May 2007 10:54:36 +0200 > b) Of course nobody wants STABLE=n. :-) How about: > > config RELEASE > bool "Build for release" > help > If the kernel is declared as a release build here, then > various checks that

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Stefan Richter
> --- slub.orig/init/Kconfig2007-05-30 16:35:05.0 -0700 > +++ slub/init/Kconfig 2007-05-30 16:35:45.0 -0700 > @@ -65,6 +65,13 @@ endmenu > > menu "General setup" > > +config STABLE > + bool "Stable kernel" > + help > + If the kernel is configured to be a

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Stefan Richter
--- slub.orig/init/Kconfig2007-05-30 16:35:05.0 -0700 +++ slub/init/Kconfig 2007-05-30 16:35:45.0 -0700 @@ -65,6 +65,13 @@ endmenu menu General setup +config STABLE + bool Stable kernel + help + If the kernel is configured to be a stable kernel then

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread David Miller
From: Stefan Richter [EMAIL PROTECTED] Date: Thu, 31 May 2007 10:54:36 +0200 b) Of course nobody wants STABLE=n. :-) How about: config RELEASE bool Build for release help If the kernel is declared as a release build here, then various checks that are only of

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Stefan Richter
menu General setup +config STABLE +bool Stable kernel [...] a) Why in Kconfig, why not in Makefile? b) Of course nobody wants STABLE=n. :-) How about: config RELEASE bool Build for release help If the kernel is declared as a release build here, then

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Andrew Morton
On Wed, 30 May 2007 17:20:48 -0700 [EMAIL PROTECTED] wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- init/Kconfig |7 +++ 1 file changed, 7 insertions(+) Index: slub/init/Kconfig

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Christoph Lameter
On Thu, 31 May 2007, Andrew Morton wrote: however the above patch doesn't do this correctly and I got bored of fiddling with it. Help? Will get something like what you described into the next release if no one else has anything to add. - To unsubscribe from this list: send the line

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Sam Ravnborg
So something like this: diff -puN Makefile~a Makefile --- a/Makefile~a +++ a/Makefile @@ -3,6 +3,7 @@ PATCHLEVEL = 6 SUBLEVEL = 22 EXTRAVERSION = -rc3 NAME = Jeff Thinks I Should Change This, But To What? +DEVEL_KERNEL = 1 Could we name this: KERNELDEVEL to fit with current naming

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-30 Thread Christoph Lameter
On Thu, 31 May 2007, young dave wrote: > Hi Christoph, > > > Introduce CONFIG_STABLE to control checks only useful for development. > > What about control checks only as SLUB_DEBUG is set? Debug code is always included in all builds unless it is an embedded system. Debug code is kept out of

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-30 Thread young dave
Hi Christoph, Introduce CONFIG_STABLE to control checks only useful for development. What about control checks only as SLUB_DEBUG is set? Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

[RFC 1/4] CONFIG_STABLE: Define it

2007-05-30 Thread clameter
Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- init/Kconfig |7 +++ 1 file changed, 7 insertions(+) Index: slub/init/Kconfig === ---

[RFC 1/4] CONFIG_STABLE: Define it

2007-05-30 Thread clameter
Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- init/Kconfig |7 +++ 1 file changed, 7 insertions(+) Index: slub/init/Kconfig === ---

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-30 Thread young dave
Hi Christoph, Introduce CONFIG_STABLE to control checks only useful for development. What about control checks only as SLUB_DEBUG is set? Regards dave - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-30 Thread Christoph Lameter
On Thu, 31 May 2007, young dave wrote: Hi Christoph, Introduce CONFIG_STABLE to control checks only useful for development. What about control checks only as SLUB_DEBUG is set? Debug code is always included in all builds unless it is an embedded system. Debug code is kept out of the hot