Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-20 Thread Jan Kara
On Fri 17-04-15 16:44:16, Andreas Dilger wrote: > On Apr 17, 2015, at 5:31 AM, Jan Kara wrote: > > On Wed 15-04-15 09:15:44, Beata Michalska wrote: > >> Introduce configurable generic interface for file > >> system-wide event notifications to provide file > >> systems with a common way of

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-20 Thread Beata Michalska
Hi, On 04/18/2015 12:44 AM, Andreas Dilger wrote: > On Apr 17, 2015, at 5:31 AM, Jan Kara wrote: >> On Wed 15-04-15 09:15:44, Beata Michalska wrote: >>> Introduce configurable generic interface for file >>> system-wide event notifications to provide file >>> systems with a common way of

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-20 Thread Jan Kara
On Fri 17-04-15 16:44:16, Andreas Dilger wrote: On Apr 17, 2015, at 5:31 AM, Jan Kara j...@suse.cz wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-20 Thread Beata Michalska
Hi, On 04/18/2015 12:44 AM, Andreas Dilger wrote: On Apr 17, 2015, at 5:31 AM, Jan Kara j...@suse.cz wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Andreas Dilger
On Apr 17, 2015, at 5:31 AM, Jan Kara wrote: > On Wed 15-04-15 09:15:44, Beata Michalska wrote: >> Introduce configurable generic interface for file >> system-wide event notifications to provide file >> systems with a common way of reporting any potential >> issues as they emerge. >> >> The

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Andreas Dilger
On Apr 17, 2015, at 11:37 AM, John Spray wrote: > On 17/04/2015 17:22, Jan Kara wrote: >> On Fri 17-04-15 17:08:10, John Spray wrote: >>> On 17/04/2015 16:43, Jan Kara wrote: >>> In that case I'm confused -- why would ENOSPC be an appropriate use >>> of this interface if the mount being entirely

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread John Spray
On 17/04/2015 17:22, Jan Kara wrote: On Fri 17-04-15 17:08:10, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: In that case I'm confused -- why would ENOSPC be an appropriate use of this interface if the mount being entirely blocked would be inappropriate? Isn't being unable to

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 12:29:07, Austin S Hemmelgarn wrote: > On 2015-04-17 12:22, Jan Kara wrote: > >On Fri 17-04-15 17:08:10, John Spray wrote: > >> > >>On 17/04/2015 16:43, Jan Kara wrote: > >>>On Fri 17-04-15 15:51:14, John Spray wrote: > On 17/04/2015 14:23, Austin S Hemmelgarn wrote: > >

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Austin S Hemmelgarn
On 2015-04-17 12:22, Jan Kara wrote: On Fri 17-04-15 17:08:10, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: For some filesystems, it may make sense to differentiate between a generic

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 17:08:10, John Spray wrote: > > On 17/04/2015 16:43, Jan Kara wrote: > >On Fri 17-04-15 15:51:14, John Spray wrote: > >>On 17/04/2015 14:23, Austin S Hemmelgarn wrote: > >> > >>>For some filesystems, it may make sense to differentiate between a > >>>generic warning and an error.

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
On 04/17/2015 06:08 PM, John Spray wrote: > > On 17/04/2015 16:43, Jan Kara wrote: >> On Fri 17-04-15 15:51:14, John Spray wrote: >>> On 17/04/2015 14:23, Austin S Hemmelgarn wrote: >>> For some filesystems, it may make sense to differentiate between a generic warning and an error. For

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread John Spray
On 17/04/2015 16:43, Jan Kara wrote: On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: For some filesystems, it may make sense to differentiate between a generic warning and an error. For BTRFS and ZFS for example, if there is a csum error on a

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 15:51:14, John Spray wrote: > On 17/04/2015 14:23, Austin S Hemmelgarn wrote: > >On 2015-04-17 09:04, Beata Michalska wrote: > >>On 04/17/2015 01:31 PM, Jan Kara wrote: > >>>On Wed 15-04-15 09:15:44, Beata Michalska wrote: > >>>... > +static const match_table_t fs_etypes = { >

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread John Spray
On 17/04/2015 14:23, Austin S Hemmelgarn wrote: On 2015-04-17 09:04, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: ... +static const match_table_t fs_etypes = { +{ FS_EVENT_INFO,"info" }, +{ FS_EVENT_WARN,

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 09:23:35, Austin S Hemmelgarn wrote: > On 2015-04-17 09:04, Beata Michalska wrote: > >On 04/17/2015 01:31 PM, Jan Kara wrote: > >>On Wed 15-04-15 09:15:44, Beata Michalska wrote: > >>... > >>>+static const match_table_t fs_etypes = { > >>>+ { FS_EVENT_INFO,"info" }, > >>>+ {

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Austin S Hemmelgarn
On 2015-04-17 09:04, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: ... +static const match_table_t fs_etypes = { + { FS_EVENT_INFO,"info" }, + { FS_EVENT_WARN,"warn" }, + { FS_EVENT_THRESH, "thr"

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 15:04:37, Beata Michalska wrote: > On 04/17/2015 01:31 PM, Jan Kara wrote: > > On Wed 15-04-15 09:15:44, Beata Michalska wrote: > > Also I think that we should make it clear that each event type has > > different set of arguments. For threshold events they'll be L1 & L2, for > >

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
On 04/17/2015 03:04 PM, Beata Michalska wrote: > On 04/17/2015 01:31 PM, Jan Kara wrote: >> On Wed 15-04-15 09:15:44, Beata Michalska wrote: >>> Introduce configurable generic interface for file >>> system-wide event notifications to provide file >>> systems with a common way of reporting any

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
On 04/17/2015 01:31 PM, Jan Kara wrote: > On Wed 15-04-15 09:15:44, Beata Michalska wrote: >> Introduce configurable generic interface for file >> system-wide event notifications to provide file >> systems with a common way of reporting any potential >> issues as they emerge. >> >> The

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Thu 16-04-15 23:56:11, Heinrich Schuchardt wrote: > On 15.04.2015 09:15, Beata Michalska wrote: > > Introduce configurable generic interface for file > > system-wide event notifications to provide file > > systems with a common way of reporting any potential > > issues as they emerge. > > > >

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Wed 15-04-15 09:15:44, Beata Michalska wrote: > Introduce configurable generic interface for file > system-wide event notifications to provide file > systems with a common way of reporting any potential > issues as they emerge. > > The notifications are to be issued through generic > netlink

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
Hi, On 04/16/2015 11:56 PM, Heinrich Schuchardt wrote: > On 15.04.2015 09:15, Beata Michalska wrote: >> Introduce configurable generic interface for file >> system-wide event notifications to provide file >> systems with a common way of reporting any potential >> issues as they emerge. >> >> The

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
Hi, On 04/16/2015 10:10 PM, Hugh Dickins wrote: > On Thu, 16 Apr 2015, Beata Michalska wrote: >> On 04/16/2015 05:46 AM, Eric Sandeen wrote: >>> On 4/15/15 2:15 AM, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Thu 16-04-15 10:22:45, Beata Michalska wrote: > On 04/15/2015 09:25 PM, Darrick J. Wong wrote: > > On Wed, Apr 15, 2015 at 09:15:44AM +0200, Beata Michalska wrote: > > > >> +#define FS_THRESH_LR_REACHED 0x0020 /* The lower range of > >> threshold has been reached */ > >>

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
Hi, On 04/16/2015 10:10 PM, Hugh Dickins wrote: On Thu, 16 Apr 2015, Beata Michalska wrote: On 04/16/2015 05:46 AM, Eric Sandeen wrote: On 4/15/15 2:15 AM, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
Hi, On 04/16/2015 11:56 PM, Heinrich Schuchardt wrote: On 15.04.2015 09:15, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Thu 16-04-15 10:22:45, Beata Michalska wrote: On 04/15/2015 09:25 PM, Darrick J. Wong wrote: On Wed, Apr 15, 2015 at 09:15:44AM +0200, Beata Michalska wrote: +#define FS_THRESH_LR_REACHED 0x0020 /* The lower range of threshold has been reached */ +#define

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Thu 16-04-15 23:56:11, Heinrich Schuchardt wrote: On 15.04.2015 09:15, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
On 04/17/2015 03:04 PM, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 09:23:35, Austin S Hemmelgarn wrote: On 2015-04-17 09:04, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: ... +static const match_table_t fs_etypes = { + { FS_EVENT_INFO,info }, + { FS_EVENT_WARN,warn

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 15:04:37, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: Also I think that we should make it clear that each event type has different set of arguments. For threshold events they'll be L1 L2, for other events

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Austin S Hemmelgarn
On 2015-04-17 09:04, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: ... +static const match_table_t fs_etypes = { + { FS_EVENT_INFO,info }, + { FS_EVENT_WARN,warn }, + { FS_EVENT_THRESH, thr }, +

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Wed 15-04-15 09:15:44, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be issued through generic netlink

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread John Spray
On 17/04/2015 14:23, Austin S Hemmelgarn wrote: On 2015-04-17 09:04, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: ... +static const match_table_t fs_etypes = { +{ FS_EVENT_INFO,info }, +{ FS_EVENT_WARN,warn

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread John Spray
On 17/04/2015 17:22, Jan Kara wrote: On Fri 17-04-15 17:08:10, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: In that case I'm confused -- why would ENOSPC be an appropriate use of this interface if the mount being entirely blocked would be inappropriate? Isn't being unable to

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 12:29:07, Austin S Hemmelgarn wrote: On 2015-04-17 12:22, Jan Kara wrote: On Fri 17-04-15 17:08:10, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: For some filesystems, it

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: On 2015-04-17 09:04, Beata Michalska wrote: On 04/17/2015 01:31 PM, Jan Kara wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: ... +static const match_table_t fs_etypes = { +{

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Jan Kara
On Fri 17-04-15 17:08:10, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: For some filesystems, it may make sense to differentiate between a generic warning and an error. For BTRFS and ZFS

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Austin S Hemmelgarn
On 2015-04-17 12:22, Jan Kara wrote: On Fri 17-04-15 17:08:10, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: For some filesystems, it may make sense to differentiate between a generic

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Beata Michalska
On 04/17/2015 06:08 PM, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: For some filesystems, it may make sense to differentiate between a generic warning and an error. For BTRFS and ZFS for

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread John Spray
On 17/04/2015 16:43, Jan Kara wrote: On Fri 17-04-15 15:51:14, John Spray wrote: On 17/04/2015 14:23, Austin S Hemmelgarn wrote: For some filesystems, it may make sense to differentiate between a generic warning and an error. For BTRFS and ZFS for example, if there is a csum error on a

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Andreas Dilger
On Apr 17, 2015, at 11:37 AM, John Spray john.sp...@redhat.com wrote: On 17/04/2015 17:22, Jan Kara wrote: On Fri 17-04-15 17:08:10, John Spray wrote: On 17/04/2015 16:43, Jan Kara wrote: In that case I'm confused -- why would ENOSPC be an appropriate use of this interface if the mount being

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-17 Thread Andreas Dilger
On Apr 17, 2015, at 5:31 AM, Jan Kara j...@suse.cz wrote: On Wed 15-04-15 09:15:44, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Heinrich Schuchardt
On 15.04.2015 09:15, Beata Michalska wrote: > Introduce configurable generic interface for file > system-wide event notifications to provide file > systems with a common way of reporting any potential > issues as they emerge. > > The notifications are to be issued through generic > netlink

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Hugh Dickins
On Thu, 16 Apr 2015, Beata Michalska wrote: > On 04/16/2015 05:46 AM, Eric Sandeen wrote: > > On 4/15/15 2:15 AM, Beata Michalska wrote: > >> Introduce configurable generic interface for file > >> system-wide event notifications to provide file > >> systems with a common way of reporting any

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Beata Michalska
On 04/16/2015 05:46 AM, Eric Sandeen wrote: > On 4/15/15 2:15 AM, Beata Michalska wrote: >> Introduce configurable generic interface for file >> system-wide event notifications to provide file >> systems with a common way of reporting any potential >> issues as they emerge. >> >> The notifications

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Beata Michalska
On 04/15/2015 09:25 PM, Darrick J. Wong wrote: > On Wed, Apr 15, 2015 at 09:15:44AM +0200, Beata Michalska wrote: >> Introduce configurable generic interface for file >> system-wide event notifications to provide file >> systems with a common way of reporting any potential >> issues as they

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Beata Michalska
On 04/15/2015 09:25 PM, Darrick J. Wong wrote: On Wed, Apr 15, 2015 at 09:15:44AM +0200, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Beata Michalska
On 04/16/2015 05:46 AM, Eric Sandeen wrote: On 4/15/15 2:15 AM, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Heinrich Schuchardt
On 15.04.2015 09:15, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be issued through generic netlink interface, by

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-16 Thread Hugh Dickins
On Thu, 16 Apr 2015, Beata Michalska wrote: On 04/16/2015 05:46 AM, Eric Sandeen wrote: On 4/15/15 2:15 AM, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-15 Thread Eric Sandeen
On 4/15/15 2:15 AM, Beata Michalska wrote: > Introduce configurable generic interface for file > system-wide event notifications to provide file > systems with a common way of reporting any potential > issues as they emerge. > > The notifications are to be issued through generic > netlink

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-15 Thread Darrick J. Wong
On Wed, Apr 15, 2015 at 09:15:44AM +0200, Beata Michalska wrote: > Introduce configurable generic interface for file > system-wide event notifications to provide file > systems with a common way of reporting any potential > issues as they emerge. > > The notifications are to be issued through

[RFC 1/4] fs: Add generic file system event notifications

2015-04-15 Thread Beata Michalska
Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be issued through generic netlink interface, by a dedicated, for file system events, multicast

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-15 Thread Darrick J. Wong
On Wed, Apr 15, 2015 at 09:15:44AM +0200, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be issued through generic

Re: [RFC 1/4] fs: Add generic file system event notifications

2015-04-15 Thread Eric Sandeen
On 4/15/15 2:15 AM, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be issued through generic netlink interface, by

[RFC 1/4] fs: Add generic file system event notifications

2015-04-15 Thread Beata Michalska
Introduce configurable generic interface for file system-wide event notifications to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be issued through generic netlink interface, by a dedicated, for file system events, multicast