Re: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace

2016-06-30 Thread Byungchul Park
On Thu, Jun 30, 2016 at 06:38:47PM +0800, xinhui wrote: > +static int save_stack_end(void *data) > +{ > + struct stack_trace *trace = data; > + return trace->nr_entries >= trace->max_entries; > +} > + > static const struct stacktrace_ops save_stack_ops = { >

Re: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace

2016-06-30 Thread xinhui
-kernel@vger.kernel.org; npig...@suse.de; wal...@google.com; a...@suse.de; t...@inhelltoy.tec.linutronix.de Subject: Re: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace On 2016年06月20日 12:55, Byungchul Park wrote: Currently, x86 implementation of save_stack_trace() is walking all stack region

Re: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace

2016-06-29 Thread Byungchul Park
x-kernel@vger.kernel.org; npig...@suse.de; wal...@google.com; > > a...@suse.de; t...@inhelltoy.tec.linutronix.de > > Subject: Re: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace > > > > > > On 2016年06月20日 12:55, Byungchul Park wrote: > > > Currently, x86 i

RE: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace

2016-06-20 Thread byungchul.park
t; a...@suse.de; t...@inhelltoy.tec.linutronix.de > Subject: Re: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace > > > On 2016年06月20日 12:55, Byungchul Park wrote: > > Currently, x86 implementation of save_stack_trace() is walking all stack > > region word by word regardless of what th

Re: [RFC 12/12] x86/dumpstack: Optimize save_stack_trace

2016-06-20 Thread xinhui
On 2016年06月20日 12:55, Byungchul Park wrote: Currently, x86 implementation of save_stack_trace() is walking all stack region word by word regardless of what the trace->max_entries is. However, it's unnecessary to walk after already fulfilling caller's requirement, say, if trace->nr_entries >= tra

[RFC 12/12] x86/dumpstack: Optimize save_stack_trace

2016-06-19 Thread Byungchul Park
Currently, x86 implementation of save_stack_trace() is walking all stack region word by word regardless of what the trace->max_entries is. However, it's unnecessary to walk after already fulfilling caller's requirement, say, if trace->nr_entries >= trace->max_entries is true. For example, CONFIG_L