Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-10-02 Thread Linus Walleij
On Wed, Sep 2, 2015 at 1:19 AM, Vaibhav Hiremath wrote: > Not quite sure whether regulator would be right fit for this. > > Initially I was thinking of making use of pinconf framework, using > PIN_CONFIG_POWER_SOURCE, but that too I am not sure is the right way of > doing it. > > Probably,

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-10-02 Thread Linus Walleij
On Wed, Sep 2, 2015 at 1:19 AM, Vaibhav Hiremath wrote: > Not quite sure whether regulator would be right fit for this. > > Initially I was thinking of making use of pinconf framework, using > PIN_CONFIG_POWER_SOURCE, but that too I am not sure is the right way of >

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 06:11 PM, Vaibhav Hiremath wrote: On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote: On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API?

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote: On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Ulf Hansson
On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: > > > On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: >> >> [...] >> >> >> Could this be implemented by regulator API? From patch set 3/3, the >> pxa1928 >> voltage_switch hook is to operate the IO pad registers, this

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. Not quite sure whether regulator would be right

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Ulf Hansson
[...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. >>> >>> Not quite sure whether regulator would be right fit for this. >> >> >>

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Ulf Hansson
On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: > > > On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: >> >> [...] >> >> >> Could this be implemented by regulator API? From patch set 3/3, the >> pxa1928 >> voltage_switch hook is to

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote: On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 06:11 PM, Vaibhav Hiremath wrote: On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote: On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Ulf Hansson
[...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. >>> >>> Not quite sure whether regulator would be right fit for this. >> >> >>

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. Not quite sure whether regulator would be right

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 01:56 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Jisheng Zhang
On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: > > > On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: > > On Wed, 2 Sep 2015 01:02:17 +0530 > > Vaibhav Hiremath wrote: > > > >> Currently, the sdhci_do_start_signal_voltage_switch() function invokes > >> controller

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v usecase; but it is required for

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Jisheng Zhang
On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: > Currently, the sdhci_do_start_signal_voltage_switch() function invokes > controller specific voltage switch configuration only for 1.8v usecase; > but it is required for others as well. > > For example, in case of PXA1928 SDH

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Jisheng Zhang
On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: > > > On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: > > On Wed, 2 Sep 2015 01:02:17 +0530 > > Vaibhav Hiremath wrote: > > > >> Currently, the

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v usecase;

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Jisheng Zhang
On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: > Currently, the sdhci_do_start_signal_voltage_switch() function invokes > controller specific voltage switch configuration only for 1.8v usecase; > but it is required for others as well. > > For example, in

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 01:56 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath

[RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-01 Thread Vaibhav Hiremath
Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v usecase; but it is required for others as well. For example, in case of PXA1928 SDH controller, we need to set different configuration for 3.3, 1.8 and 1.2 volt

[RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-01 Thread Vaibhav Hiremath
Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v usecase; but it is required for others as well. For example, in case of PXA1928 SDH controller, we need to set different configuration for 3.3, 1.8 and 1.2 volt