Re: [RFC 3/3] sysrq: Warn about insufficient console_loglevel

2019-01-14 Thread Sergey Senozhatsky
On (01/14/19 15:59), Petr Mladek wrote: > Yes, it has false positives. On the other hand, I do not think > that a better message is worth even more complicated code. > > Either we find a better text, for example, use warning style: > > pr_warn("warning: messages are filtered by console

Re: [RFC 3/3] sysrq: Warn about insufficient console_loglevel

2019-01-14 Thread Petr Mladek
On Mon 2019-01-14 17:05:22, Sergey Senozhatsky wrote: > On (01/11/19 17:20), Petr Mladek wrote: > > +static void warn_console(bool console_suppressed, > > +int orig_log_level, > > +struct sysrq_key_op *op_p) > > +{ > > + static int warned; > > + > > + if

Re: [RFC 3/3] sysrq: Warn about insufficient console_loglevel

2019-01-14 Thread Sergey Senozhatsky
On (01/11/19 17:20), Petr Mladek wrote: > +static void warn_console(bool console_suppressed, > + int orig_log_level, > + struct sysrq_key_op *op_p) > +{ > + static int warned; > + > + if (warned) > + return; > + > + /* Do not warn

[RFC 3/3] sysrq: Warn about insufficient console_loglevel

2019-01-11 Thread Petr Mladek
People are sometimes confused that they do not see any output on the console when trying to get some debugging information using SysRq. The messages are filtered by the current console_loglevel. It makes some sense because a very long output might cause troubles with a slow console. Fortunately,