Re: [RFC 4/5] clk: per-user clock accounting for debug

2014-06-30 Thread Rabin Vincent
On Fri, Jun 27, 2014 at 04:44:24PM -0600, Stephen Warren wrote: > On 06/27/2014 01:57 AM, Tomeu Vizoso wrote: > > struct clk { > > - struct clk_core clk; > > + struct clk_core *core; > > + unsigned intenable_count; > > + const char *dev_id; > > + const char *con_id; > >

Re: [RFC 4/5] clk: per-user clock accounting for debug

2014-06-30 Thread Rabin Vincent
On Fri, Jun 27, 2014 at 04:44:24PM -0600, Stephen Warren wrote: On 06/27/2014 01:57 AM, Tomeu Vizoso wrote: struct clk { - struct clk_core clk; + struct clk_core *core; + unsigned intenable_count; + const char *dev_id; + const char *con_id; Why not just

Re: [RFC 4/5] clk: per-user clock accounting for debug

2014-06-27 Thread Stephen Warren
On 06/27/2014 04:44 PM, Stephen Warren wrote: > On 06/27/2014 01:57 AM, Tomeu Vizoso wrote: >> From: Rabin Vincent >> >> When a clock has multiple users, the WARNING on imbalance of >> enable/disable may not show the guilty party since although they may >> have commited the error earlier, the

Re: [RFC 4/5] clk: per-user clock accounting for debug

2014-06-27 Thread Stephen Warren
On 06/27/2014 01:57 AM, Tomeu Vizoso wrote: > From: Rabin Vincent > > When a clock has multiple users, the WARNING on imbalance of > enable/disable may not show the guilty party since although they may > have commited the error earlier, the warning is emitted later when some > other user,

[RFC 4/5] clk: per-user clock accounting for debug

2014-06-27 Thread Tomeu Vizoso
From: Rabin Vincent When a clock has multiple users, the WARNING on imbalance of enable/disable may not show the guilty party since although they may have commited the error earlier, the warning is emitted later when some other user, presumably innocent, disables the clock. Provide per-user

[RFC 4/5] clk: per-user clock accounting for debug

2014-06-27 Thread Tomeu Vizoso
From: Rabin Vincent rabin.vinc...@stericsson.com When a clock has multiple users, the WARNING on imbalance of enable/disable may not show the guilty party since although they may have commited the error earlier, the warning is emitted later when some other user, presumably innocent, disables the

Re: [RFC 4/5] clk: per-user clock accounting for debug

2014-06-27 Thread Stephen Warren
On 06/27/2014 01:57 AM, Tomeu Vizoso wrote: From: Rabin Vincent rabin.vinc...@stericsson.com When a clock has multiple users, the WARNING on imbalance of enable/disable may not show the guilty party since although they may have commited the error earlier, the warning is emitted later when

Re: [RFC 4/5] clk: per-user clock accounting for debug

2014-06-27 Thread Stephen Warren
On 06/27/2014 04:44 PM, Stephen Warren wrote: On 06/27/2014 01:57 AM, Tomeu Vizoso wrote: From: Rabin Vincent rabin.vinc...@stericsson.com When a clock has multiple users, the WARNING on imbalance of enable/disable may not show the guilty party since although they may have commited the error