Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-17 Thread Jan Beulich
>>> On 16.05.18 at 18:44, wrote: > Jan Beulich wrote: > On 15.05.18 at 16:11, wrote: >>> --- a/arch/x86/include/asm/refcount.h >>> +++ b/arch/x86/include/asm/refcount.h >>> @@ -14,34 +14,43 @@ >>> * central refcount exception. The

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-17 Thread Jan Beulich
>>> On 16.05.18 at 18:44, wrote: > Jan Beulich wrote: > On 15.05.18 at 16:11, wrote: >>> --- a/arch/x86/include/asm/refcount.h >>> +++ b/arch/x86/include/asm/refcount.h >>> @@ -14,34 +14,43 @@ >>> * central refcount exception. The fixup address for the exception points >>> * back to the

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Nadav Amit
Jan Beulich wrote: On 15.05.18 at 16:11, wrote: >> --- a/arch/x86/include/asm/refcount.h >> +++ b/arch/x86/include/asm/refcount.h >> @@ -14,34 +14,43 @@ >> * central refcount exception. The fixup address for the exception points >> * back to the

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Nadav Amit
Jan Beulich wrote: On 15.05.18 at 16:11, wrote: >> --- a/arch/x86/include/asm/refcount.h >> +++ b/arch/x86/include/asm/refcount.h >> @@ -14,34 +14,43 @@ >> * central refcount exception. The fixup address for the exception points >> * back to the regular execution flow in .text. >> */ >>

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Nadav Amit
Kees Cook wrote: > On Tue, May 15, 2018 at 7:11 AM, Nadav Amit wrote: >> GCC considers the number of statements in inlined assembly blocks, >> according to new-lines and semicolons, as an indication to the cost of >> the block in time and space. This

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Nadav Amit
Kees Cook wrote: > On Tue, May 15, 2018 at 7:11 AM, Nadav Amit wrote: >> GCC considers the number of statements in inlined assembly blocks, >> according to new-lines and semicolons, as an indication to the cost of >> the block in time and space. This data is distorted by the kernel code, >>

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Kees Cook
On Tue, May 15, 2018 at 7:11 AM, Nadav Amit wrote: > GCC considers the number of statements in inlined assembly blocks, > according to new-lines and semicolons, as an indication to the cost of > the block in time and space. This data is distorted by the kernel code, > which puts

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Kees Cook
On Tue, May 15, 2018 at 7:11 AM, Nadav Amit wrote: > GCC considers the number of statements in inlined assembly blocks, > according to new-lines and semicolons, as an indication to the cost of > the block in time and space. This data is distorted by the kernel code, > which puts information in

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Jan Beulich
>>> On 15.05.18 at 16:11, wrote: > --- a/arch/x86/include/asm/refcount.h > +++ b/arch/x86/include/asm/refcount.h > @@ -14,34 +14,43 @@ > * central refcount exception. The fixup address for the exception points > * back to the regular execution flow in .text. > */ >

Re: [RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-16 Thread Jan Beulich
>>> On 15.05.18 at 16:11, wrote: > --- a/arch/x86/include/asm/refcount.h > +++ b/arch/x86/include/asm/refcount.h > @@ -14,34 +14,43 @@ > * central refcount exception. The fixup address for the exception points > * back to the regular execution flow in .text. > */ > -#define

[RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-15 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform

[RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-15 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform

[RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-15 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform

[RFC 5/8] x86: refcount: prevent gcc distortions

2018-05-15 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform