On Thu, 2020-11-05 at 07:44 +0100, Miguel Ojeda wrote:
> There are a few important new features:
https://clang.llvm.org/docs/ClangFormatStyleOptions.html
> - AlignConsecutiveMacros is probably one of the biggest one for the
> kernel that we were missing so far.
There's no control as to effecti
On Thu, Nov 5, 2020 at 1:35 AM Nick Desaulniers wrote:
>
> I'll help you paint your bikeshed. Oh, but what color? I see a red
> door, and I want it painted black.
>
> Sounds to me like Miguel could win over a critic by addressing some of
> your (quite valid) concerns. ;)
I am happy to take the p
On Thu, Nov 5, 2020 at 1:33 AM Nick Desaulniers wrote:
>
> Yeah, that's annoying. Why don't you send me a patch that downgrades
> it from hard error to polite warning (in case someone made a typo),
> and I'll review it?
Sure!
Cheers,
Miguel
On Tue, Nov 3, 2020 at 5:31 PM Joe Perches wrote:
>
> On Tue, 2020-11-03 at 17:08 -0800, Nick Desaulniers wrote:
> > On Tue, Nov 3, 2020 at 1:33 PM Miguel Ojeda
> > wrote:
> > > On Tue, Nov 3, 2020 at 7:29 PM Joe Perches wrote:
> > > >
> > > > Now that the clang minimum supported version is > 10
On Tue, Nov 3, 2020 at 7:40 PM Miguel Ojeda
wrote:
>
> distro etc.). One of the reasons for that was to help adoption, as
> well as because clang-format gives a hard error on encountering an
> unknown option :-(
Yeah, that's annoying. Why don't you send me a patch that downgrades
it from hard err
Hi Joe,
First of all, thanks for taking the time to write your reasoning.
On Wed, Nov 4, 2020 at 5:17 AM Joe Perches wrote:
>
> The current kernel is v5.10 which requires clang 10.0 or higher.
For building, yes.
> This patch is not to be applied or backported to old kernels so no
> person is g
On Wed, 2020-11-04 at 04:57 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 4:15 AM Joe Perches wrote:
> >
> > No one ever will use clang-format on the current kernel sources
> > without having a recent version of clang and clang-format.
>
> Why? Many distros come with clang-format pre-packa
On Wed, Nov 4, 2020 at 4:15 AM Joe Perches wrote:
>
> No one ever will use clang-format on the current kernel sources
> without having a recent version of clang and clang-format.
Why? Many distros come with clang-format pre-packaged, and in fact the
original patch (that you commented on) argued f
On Wed, Nov 4, 2020 at 2:08 AM Nick Desaulniers wrote:
>
> Miguel,
> Really? :P I'd bet if you picked up this patch no one would notice.
>
> I recommend a simpler approach to multiple version support, which is
> just matching the one version recommended for the rest of LLVM tools.
> Sure, technica
On Wed, 2020-11-04 at 04:10 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 1:56 AM Joe Perches wrote:
> >
> > Do remember that this patch is for the current kernel and
> > not any old version that someone might be compiling.
> >
> > The current kernel _requires_ clang 10.0+ and that would
>
On Wed, Nov 4, 2020 at 1:56 AM Joe Perches wrote:
>
> Do remember that this patch is for the current kernel and
> not any old version that someone might be compiling.
>
> The current kernel _requires_ clang 10.0+ and that would
> obviously provide clang-format 10+ as well.
You can use clang-forma
On Tue, 2020-11-03 at 17:08 -0800, Nick Desaulniers wrote:
> On Tue, Nov 3, 2020 at 1:33 PM Miguel Ojeda
> wrote:
> > On Tue, Nov 3, 2020 at 7:29 PM Joe Perches wrote:
> > >
> > > Now that the clang minimum supported version is > 10.0, enable the
> > > commented out conditional reformatting key
On Tue, Nov 3, 2020 at 10:29 AM Joe Perches wrote:
>
> Now that the clang minimum supported version is > 10.0, enable the
> commented out conditional reformatting key:value lines in the file.
>
> Signed-off-by: Joe Perches
> ---
>
> Hey Miguel.
>
> I don't use this, but on its face it seems a rea
On Tue, Nov 3, 2020 at 1:33 PM Miguel Ojeda
wrote:
>
> Hi Joe,
>
> On Tue, Nov 3, 2020 at 7:29 PM Joe Perches wrote:
> >
> > Now that the clang minimum supported version is > 10.0, enable the
> > commented out conditional reformatting key:value lines in the file.
> >
> > Signed-off-by: Joe Perche
On Tue, 2020-11-03 at 22:33 +0100, Miguel Ojeda wrote:
> It is, yeah; however, the concern is that there may be developers
> running an old clang-format from their distro (i.e. not using it for
> compiling the kernel).
I expect that'd be extremely unusual.
> We need to compare the functionality a
Hi Joe,
On Tue, Nov 3, 2020 at 7:29 PM Joe Perches wrote:
>
> Now that the clang minimum supported version is > 10.0, enable the
> commented out conditional reformatting key:value lines in the file.
>
> Signed-off-by: Joe Perches
> ---
>
> Hey Miguel.
>
> I don't use this, but on its face it see
Now that the clang minimum supported version is > 10.0, enable the
commented out conditional reformatting key:value lines in the file.
Signed-off-by: Joe Perches
---
Hey Miguel.
I don't use this, but on its face it seems a reasonable change
if the commented out key:value lines are correct.
.c
17 matches
Mail list logo
