Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread One Thousand Gnomes
On Mon, 15 Feb 2016 17:45:40 + Mark Brown wrote: > On Mon, Feb 15, 2016 at 04:27:51PM +0800, Hanjun Guo wrote: > > On 2016/2/5 19:09, Mark Brown wrote: > > > > Intel are heavy users of this driver on their systems which also use > > > ACPI. Have you discussed this

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread One Thousand Gnomes
On Mon, 15 Feb 2016 17:45:40 + Mark Brown wrote: > On Mon, Feb 15, 2016 at 04:27:51PM +0800, Hanjun Guo wrote: > > On 2016/2/5 19:09, Mark Brown wrote: > > > > Intel are heavy users of this driver on their systems which also use > > > ACPI. Have you discussed this binding with them?

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread Mark Brown
On Mon, Feb 15, 2016 at 04:27:51PM +0800, Hanjun Guo wrote: > On 2016/2/5 19:09, Mark Brown wrote: > > Intel are heavy users of this driver on their systems which also use > > ACPI. Have you discussed this binding with them? I've copied Andy and > > Jarkko who've worked on the driver recently.

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread Mark Brown
On Mon, Feb 15, 2016 at 04:27:51PM +0800, Hanjun Guo wrote: > On 2016/2/5 19:09, Mark Brown wrote: > > Intel are heavy users of this driver on their systems which also use > > ACPI. Have you discussed this binding with them? I've copied Andy and > > Jarkko who've worked on the driver recently.

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread Mark Brown
On Sun, Feb 14, 2016 at 05:31:14PM +0800, Jiang Qiu wrote: > 在 2016/2/5 19:09, Mark Brown 写道: > >On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread Mark Brown
On Sun, Feb 14, 2016 at 05:31:14PM +0800, Jiang Qiu wrote: > 在 2016/2/5 19:09, Mark Brown 写道: > >On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread Hanjun Guo
On 2016/2/5 19:09, Mark Brown wrote: > On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: > >> This patch added ACPI support for DesignWare SPI mmio driver. It >> was based the corresponding DT driver and compatible for this two >> way. This patch has been tested on Hisilicon D02 board. It

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-15 Thread Hanjun Guo
On 2016/2/5 19:09, Mark Brown wrote: > On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: > >> This patch added ACPI support for DesignWare SPI mmio driver. It >> was based the corresponding DT driver and compatible for this two >> way. This patch has been tested on Hisilicon D02 board. It

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-14 Thread Jiang Qiu
Hi Andy, Sorry for late relpy because Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 23:55, Andy Shevchenko 写道: On Fri, Feb 5, 2016 at 9:11 AM, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio driver. It was based the corresponding DT

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-14 Thread Jiang Qiu
Hi Mark, Many thanks for your review, I'm so sorry for late reply because The Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 19:09, Mark Brown 写道: On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-14 Thread Jiang Qiu
Hi Mark, Many thanks for your review, I'm so sorry for late reply because The Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 19:09, Mark Brown 写道: On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-14 Thread Jiang Qiu
Hi Andy, Sorry for late relpy because Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 23:55, Andy Shevchenko 写道: On Fri, Feb 5, 2016 at 9:11 AM, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio driver. It was based the

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-05 Thread Mark Brown
On Fri, Feb 05, 2016 at 05:55:42PM +0200, Andy Shevchenko wrote: > Like Mark noticed there is also same issue. Do you indeed check the > configuration with different chip select signals? It's not clear to me that *any* chip select signals work, we get a GPIO descriptor back but I didn't see any

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-05 Thread Andy Shevchenko
On Fri, Feb 5, 2016 at 9:11 AM, qiujiang wrote: > This patch added ACPI support for DesignWare SPI mmio driver. It > was based the corresponding DT driver and compatible for this two > way. This patch has been tested on Hisilicon D02 board. It relies > on the GPIO patchset. My comments below. >

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-05 Thread Mark Brown
On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: > This patch added ACPI support for DesignWare SPI mmio driver. It > was based the corresponding DT driver and compatible for this two > way. This patch has been tested on Hisilicon D02 board. It relies > on the GPIO patchset. Intel are

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-05 Thread Mark Brown
On Fri, Feb 05, 2016 at 05:55:42PM +0200, Andy Shevchenko wrote: > Like Mark noticed there is also same issue. Do you indeed check the > configuration with different chip select signals? It's not clear to me that *any* chip select signals work, we get a GPIO descriptor back but I didn't see any

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-05 Thread Andy Shevchenko
On Fri, Feb 5, 2016 at 9:11 AM, qiujiang wrote: > This patch added ACPI support for DesignWare SPI mmio driver. It > was based the corresponding DT driver and compatible for this two > way. This patch has been tested on Hisilicon D02 board. It relies > on the GPIO patchset.

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-05 Thread Mark Brown
On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: > This patch added ACPI support for DesignWare SPI mmio driver. It > was based the corresponding DT driver and compatible for this two > way. This patch has been tested on Hisilicon D02 board. It relies > on the GPIO patchset. Intel are

[RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-04 Thread qiujiang
This patch added ACPI support for DesignWare SPI mmio driver. It was based the corresponding DT driver and compatible for this two way. This patch has been tested on Hisilicon D02 board. It relies on the GPIO patchset. Signed-off-by: qiujiang --- drivers/spi/spi-dw-mmio.c | 26

[RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

2016-02-04 Thread qiujiang
This patch added ACPI support for DesignWare SPI mmio driver. It was based the corresponding DT driver and compatible for this two way. This patch has been tested on Hisilicon D02 board. It relies on the GPIO patchset. Signed-off-by: qiujiang --- drivers/spi/spi-dw-mmio.c |