Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-03-02 Thread Michal Simek
On 2.3.2016 12:42, Arnd Bergmann wrote: > On Wednesday 02 March 2016 10:27:51 Michal Simek wrote: >> >> No problem with default value in driver. Something has to be setup. >> Reset value based on reg spec I was checking is 0x20. Based on our >> testing we saw some issues that's why 0x40 was setup a

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2016 10:27:51 Michal Simek wrote: > > No problem with default value in driver. Something has to be setup. > Reset value based on reg spec I was checking is 0x20. Based on our > testing we saw some issues that's why 0x40 was setup as default value. > There is a need to be able

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-03-02 Thread Michal Simek
On 2.3.2016 10:11, Arnd Bergmann wrote: > On Wednesday 02 March 2016 09:05:49 Michal Simek wrote: >> On 2.3.2016 06:53, Anurag Kumar Vulisha wrote: >>> >>> I would probably make this dependent on the compatible string >>> instead, and have a table in the device driver that uses a >>

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2016 09:05:49 Michal Simek wrote: > On 2.3.2016 06:53, Anurag Kumar Vulisha wrote: > > > > I would probably make this dependent on the compatible string > > instead, and have a table in the device driver that uses a > > specific value for each variant of the de

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-03-02 Thread Michal Simek
@arm.com; mark.rutl...@arm.com; >> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; t...@kernel.org; >> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> i...@vger.kernel.org; Anirudha Sarangi; Srikanth Vemula; Punnaiah Choudary >> Kalluri >> Subject: RE: [RFC PAT

RE: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-03-01 Thread Anurag Kumar Vulisha
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > i...@vger.kernel.org; Anirudha Sarangi; Srikanth Vemula; Punnaiah Choudary > Kalluri > Subject: RE: [RFC PATCH] drivers: ata: Read Rx water mark value from device- > tree > > Hi Rob, > > > -Original

RE: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-26 Thread Anurag Kumar Vulisha
g; t...@kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > i...@vger.kernel.org; Anirudha Sarangi; Srikanth Vemula; Punnaiah Choudary > Kalluri > Subject: Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device- > tree > > On Tue, Feb 23, 2016 at

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-23 Thread Rob Herring
l.org; pawel.m...@arm.com; mark.rutl...@arm.com; > > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; t...@kernel.org; > > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > i...@vger.kernel.org; Anirudha Sarangi; Srikanth Vemula; Punnaiah Choudary > > Kall

RE: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-23 Thread Anurag Kumar Vulisha
g; t...@kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > i...@vger.kernel.org; Anirudha Sarangi; Srikanth Vemula; Punnaiah Choudary > Kalluri > Subject: Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device- > tree > > On Tuesday 23 Febr

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-23 Thread Arnd Bergmann
On Tuesday 23 February 2016 05:58:32 Anurag Kumar Vulisha wrote: > > > > I don't know what is appropriate because I have no idea what Rxwatermark is > > good for. Can you try describing why we can't just set it to the correct > > value > > for everyone automatically? > > > > This RX watermark lev

RE: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-22 Thread Anurag Kumar Vulisha
g; t...@kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > i...@vger.kernel.org; Anirudha Sarangi; Srikanth Vemula; Punnaiah Choudary > Kalluri > Subject: Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device- > tree > > On Monday 22 Febr

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-22 Thread Arnd Bergmann
On Monday 22 February 2016 10:53:11 Anurag Kumar Vulisha wrote: > > > > > > > How would a hardware integrator know which value is right for a particular > > SoC? > > > > Could it be keyed off the hardware ID? Could the bootloader perhaps set an > > appropriate value in the AHCI_VEND_PTC register

RE: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-22 Thread Anurag Kumar Vulisha
g; t...@kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > i...@vger.kernel.org; Anirudha Sarangi; Srikanth Vemula; Punnaiah Choudary > Kalluri; Anurag Kumar Vulisha > Subject: Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device- > tree > >

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-20 Thread Arnd Bergmann
On Saturday 20 February 2016 18:48:22 Anurag Kumar Vulisha wrote: > index 7ca8b97..7e48dfc 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt > @@ -8,6 +8,7 @@ Required properties: > > Optional properties: >- ceva,br

[RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

2016-02-20 Thread Anurag Kumar Vulisha
This patch updates the driver to read the RX FIFO watermark value from device tree. This read value is used by the driver for programming FIFO RxWaterMark level, which sets the minimum number of free locations within the RX FIFO.When the rx fifo level crosses the programmed watermark level, sata co