Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-19 Thread Michal Hocko
On Mon 19-11-18 14:05:34, David Rientjes wrote: > On Thu, 15 Nov 2018, Michal Hocko wrote: > > > > The userspace had a single way to determine if thp had been disabled for > > > a > > > specific vma and that was broken with your commit. We have since fixed > > > it. Modifying our software

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-19 Thread Michal Hocko
On Mon 19-11-18 14:05:34, David Rientjes wrote: > On Thu, 15 Nov 2018, Michal Hocko wrote: > > > > The userspace had a single way to determine if thp had been disabled for > > > a > > > specific vma and that was broken with your commit. We have since fixed > > > it. Modifying our software

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-19 Thread David Rientjes
On Thu, 15 Nov 2018, Michal Hocko wrote: > > The userspace had a single way to determine if thp had been disabled for a > > specific vma and that was broken with your commit. We have since fixed > > it. Modifying our software stack to start looking for some field > > somewhere else will not

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-19 Thread David Rientjes
On Thu, 15 Nov 2018, Michal Hocko wrote: > > The userspace had a single way to determine if thp had been disabled for a > > specific vma and that was broken with your commit. We have since fixed > > it. Modifying our software stack to start looking for some field > > somewhere else will not

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-15 Thread Michal Hocko
On Thu 15-11-18 10:02:42, Michal Hocko wrote: > On Wed 14-11-18 13:41:12, David Rientjes wrote: > > On Wed, 14 Nov 2018, Michal Hocko wrote: > > > > > > > > Do you know of any other userspace except your usecase? Is there > > > > > > anything fundamental that would prevent a proper API adoption

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-15 Thread Michal Hocko
On Thu 15-11-18 10:02:42, Michal Hocko wrote: > On Wed 14-11-18 13:41:12, David Rientjes wrote: > > On Wed, 14 Nov 2018, Michal Hocko wrote: > > > > > > > > Do you know of any other userspace except your usecase? Is there > > > > > > anything fundamental that would prevent a proper API adoption

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-15 Thread Michal Hocko
On Wed 14-11-18 13:41:12, David Rientjes wrote: > On Wed, 14 Nov 2018, Michal Hocko wrote: > > > > > > Do you know of any other userspace except your usecase? Is there > > > > > anything fundamental that would prevent a proper API adoption for you? > > > > > > > > > > > > > Yes, it would

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-15 Thread Michal Hocko
On Wed 14-11-18 13:41:12, David Rientjes wrote: > On Wed, 14 Nov 2018, Michal Hocko wrote: > > > > > > Do you know of any other userspace except your usecase? Is there > > > > > anything fundamental that would prevent a proper API adoption for you? > > > > > > > > > > > > > Yes, it would

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-14 Thread David Rientjes
On Wed, 14 Nov 2018, Michal Hocko wrote: > > > > Do you know of any other userspace except your usecase? Is there > > > > anything fundamental that would prevent a proper API adoption for you? > > > > > > > > > > Yes, it would require us to go back in time and build patched binaries. > > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-14 Thread David Rientjes
On Wed, 14 Nov 2018, Michal Hocko wrote: > > > > Do you know of any other userspace except your usecase? Is there > > > > anything fundamental that would prevent a proper API adoption for you? > > > > > > > > > > Yes, it would require us to go back in time and build patched binaries. > > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-14 Thread Michal Hocko
On Thu 18-10-18 09:00:31, Michal Hocko wrote: > On Wed 17-10-18 12:59:18, David Rientjes wrote: > > On Wed, 17 Oct 2018, Michal Hocko wrote: > > > > > Do you know of any other userspace except your usecase? Is there > > > anything fundamental that would prevent a proper API adoption for you? > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-11-14 Thread Michal Hocko
On Thu 18-10-18 09:00:31, Michal Hocko wrote: > On Wed 17-10-18 12:59:18, David Rientjes wrote: > > On Wed, 17 Oct 2018, Michal Hocko wrote: > > > > > Do you know of any other userspace except your usecase? Is there > > > anything fundamental that would prevent a proper API adoption for you? > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-18 Thread Michal Hocko
On Wed 17-10-18 12:59:18, David Rientjes wrote: > On Wed, 17 Oct 2018, Michal Hocko wrote: > > > Do you know of any other userspace except your usecase? Is there > > anything fundamental that would prevent a proper API adoption for you? > > > > Yes, it would require us to go back in time and

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-18 Thread Michal Hocko
On Wed 17-10-18 12:59:18, David Rientjes wrote: > On Wed, 17 Oct 2018, Michal Hocko wrote: > > > Do you know of any other userspace except your usecase? Is there > > anything fundamental that would prevent a proper API adoption for you? > > > > Yes, it would require us to go back in time and

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-17 Thread David Rientjes
On Wed, 17 Oct 2018, Michal Hocko wrote: > Do you know of any other userspace except your usecase? Is there > anything fundamental that would prevent a proper API adoption for you? > Yes, it would require us to go back in time and build patched binaries.

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-17 Thread David Rientjes
On Wed, 17 Oct 2018, Michal Hocko wrote: > Do you know of any other userspace except your usecase? Is there > anything fundamental that would prevent a proper API adoption for you? > Yes, it would require us to go back in time and build patched binaries.

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-17 Thread Michal Hocko
On Tue 16-10-18 14:24:19, David Rientjes wrote: > On Tue, 16 Oct 2018, Michal Hocko wrote: > > > > I don't understand the point of extending smaps with yet another line. > > > > Because abusing a vma flag part is just wrong. What are you going to do > > when a next bug report states that the

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-17 Thread Michal Hocko
On Tue 16-10-18 14:24:19, David Rientjes wrote: > On Tue, 16 Oct 2018, Michal Hocko wrote: > > > > I don't understand the point of extending smaps with yet another line. > > > > Because abusing a vma flag part is just wrong. What are you going to do > > when a next bug report states that the

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-16 Thread David Rientjes
On Tue, 16 Oct 2018, Michal Hocko wrote: > > I don't understand the point of extending smaps with yet another line. > > Because abusing a vma flag part is just wrong. What are you going to do > when a next bug report states that the flag is set even though no > userspace has set it and that

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-16 Thread David Rientjes
On Tue, 16 Oct 2018, Michal Hocko wrote: > > I don't understand the point of extending smaps with yet another line. > > Because abusing a vma flag part is just wrong. What are you going to do > when a next bug report states that the flag is set even though no > userspace has set it and that

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-16 Thread Michal Hocko
On Mon 15-10-18 15:25:14, David Rientjes wrote: > On Mon, 15 Oct 2018, Michal Hocko wrote: > > > > > No, because the offending commit actually changed the precedence > > > > itself: > > > > PR_SET_THP_DISABLE used to be honored for future mappings and the > > > > commit > > > > changed that

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-16 Thread Michal Hocko
On Mon 15-10-18 15:25:14, David Rientjes wrote: > On Mon, 15 Oct 2018, Michal Hocko wrote: > > > > > No, because the offending commit actually changed the precedence > > > > itself: > > > > PR_SET_THP_DISABLE used to be honored for future mappings and the > > > > commit > > > > changed that

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-15 Thread David Rientjes
On Mon, 15 Oct 2018, Michal Hocko wrote: > > > No, because the offending commit actually changed the precedence itself: > > > PR_SET_THP_DISABLE used to be honored for future mappings and the commit > > > changed that for all current mappings. > > > > Which is the actual and the full point of

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-15 Thread David Rientjes
On Mon, 15 Oct 2018, Michal Hocko wrote: > > > No, because the offending commit actually changed the precedence itself: > > > PR_SET_THP_DISABLE used to be honored for future mappings and the commit > > > changed that for all current mappings. > > > > Which is the actual and the full point of

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-15 Thread Michal Hocko
On Tue 09-10-18 10:33:26, Michal Hocko wrote: > On Thu 04-10-18 11:34:11, David Rientjes wrote: > > On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > > > And prior to the offending commit, there were three ways to control thp > > > > but two ways to determine if a mapping was eligible for thp

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-15 Thread Michal Hocko
On Tue 09-10-18 10:33:26, Michal Hocko wrote: > On Thu 04-10-18 11:34:11, David Rientjes wrote: > > On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > > > And prior to the offending commit, there were three ways to control thp > > > > but two ways to determine if a mapping was eligible for thp

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-09 Thread Michal Hocko
On Thu 04-10-18 11:34:11, David Rientjes wrote: > On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > And prior to the offending commit, there were three ways to control thp > > > but two ways to determine if a mapping was eligible for thp based on the > > > implementation detail of one of those

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-09 Thread Michal Hocko
On Thu 04-10-18 11:34:11, David Rientjes wrote: > On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > And prior to the offending commit, there were three ways to control thp > > > but two ways to determine if a mapping was eligible for thp based on the > > > implementation detail of one of those

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-04 Thread David Rientjes
On Thu, 4 Oct 2018, Michal Hocko wrote: > > And prior to the offending commit, there were three ways to control thp > > but two ways to determine if a mapping was eligible for thp based on the > > implementation detail of one of those ways. > > Yes, it is really unfortunate that we have ever

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-04 Thread David Rientjes
On Thu, 4 Oct 2018, Michal Hocko wrote: > > And prior to the offending commit, there were three ways to control thp > > but two ways to determine if a mapping was eligible for thp based on the > > implementation detail of one of those ways. > > Yes, it is really unfortunate that we have ever

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-04 Thread Michal Hocko
On Thu 04-10-18 02:15:38, David Rientjes wrote: > On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > > > > So how about this? (not tested yet but it should be pretty > > > > > > straightforward) > > > > > > > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > > > > > > > /me confused. I thought you want to

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-04 Thread Michal Hocko
On Thu 04-10-18 02:15:38, David Rientjes wrote: > On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > > > > So how about this? (not tested yet but it should be pretty > > > > > > straightforward) > > > > > > > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > > > > > > > /me confused. I thought you want to

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-04 Thread David Rientjes
On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > > So how about this? (not tested yet but it should be pretty > > > > > straightforward) > > > > > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > > > > > /me confused. I thought you want to query for the flag on a > > > _different_ process. > > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-04 Thread David Rientjes
On Thu, 4 Oct 2018, Michal Hocko wrote: > > > > > So how about this? (not tested yet but it should be pretty > > > > > straightforward) > > > > > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > > > > > /me confused. I thought you want to query for the flag on a > > > _different_ process. > > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 15:51:05, David Rientjes wrote: > On Wed, 3 Oct 2018, Michal Hocko wrote: > > > > > So how about this? (not tested yet but it should be pretty > > > > straightforward) > > > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > > > /me confused. I thought you want to query for the flag on a

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 15:51:05, David Rientjes wrote: > On Wed, 3 Oct 2018, Michal Hocko wrote: > > > > > So how about this? (not tested yet but it should be pretty > > > > straightforward) > > > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > > > /me confused. I thought you want to query for the flag on a

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread David Rientjes
On Wed, 3 Oct 2018, Michal Hocko wrote: > > > So how about this? (not tested yet but it should be pretty > > > straightforward) > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > /me confused. I thought you want to query for the flag on a > _different_ process. Why would we want to check three

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread David Rientjes
On Wed, 3 Oct 2018, Michal Hocko wrote: > > > So how about this? (not tested yet but it should be pretty > > > straightforward) > > > > Umm, prctl(PR_GET_THP_DISABLE)? > > /me confused. I thought you want to query for the flag on a > _different_ process. Why would we want to check three

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread Mike Rapoport
On Tue, Oct 02, 2018 at 01:29:42PM -0700, David Rientjes wrote: > On Tue, 2 Oct 2018, Michal Hocko wrote: > > > On Wed 26-09-18 08:06:24, Michal Hocko wrote: > > > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > > > wrote: > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread Mike Rapoport
On Tue, Oct 02, 2018 at 01:29:42PM -0700, David Rientjes wrote: > On Tue, 2 Oct 2018, Michal Hocko wrote: > > > On Wed 26-09-18 08:06:24, Michal Hocko wrote: > > > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > > > wrote: > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread Michal Hocko
On Tue 02-10-18 13:29:42, David Rientjes wrote: > On Tue, 2 Oct 2018, Michal Hocko wrote: > > > On Wed 26-09-18 08:06:24, Michal Hocko wrote: > > > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > > > wrote: > > > > > > > > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-03 Thread Michal Hocko
On Tue 02-10-18 13:29:42, David Rientjes wrote: > On Tue, 2 Oct 2018, Michal Hocko wrote: > > > On Wed 26-09-18 08:06:24, Michal Hocko wrote: > > > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > > > wrote: > > > > > > > > > >

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-02 Thread David Rientjes
On Tue, 2 Oct 2018, Michal Hocko wrote: > On Wed 26-09-18 08:06:24, Michal Hocko wrote: > > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > > wrote: > > > > > > > > > It is also used in > > > > > > automated testing to ensure

Re: [RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-02 Thread David Rientjes
On Tue, 2 Oct 2018, Michal Hocko wrote: > On Wed 26-09-18 08:06:24, Michal Hocko wrote: > > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > > wrote: > > > > > > > > > It is also used in > > > > > > automated testing to ensure

[RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-02 Thread Michal Hocko
On Wed 26-09-18 08:06:24, Michal Hocko wrote: > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > wrote: > > > > > > > It is also used in > > > > > automated testing to ensure that vmas get disabled for thp > > > > > appropriately

[RFC PATCH] mm, proc: report PR_SET_THP_DISABLE in proc

2018-10-02 Thread Michal Hocko
On Wed 26-09-18 08:06:24, Michal Hocko wrote: > On Tue 25-09-18 15:04:06, Andrew Morton wrote: > > On Tue, 25 Sep 2018 14:45:19 -0700 (PDT) David Rientjes > > wrote: > > > > > > > It is also used in > > > > > automated testing to ensure that vmas get disabled for thp > > > > > appropriately