Re: [RFC PATCH] mmc: dw_mmc: remove redundant num_slots check

2016-01-21 Thread Jaehoon Chung
On 01/22/2016 12:07 PM, Shawn Lin wrote: > On 2016/1/22 10:46, Jaehoon Chung wrote: >> Hi, Shawn. >> >> On 01/21/2016 04:52 PM, Shawn Lin wrote: >>> num_slots comes from pdata if existing, otherwise from >>> dw_mci_parse_dt which make it at least one slot. If >>> num_slots is less than 1 for the ex

Re: [RFC PATCH] mmc: dw_mmc: remove redundant num_slots check

2016-01-21 Thread Shawn Lin
On 2016/1/22 10:46, Jaehoon Chung wrote: Hi, Shawn. On 01/21/2016 04:52 PM, Shawn Lin wrote: num_slots comes from pdata if existing, otherwise from dw_mci_parse_dt which make it at least one slot. If num_slots is less than 1 for the existing pdata case, current code return -ENODEV. But dw_mci_p

Re: [RFC PATCH] mmc: dw_mmc: remove redundant num_slots check

2016-01-21 Thread Jaehoon Chung
Hi, Shawn. On 01/21/2016 04:52 PM, Shawn Lin wrote: > num_slots comes from pdata if existing, otherwise from > dw_mci_parse_dt which make it at least one slot. If > num_slots is less than 1 for the existing pdata case, > current code return -ENODEV. But dw_mci_probe seems to > treat this a optiona

[RFC PATCH] mmc: dw_mmc: remove redundant num_slots check

2016-01-20 Thread Shawn Lin
num_slots comes from pdata if existing, otherwise from dw_mci_parse_dt which make it at least one slot. If num_slots is less than 1 for the existing pdata case, current code return -ENODEV. But dw_mci_probe seems to treat this a optional case as it will call SDMMC_GET_SLOT_NUM if no slot assigned.