Re: [RFC PATCH] nvme: allow NVME_IOCTL_IO_CMD on controller char dev even when multiple ns

2021-04-02 Thread Christoph Hellwig
Well, there is at least one good reason for not allowing this retroactively: Old users of the ioctl could have complete garbage in the field, and might send the command to a random namespace now instead of the first one. So unles we have a very good reason I think we should keep

Re: [RFC PATCH] nvme: allow NVME_IOCTL_IO_CMD on controller char dev even when multiple ns

2021-03-31 Thread Niklas Cassel
On Tue, Mar 30, 2021 at 08:30:22PM +0200, jav...@javigon.com wrote: > On 26.03.2021 20:59, Niklas Cassel wrote: > > From: Niklas Cassel > > > > Currently when doing NVME_IOCTL_IO_CMD on the controller character device, > > the command is rejected if there is more than one namespace in the > >

Re: [RFC PATCH] nvme: allow NVME_IOCTL_IO_CMD on controller char dev even when multiple ns

2021-03-30 Thread jav...@javigon.com
On 26.03.2021 20:59, Niklas Cassel wrote: From: Niklas Cassel Currently when doing NVME_IOCTL_IO_CMD on the controller character device, the command is rejected if there is more than one namespace in the ctrl->namespaces list. There is not really any reason for this restriction. Instead,

[RFC PATCH] nvme: allow NVME_IOCTL_IO_CMD on controller char dev even when multiple ns

2021-03-26 Thread Niklas Cassel
From: Niklas Cassel Currently when doing NVME_IOCTL_IO_CMD on the controller character device, the command is rejected if there is more than one namespace in the ctrl->namespaces list. There is not really any reason for this restriction. Instead, check the nsid value specified in the passthru