Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-14 Thread Petr Mladek
On Thu 2020-08-13 20:31:55, Sergey Senozhatsky wrote: > On (20/08/13 12:22), Petr Mladek wrote: > > > > + would take more space (prefix + text vs. binary representation) > > Dict buffer is allocated regardless of how we use it, and only printks > from drivers/* (dev_printk*) add dict payload.

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-14 Thread Dave Young
On 08/11/20 at 12:40pm, Orson Zhai wrote: > From: Thomas Gleixner > > Timestamps printed in kernel log are retrieved by local_clock which reads > jiffies as a referrence clock source. > But it is diffcult to be synchronized with logs generated out of kernel, > say some remote processors (Modem)

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-13 Thread Sergey Senozhatsky
On (20/08/13 12:22), Petr Mladek wrote: > > + would take more space (prefix + text vs. binary representation) Dict buffer is allocated regardless of how we use it, and only printks from drivers/* (dev_printk*) add dict payload. It might be the case that on some (if not most) systems dict pages

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-13 Thread Thomas Gleixner
Sergey Senozhatsky writes: > On (20/08/11 15:02), Petr Mladek wrote: >> There is still the alternative to print all three timestamps regularly >> for those interested. It is less user convenient but much easier >> to maintain. > > Yes, that's a nice alternative. It's trivial on the kernel side,

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-13 Thread Petr Mladek
On Thu 2020-08-13 10:55:00, Sergey Senozhatsky wrote: > On (20/08/11 15:02), Petr Mladek wrote: > > On Tue 2020-08-11 14:05:12, Thomas Gleixner wrote: > > > Petr Mladek writes: > > > > At least "crash" tool would need an update anyway. AFAIK, it checks > > > > the size of struct printk_log and

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-12 Thread Sergey Senozhatsky
On (20/08/11 15:02), Petr Mladek wrote: > On Tue 2020-08-11 14:05:12, Thomas Gleixner wrote: > > Petr Mladek writes: > > > At least "crash" tool would need an update anyway. AFAIK, it checks > > > the size of struct printk_log and refuses to read it when it changes. > > > > > > It means that the

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-11 Thread Prarit Bhargava
On 8/11/20 9:02 AM, Petr Mladek wrote: > On Tue 2020-08-11 14:05:12, Thomas Gleixner wrote: >> Petr Mladek writes: >>> At least "crash" tool would need an update anyway. AFAIK, it checks >>> the size of struct printk_log and refuses to read it when it changes. >>> >>> It means that the hack

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-11 Thread Petr Mladek
On Tue 2020-08-11 14:05:12, Thomas Gleixner wrote: > Petr Mladek writes: > > At least "crash" tool would need an update anyway. AFAIK, it checks > > the size of struct printk_log and refuses to read it when it changes. > > > > It means that the hack with VMCOREINFO_FIELD_OFFSET probably is not >

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-11 Thread Thomas Gleixner
Petr Mladek writes: > On Tue 2020-08-11 12:40:22, Orson Zhai wrote: >> This is an updated version which comes from patch [1] written by Thomas >> and suggestion [2] about VMCORE_INFO given by Linus. All of that want's to be properly distangled into seperate patches. >> This patch has been

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-11 Thread Petr Mladek
On Tue 2020-08-11 12:40:22, Orson Zhai wrote: > From: Thomas Gleixner > > Timestamps printed in kernel log are retrieved by local_clock which reads > jiffies as a referrence clock source. > But it is diffcult to be synchronized with logs generated out of kernel, > say some remote processors

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-10 Thread Randy Dunlap
On 8/10/20 9:40 PM, Orson Zhai wrote: > +/* > + * struct timestanps - Simultaneous mono/boot/real timestamps typo:timestamps > + * @mono:Monotonic timestamp > + * @boot:Boottime timestamp > + * @real:Realtime timestamp > + */ > +struct timestamps { > + u64

[RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-10 Thread Orson Zhai
From: Thomas Gleixner Timestamps printed in kernel log are retrieved by local_clock which reads jiffies as a referrence clock source. But it is diffcult to be synchronized with logs generated out of kernel, say some remote processors (Modem) in the Soc of mobile phones. Jiffies will be