Re: [RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-10 Thread Nicolas Ferre
On 09/01/2014 08:08, Mark Roszko : > Just to sumarize the bug after poking before the patch: >systemd calls open/close on /dev/ttyS0 per line >atmel_shutdown executes on close >uart_timer_callback may fire during shutdown before timer is killed >tasklet gets scheduled after

Re: [RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-10 Thread Nicolas Ferre
On 09/01/2014 08:08, Mark Roszko : Just to sumarize the bug after poking before the patch: systemd calls open/close on /dev/ttyS0 per line atmel_shutdown executes on close uart_timer_callback may fire during shutdown before timer is killed tasklet gets scheduled after tasklet_kill

Re: [RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-08 Thread Mark Roszko
Just to sumarize the bug after poking before the patch: systemd calls open/close on /dev/ttyS0 per line atmel_shutdown executes on close uart_timer_callback may fire during shutdown before timer is killed tasklet gets scheduled after tasklet_kill atmel_shutdown returns back to

Re: [RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-08 Thread Mark Roszko
**Sorry for the duplicate mail, I forgot to force plain-text mode in gmail or the mailing list rejects the mails. Sigh, I need to buy my own email server at this rate to even deal with the mailing lists and proper etiquette (no quoteS) :( Ah, I forgot there was that third mode(no dma and no pdc).

[RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-08 Thread Nicolas Ferre
From: Marek Roszko The uart timer will schedule a tasklet when it fires. It is possible that it can fire inside _shutdown before it is killed in the dma and pdc cleanup routines. This causes a tasklet that exists after the port is shutdown, so when the kernel finally executes it, it panics as

[RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-08 Thread Nicolas Ferre
From: Marek Roszko mark.ros...@gmail.com The uart timer will schedule a tasklet when it fires. It is possible that it can fire inside _shutdown before it is killed in the dma and pdc cleanup routines. This causes a tasklet that exists after the port is shutdown, so when the kernel finally

Re: [RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-08 Thread Mark Roszko
**Sorry for the duplicate mail, I forgot to force plain-text mode in gmail or the mailing list rejects the mails. Sigh, I need to buy my own email server at this rate to even deal with the mailing lists and proper etiquette (no quoteS) :( Ah, I forgot there was that third mode(no dma and no pdc).

Re: [RFC PATCH] tty/serial: at91: disable uart timer at start of shutdown

2014-01-08 Thread Mark Roszko
Just to sumarize the bug after poking before the patch: systemd calls open/close on /dev/ttyS0 per line atmel_shutdown executes on close uart_timer_callback may fire during shutdown before timer is killed tasklet gets scheduled after tasklet_kill atmel_shutdown returns back to