On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote:
> Well, the spec clearly says that the registers reflect the endianess of
> the guest, and it makes sense: when performing the MMIO access, KVM
> needs to convert between host and guest endianess.
It's actually a horrible idea :-)
What does
On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote:
Well, the spec clearly says that the registers reflect the endianess of
the guest, and it makes sense: when performing the MMIO access, KVM
needs to convert between host and guest endianess.
It's actually a horrible idea :-)
What does
"Michael S. Tsirkin" writes:
> On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote:
>> On 13/02/13 15:08, Pawel Moll wrote:
>> > On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
>> >> Using readl() to read the magic value and then memcmp() to check it
>> >> fails on BE, as bytes
On 13/02/13 16:53, Michael S. Tsirkin wrote:
> On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote:
>> On 13/02/13 15:08, Pawel Moll wrote:
>>> On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
Using readl() to read the magic value and then memcmp() to check it
fails on BE,
On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote:
> On 13/02/13 15:08, Pawel Moll wrote:
> > On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
> >> Using readl() to read the magic value and then memcmp() to check it
> >> fails on BE, as bytes will be the other way around (by
On 13/02/13 15:46, Pawel Moll wrote:
> On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote:
Fix it by encoding the magic as an integer instead of a string.
So I'm not completely sure this is the right fix,
>>>
>>> It seems right, however...
>>>
- Using __raw_readl() instead. Is
On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote:
> >> Fix it by encoding the magic as an integer instead of a string.
> >> So I'm not completely sure this is the right fix,
> >
> > It seems right, however...
> >
> >> - Using __raw_readl() instead. Is that a generic enough API?
> >>
> >
On 13/02/13 15:08, Pawel Moll wrote:
> On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
>> Using readl() to read the magic value and then memcmp() to check it
>> fails on BE, as bytes will be the other way around (by virtue of
>> the registers to follow the endianess of the guest).
>
> Hm.
On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
> Using readl() to read the magic value and then memcmp() to check it
> fails on BE, as bytes will be the other way around (by virtue of
> the registers to follow the endianess of the guest).
Hm. Interesting. I missed the fact that readl() as
Using readl() to read the magic value and then memcmp() to check it
fails on BE, as bytes will be the other way around (by virtue of
the registers to follow the endianess of the guest).
Fix it by encoding the magic as an integer instead of a string.
Cc: Rusty Russell
Cc: Michael S. Tsirkin
Cc:
Using readl() to read the magic value and then memcmp() to check it
fails on BE, as bytes will be the other way around (by virtue of
the registers to follow the endianess of the guest).
Fix it by encoding the magic as an integer instead of a string.
Cc: Rusty Russell ru...@rustcorp.com.au
Cc:
On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
Using readl() to read the magic value and then memcmp() to check it
fails on BE, as bytes will be the other way around (by virtue of
the registers to follow the endianess of the guest).
Hm. Interesting. I missed the fact that readl() as a
On 13/02/13 15:08, Pawel Moll wrote:
On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
Using readl() to read the magic value and then memcmp() to check it
fails on BE, as bytes will be the other way around (by virtue of
the registers to follow the endianess of the guest).
Hm.
On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote:
Fix it by encoding the magic as an integer instead of a string.
So I'm not completely sure this is the right fix,
It seems right, however...
- Using __raw_readl() instead. Is that a generic enough API?
... this implies that
On 13/02/13 15:46, Pawel Moll wrote:
On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote:
Fix it by encoding the magic as an integer instead of a string.
So I'm not completely sure this is the right fix,
It seems right, however...
- Using __raw_readl() instead. Is that a generic enough
On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote:
On 13/02/13 15:08, Pawel Moll wrote:
On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
Using readl() to read the magic value and then memcmp() to check it
fails on BE, as bytes will be the other way around (by virtue of
On 13/02/13 16:53, Michael S. Tsirkin wrote:
On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote:
On 13/02/13 15:08, Pawel Moll wrote:
On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
Using readl() to read the magic value and then memcmp() to check it
fails on BE, as bytes will
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote:
On 13/02/13 15:08, Pawel Moll wrote:
On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote:
Using readl() to read the magic value and then memcmp() to check it
fails on BE, as bytes
18 matches
Mail list logo
