Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
On 3/6/18 1:41 PM, Andrew Morton wrote: On Tue, 6 Mar 2018 13:17:37 -0800 Yang Shi wrote: It just mitigates the hung task warning, can't resolve the mmap_sem scalability issue. Furthermore, waiting on pure uninterruptible state for reading /proc sounds

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
On 3/6/18 1:41 PM, Andrew Morton wrote: On Tue, 6 Mar 2018 13:17:37 -0800 Yang Shi wrote: It just mitigates the hung task warning, can't resolve the mmap_sem scalability issue. Furthermore, waiting on pure uninterruptible state for reading /proc sounds unnecessary. It doesn't wait for I/O

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Andrew Morton
On Tue, 6 Mar 2018 13:17:37 -0800 Yang Shi wrote: > > > It just mitigates the hung task warning, can't resolve the mmap_sem > scalability issue. Furthermore, waiting on pure uninterruptible state > for reading /proc sounds unnecessary. It doesn't wait for I/O

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Andrew Morton
On Tue, 6 Mar 2018 13:17:37 -0800 Yang Shi wrote: > > > It just mitigates the hung task warning, can't resolve the mmap_sem > scalability issue. Furthermore, waiting on pure uninterruptible state > for reading /proc sounds unnecessary. It doesn't wait for I/O completion. OK. > > > > Where

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
On 3/6/18 12:45 PM, Andrew Morton wrote: On Tue, 27 Feb 2018 08:25:47 +0800 Yang Shi wrote: Background: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
On 3/6/18 12:45 PM, Andrew Morton wrote: On Tue, 27 Feb 2018 08:25:47 +0800 Yang Shi wrote: Background: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: G

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Andrew Morton
On Tue, 27 Feb 2018 08:25:47 +0800 Yang Shi wrote: > > Background: > When running vm-scalability with large memory (> 300GB), the below hung > task issue happens occasionally. > > INFO: task ps:14018 blocked for more than 120 seconds. >Tainted: G

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Andrew Morton
On Tue, 27 Feb 2018 08:25:47 +0800 Yang Shi wrote: > > Background: > When running vm-scalability with large memory (> 300GB), the below hung > task issue happens occasionally. > > INFO: task ps:14018 blocked for more than 120 seconds. >Tainted: GE

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
Hi Andrew, Any comment on this series is appreciated. I'm supposed everyone agrees to improve the readability of /proc, right? The argument is whether access_remote_vm_killable() is preferred or not. I though _killable() version may prevent from confusion since access_remote_vm() is

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
Hi Andrew, Any comment on this series is appreciated. I'm supposed everyone agrees to improve the readability of /proc, right? The argument is whether access_remote_vm_killable() is preferred or not. I though _killable() version may prevent from confusion since access_remote_vm() is

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-28 Thread Yang Shi
On 2/26/18 5:47 PM, David Rientjes wrote: On Mon, 26 Feb 2018, Yang Shi wrote: Rather than killable, we have patches that introduce down_read_unfair() variants for the files you've modified (cmdline and environ) as well as others (maps, numa_maps, smaps). You mean you have such

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-28 Thread Yang Shi
On 2/26/18 5:47 PM, David Rientjes wrote: On Mon, 26 Feb 2018, Yang Shi wrote: Rather than killable, we have patches that introduce down_read_unfair() variants for the files you've modified (cmdline and environ) as well as others (maps, numa_maps, smaps). You mean you have such

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread David Rientjes
On Mon, 26 Feb 2018, Yang Shi wrote: > > Rather than killable, we have patches that introduce down_read_unfair() > > variants for the files you've modified (cmdline and environ) as well as > > others (maps, numa_maps, smaps). > > You mean you have such functionality used by google internally? >

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread David Rientjes
On Mon, 26 Feb 2018, Yang Shi wrote: > > Rather than killable, we have patches that introduce down_read_unfair() > > variants for the files you've modified (cmdline and environ) as well as > > others (maps, numa_maps, smaps). > > You mean you have such functionality used by google internally? >

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread Yang Shi
On 2/26/18 5:02 PM, David Rientjes wrote: On Tue, 27 Feb 2018, Yang Shi wrote: Background: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread Yang Shi
On 2/26/18 5:02 PM, David Rientjes wrote: On Tue, 27 Feb 2018, Yang Shi wrote: Background: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread David Rientjes
On Tue, 27 Feb 2018, Yang Shi wrote: > > Background: > When running vm-scalability with large memory (> 300GB), the below hung > task issue happens occasionally. > > INFO: task ps:14018 blocked for more than 120 seconds. >Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 >

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread David Rientjes
On Tue, 27 Feb 2018, Yang Shi wrote: > > Background: > When running vm-scalability with large memory (> 300GB), the below hung > task issue happens occasionally. > > INFO: task ps:14018 blocked for more than 120 seconds. >Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 >

[RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread Yang Shi
Background: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"

[RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-02-26 Thread Yang Shi
Background: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"