Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Chris Wright
* Thomas Gleixner ([EMAIL PROTECTED]) wrote: > On Mon, 2007-04-02 at 14:39 -0700, Chris Wright wrote: > > the part i know is broken is lapic broadcast, so i'd like to fix that > > up too. trouble is, it's broken on vanilla too, so i'm not 100% sure > > what i'm debugging yet. > > You need to

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Thomas Gleixner
On Mon, 2007-04-02 at 14:39 -0700, Chris Wright wrote: > > > Yes, that's part of why I did some of the cleanups that way, so that we > > > could merge the two together later. > > > > I'd prefer to get this done now. If we plug it in as is, the "merge > > later" probably will never happen. > >

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Chris Wright
* Thomas Gleixner ([EMAIL PROTECTED]) wrote: > On Sun, 2007-04-01 at 11:54 -0700, Chris Wright wrote: > > * Thomas Gleixner ([EMAIL PROTECTED]) wrote: > > > On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: > > > > This series converts x86_64 timers to clockevents drivers > > > > and then

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Thomas Gleixner
On Sun, 2007-04-01 at 11:54 -0700, Chris Wright wrote: > * Thomas Gleixner ([EMAIL PROTECTED]) wrote: > > On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: > > > This series converts x86_64 timers to clockevents drivers > > > and then enables dynticks. There's some minor cleanups along > > >

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Thomas Gleixner
On Sun, 2007-04-01 at 22:53 +0200, Andi Kleen wrote: > > Have you checked, if we could share the code between i386 and x86_64 at > > least for PIT and HPET. I'm not sure about the local APIC, but I think > > it might be doable as well. > > Not for PIT. I don't want all the broken ancient hardware

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Thomas Gleixner
On Sun, 2007-04-01 at 22:53 +0200, Andi Kleen wrote: Have you checked, if we could share the code between i386 and x86_64 at least for PIT and HPET. I'm not sure about the local APIC, but I think it might be doable as well. Not for PIT. I don't want all the broken ancient hardware

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Thomas Gleixner
On Sun, 2007-04-01 at 11:54 -0700, Chris Wright wrote: * Thomas Gleixner ([EMAIL PROTECTED]) wrote: On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: This series converts x86_64 timers to clockevents drivers and then enables dynticks. There's some minor cleanups along the way.

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Chris Wright
* Thomas Gleixner ([EMAIL PROTECTED]) wrote: On Sun, 2007-04-01 at 11:54 -0700, Chris Wright wrote: * Thomas Gleixner ([EMAIL PROTECTED]) wrote: On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: This series converts x86_64 timers to clockevents drivers and then enables dynticks.

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Thomas Gleixner
On Mon, 2007-04-02 at 14:39 -0700, Chris Wright wrote: Yes, that's part of why I did some of the cleanups that way, so that we could merge the two together later. I'd prefer to get this done now. If we plug it in as is, the merge later probably will never happen. that's fine, this

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-02 Thread Chris Wright
* Thomas Gleixner ([EMAIL PROTECTED]) wrote: On Mon, 2007-04-02 at 14:39 -0700, Chris Wright wrote: the part i know is broken is lapic broadcast, so i'd like to fix that up too. trouble is, it's broken on vanilla too, so i'm not 100% sure what i'm debugging yet. You need to remove

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-01 Thread Andi Kleen
> Have you checked, if we could share the code between i386 and x86_64 at > least for PIT and HPET. I'm not sure about the local APIC, but I think > it might be doable as well. Not for PIT. I don't want all the broken ancient hardware workarounds on x86-64. HPET might be doable, but would need

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-01 Thread Chris Wright
* Thomas Gleixner ([EMAIL PROTECTED]) wrote: > On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: > > This series converts x86_64 timers to clockevents drivers > > and then enables dynticks. There's some minor cleanups along > > the way. The lapic broadcast mechanism is untested, I'm sure it

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-01 Thread Thomas Gleixner
On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: > This series converts x86_64 timers to clockevents drivers > and then enables dynticks. There's some minor cleanups along > the way. The lapic broadcast mechanism is untested, I'm sure it > still needs work, there's still some cruft in

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-01 Thread Thomas Gleixner
On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: This series converts x86_64 timers to clockevents drivers and then enables dynticks. There's some minor cleanups along the way. The lapic broadcast mechanism is untested, I'm sure it still needs work, there's still some cruft in

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-01 Thread Chris Wright
* Thomas Gleixner ([EMAIL PROTECTED]) wrote: On Sat, 2007-03-31 at 01:31 -0700, Chris Wright wrote: This series converts x86_64 timers to clockevents drivers and then enables dynticks. There's some minor cleanups along the way. The lapic broadcast mechanism is untested, I'm sure it

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-04-01 Thread Andi Kleen
Have you checked, if we could share the code between i386 and x86_64 at least for PIT and HPET. I'm not sure about the local APIC, but I think it might be doable as well. Not for PIT. I don't want all the broken ancient hardware workarounds on x86-64. HPET might be doable, but would need

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Ingo Molnar
* Chris Wright <[EMAIL PROTECTED]> wrote: > > hm, neat - did you take a look at the x86_64 clockevents code that > > is in -rt and that has been there for a year or so and has been > > tested quite extensively? > > Yes, that's what I started with. [...] ok :) > [...] It was only partially

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > * Chris Wright <[EMAIL PROTECTED]> wrote: > > This series converts x86_64 timers to clockevents drivers and then > > enables dynticks. There's some minor cleanups along the way. The > > lapic broadcast mechanism is untested, I'm sure it still needs

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Ingo Molnar
* Chris Wright <[EMAIL PROTECTED]> wrote: > This series converts x86_64 timers to clockevents drivers and then > enables dynticks. There's some minor cleanups along the way. The > lapic broadcast mechanism is untested, I'm sure it still needs work, > there's still some cruft in

[RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Chris Wright
This series converts x86_64 timers to clockevents drivers and then enables dynticks. There's some minor cleanups along the way. The lapic broadcast mechanism is untested, I'm sure it still needs work, there's still some cruft in lapic_setup_timer. This is just for comments at this point, now

[RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Chris Wright
This series converts x86_64 timers to clockevents drivers and then enables dynticks. There's some minor cleanups along the way. The lapic broadcast mechanism is untested, I'm sure it still needs work, there's still some cruft in lapic_setup_timer. This is just for comments at this point, now

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Ingo Molnar
* Chris Wright [EMAIL PROTECTED] wrote: This series converts x86_64 timers to clockevents drivers and then enables dynticks. There's some minor cleanups along the way. The lapic broadcast mechanism is untested, I'm sure it still needs work, there's still some cruft in lapic_setup_timer.

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: * Chris Wright [EMAIL PROTECTED] wrote: This series converts x86_64 timers to clockevents drivers and then enables dynticks. There's some minor cleanups along the way. The lapic broadcast mechanism is untested, I'm sure it still needs work,

Re: [RFC PATCH 0/5] x86_64: enable clockevents and dynticks

2007-03-31 Thread Ingo Molnar
* Chris Wright [EMAIL PROTECTED] wrote: hm, neat - did you take a look at the x86_64 clockevents code that is in -rt and that has been there for a year or so and has been tested quite extensively? Yes, that's what I started with. [...] ok :) [...] It was only partially done, for