Re: [RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-02 Thread David Howells
Matthew Wilcox wrote: > He's done it on top of http://git.infradead.org/users/willy/pagecache.git Sorry, yes, I should've mentioned that. > I was hoping he'd include > http://git.infradead.org/users/willy/pagecache.git/commitdiff/c71de787328809026cfabbcc5485cb01caca8646 >

Re: [RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-01 Thread Matthew Wilcox
On Tue, Sep 01, 2020 at 08:44:14PM +0100, David Howells wrote: > Matthew Wilcox wrote: > > > > Note that I've been > > > passing the number of pages to read in rac->_nr_pages, and then saving it > > > and changing it certain points, e.g. page_cache_readahead_unbounded(). > > > > I do not like

Re: [RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-01 Thread David Howells
Matthew Wilcox wrote: > > Note that I've been > > passing the number of pages to read in rac->_nr_pages, and then saving it > > and changing it certain points, e.g. page_cache_readahead_unbounded(). > > I do not like this. You're essentially mutating the meaning of _nr_pages > as the ractl

Re: [RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-01 Thread David Howells
Matthew Wilcox wrote: > > Also there's an apparent minor bug in khugepaged.c that I've included a > > patch for: page_cache_sync_readahead() looks to be given the wrong size in > > collapse_file(). > > This needs to go in as an independent fix. But you didn't actually cc Song. Bah. I forgot

Re: [RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-01 Thread Matthew Wilcox
On Tue, Sep 01, 2020 at 05:28:15PM +0100, David Howells wrote: > Here's a set of patches to expand the use of the readahead_control struct, > essentially from do_sync_mmap_readahead() down. I like this. > Note that I've been > passing the number of pages to read in rac->_nr_pages, and then

Re: [RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-01 Thread Matthew Wilcox
On Tue, Sep 01, 2020 at 09:41:32AM -0700, Eric Biggers wrote: > On Tue, Sep 01, 2020 at 05:28:15PM +0100, David Howells wrote: > > > > Hi Willy, > > > > Here's a set of patches to expand the use of the readahead_control struct, > > essentially from do_sync_mmap_readahead() down. Note that I've

Re: [RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-01 Thread Eric Biggers
On Tue, Sep 01, 2020 at 05:28:15PM +0100, David Howells wrote: > > Hi Willy, > > Here's a set of patches to expand the use of the readahead_control struct, > essentially from do_sync_mmap_readahead() down. Note that I've been > passing the number of pages to read in rac->_nr_pages, and then

[RFC PATCH 0/7] mm: Make more use of readahead_control

2020-09-01 Thread David Howells
Hi Willy, Here's a set of patches to expand the use of the readahead_control struct, essentially from do_sync_mmap_readahead() down. Note that I've been passing the number of pages to read in rac->_nr_pages, and then saving it and changing it certain points, e.g.