Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-12 Thread JoonSoo Kim
Hello, Atsushi. 2012/12/12 Atsushi Kumagai : > Hello, > > On Tue, 11 Dec 2012 17:17:05 -0500 (EST) > Dave Anderson wrote: > >> >> >> - Original Message - >> > On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: >> > >> > [..] >> > > > So without knowing details of both the data

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-12 Thread JoonSoo Kim
Hello, Atsushi. 2012/12/12 Atsushi Kumagai kumagai-atsu...@mxc.nes.nec.co.jp: Hello, On Tue, 11 Dec 2012 17:17:05 -0500 (EST) Dave Anderson ander...@redhat.com wrote: - Original Message - On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: [..] So without

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Atsushi Kumagai
Hello, On Tue, 11 Dec 2012 17:17:05 -0500 (EST) Dave Anderson wrote: > > > - Original Message - > > On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: > > > > [..] > > > > So without knowing details of both the data structures, I think if > > > > vmlist > > > > is going

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Dave Anderson
- Original Message - > On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: > > [..] > > > So without knowing details of both the data structures, I think if vmlist > > > is going away, then user space tools should be able to traverse > > > vmap_area_root > > > rb tree. I am

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Vivek Goyal
On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: [..] > > So without knowing details of both the data structures, I think if vmlist > > is going away, then user space tools should be able to traverse > > vmap_area_root > > rb tree. I am assuming it is sorted using ->addr field and we

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Dave Anderson
- Original Message - > > Can we get the same information from this rb-tree of vmap_area? Is > > ->va_start field communication same information as vmlist was > > communicating? What's the difference between vmap_area_root and vmlist. > > Thanks for comment. > > Yes. vmap_area's

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Dave Anderson
- Original Message - Can we get the same information from this rb-tree of vmap_area? Is -va_start field communication same information as vmlist was communicating? What's the difference between vmap_area_root and vmlist. Thanks for comment. Yes. vmap_area's va_start field

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Vivek Goyal
On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: [..] So without knowing details of both the data structures, I think if vmlist is going away, then user space tools should be able to traverse vmap_area_root rb tree. I am assuming it is sorted using -addr field and we should

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Dave Anderson
- Original Message - On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: [..] So without knowing details of both the data structures, I think if vmlist is going away, then user space tools should be able to traverse vmap_area_root rb tree. I am assuming it is

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-11 Thread Atsushi Kumagai
Hello, On Tue, 11 Dec 2012 17:17:05 -0500 (EST) Dave Anderson ander...@redhat.com wrote: - Original Message - On Mon, Dec 10, 2012 at 11:40:47PM +0900, JoonSoo Kim wrote: [..] So without knowing details of both the data structures, I think if vmlist is going

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-10 Thread JoonSoo Kim
Hello, Vivek. 2012/12/7 Vivek Goyal : > On Fri, Dec 07, 2012 at 10:16:55PM +0900, JoonSoo Kim wrote: >> 2012/12/7 Andrew Morton : >> > On Fri, 7 Dec 2012 01:09:27 +0900 >> > Joonsoo Kim wrote: >> > >> >> I'm not sure that "7/8: makes vmlist only for kexec" is fine. >> >> Because it is related

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-10 Thread JoonSoo Kim
Hello, Vivek. 2012/12/7 Vivek Goyal vgo...@redhat.com: On Fri, Dec 07, 2012 at 10:16:55PM +0900, JoonSoo Kim wrote: 2012/12/7 Andrew Morton a...@linux-foundation.org: On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim js1...@gmail.com wrote: I'm not sure that 7/8: makes vmlist only for

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread Vivek Goyal
On Fri, Dec 07, 2012 at 10:16:55PM +0900, JoonSoo Kim wrote: > 2012/12/7 Andrew Morton : > > On Fri, 7 Dec 2012 01:09:27 +0900 > > Joonsoo Kim wrote: > > > >> I'm not sure that "7/8: makes vmlist only for kexec" is fine. > >> Because it is related to userspace program. > >> As far as I know,

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread JoonSoo Kim
Hello, Bob. 2012/12/7 Bob Liu : > Hi Joonsoo, > > On Fri, Dec 7, 2012 at 12:09 AM, Joonsoo Kim wrote: >> This patchset remove vm_struct list management after initializing vmalloc. >> Adding and removing an entry to vmlist is linear time complexity, so >> it is inefficient. If we maintain this

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread JoonSoo Kim
2012/12/7 Andrew Morton : > On Fri, 7 Dec 2012 01:09:27 +0900 > Joonsoo Kim wrote: > >> I'm not sure that "7/8: makes vmlist only for kexec" is fine. >> Because it is related to userspace program. >> As far as I know, makedumpfile use kexec's output information and it only >> need first address

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread JoonSoo Kim
Hello, Andrew. 2012/12/7 Andrew Morton : > On Fri, 7 Dec 2012 01:09:27 +0900 > Joonsoo Kim wrote: > >> This patchset remove vm_struct list management after initializing vmalloc. >> Adding and removing an entry to vmlist is linear time complexity, so >> it is inefficient. If we maintain this

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread JoonSoo Kim
Hello, Andrew. 2012/12/7 Andrew Morton a...@linux-foundation.org: On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim js1...@gmail.com wrote: This patchset remove vm_struct list management after initializing vmalloc. Adding and removing an entry to vmlist is linear time complexity, so it is

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread JoonSoo Kim
2012/12/7 Andrew Morton a...@linux-foundation.org: On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim js1...@gmail.com wrote: I'm not sure that 7/8: makes vmlist only for kexec is fine. Because it is related to userspace program. As far as I know, makedumpfile use kexec's output information and

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread JoonSoo Kim
Hello, Bob. 2012/12/7 Bob Liu lliu...@gmail.com: Hi Joonsoo, On Fri, Dec 7, 2012 at 12:09 AM, Joonsoo Kim js1...@gmail.com wrote: This patchset remove vm_struct list management after initializing vmalloc. Adding and removing an entry to vmlist is linear time complexity, so it is

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-07 Thread Vivek Goyal
On Fri, Dec 07, 2012 at 10:16:55PM +0900, JoonSoo Kim wrote: 2012/12/7 Andrew Morton a...@linux-foundation.org: On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim js1...@gmail.com wrote: I'm not sure that 7/8: makes vmlist only for kexec is fine. Because it is related to userspace program.

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Bob Liu
Hi Joonsoo, On Fri, Dec 7, 2012 at 12:09 AM, Joonsoo Kim wrote: > This patchset remove vm_struct list management after initializing vmalloc. > Adding and removing an entry to vmlist is linear time complexity, so > it is inefficient. If we maintain this list, overall time complexity of > adding

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Andrew Morton
On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim wrote: > I'm not sure that "7/8: makes vmlist only for kexec" is fine. > Because it is related to userspace program. > As far as I know, makedumpfile use kexec's output information and it only > need first address of vmalloc layer. So my

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Andrew Morton
On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim wrote: > This patchset remove vm_struct list management after initializing vmalloc. > Adding and removing an entry to vmlist is linear time complexity, so > it is inefficient. If we maintain this list, overall time complexity of > adding and

[RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Joonsoo Kim
This patchset remove vm_struct list management after initializing vmalloc. Adding and removing an entry to vmlist is linear time complexity, so it is inefficient. If we maintain this list, overall time complexity of adding and removing area to vmalloc space is O(N), although we use rbtree for

[RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Joonsoo Kim
This patchset remove vm_struct list management after initializing vmalloc. Adding and removing an entry to vmlist is linear time complexity, so it is inefficient. If we maintain this list, overall time complexity of adding and removing area to vmalloc space is O(N), although we use rbtree for

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Andrew Morton
On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim js1...@gmail.com wrote: This patchset remove vm_struct list management after initializing vmalloc. Adding and removing an entry to vmlist is linear time complexity, so it is inefficient. If we maintain this list, overall time complexity of adding

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Andrew Morton
On Fri, 7 Dec 2012 01:09:27 +0900 Joonsoo Kim js1...@gmail.com wrote: I'm not sure that 7/8: makes vmlist only for kexec is fine. Because it is related to userspace program. As far as I know, makedumpfile use kexec's output information and it only need first address of vmalloc layer. So my

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Bob Liu
Hi Joonsoo, On Fri, Dec 7, 2012 at 12:09 AM, Joonsoo Kim js1...@gmail.com wrote: This patchset remove vm_struct list management after initializing vmalloc. Adding and removing an entry to vmlist is linear time complexity, so it is inefficient. If we maintain this list, overall time complexity