Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Jeremy Fitzhardinge
Chris Wright wrote: > * Steven Rostedt ([EMAIL PROTECTED]) wrote: > >> Hmm, I know paravirt-ops had an issue with mcount in the RT tree. I can't >> remember the exact issues, but it did have something to do with the way >> parameters were passed in. >> >> Chris, do you remember what the issues

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Chris Wright
* Steven Rostedt ([EMAIL PROTECTED]) wrote: > On Thu, 3 Jan 2008, Chris Wright wrote: > > Yes, paravirt ops have a well-specified calling convention (register > > based). There was a cleanup that Andi did that caused the problem > > because it removed all the "fastcall" annotations since

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
On Thu, 3 Jan 2008, Chris Wright wrote: > > Yes, paravirt ops have a well-specified calling convention (register > based). There was a cleanup that Andi did that caused the problem > because it removed all the "fastcall" annotations since -mregparm=3 > is now always on for i386. Since MCOUNT

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Chris Wright
* Steven Rostedt ([EMAIL PROTECTED]) wrote: > Hmm, I know paravirt-ops had an issue with mcount in the RT tree. I can't > remember the exact issues, but it did have something to do with the way > parameters were passed in. > > Chris, do you remember what the issues were? Yes, paravirt ops have a

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
On Thu, 3 Jan 2008, Mathieu Desnoyers wrote: > . > > Index: linux-compile.git/arch/x86/kernel/mcount-wrapper.S > > === > > --- /dev/null 1970-01-01 00:00:00.0 + > > +++

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Mathieu Desnoyers
* Steven Rostedt ([EMAIL PROTECTED]) wrote: ... > Index: linux-compile.git/arch/x86/Kconfig > === > --- linux-compile.git.orig/arch/x86/Kconfig 2008-01-03 01:02:28.0 > -0500 > +++ linux-compile.git/arch/x86/Kconfig

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Daniel Walker
On Thu, 2008-01-03 at 02:16 -0500, Steven Rostedt wrote: > Index: linux-compile.git/Makefile > === > --- linux-compile.git.orig/Makefile 2008-01-03 01:02:28.0 -0500 > +++ linux-compile.git/Makefile 2008-01-03

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
Hi Sam! On Thu, 3 Jan 2008, Sam Ravnborg wrote: > > --- > > > > Index: linux-compile.git/Documentation/stable_api_nonsense.txt > > === > > --- linux-compile.git.orig/Documentation/stable_api_nonsense.txt > > 2008-01-03

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
[Added Chris Wright, Rusty and Virt list because they were involved with this issue before] On Thu, 3 Jan 2008, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > +# function tracing might turn this off: > > +config REGPARM > > + bool > > + depends on !MCOUNT > > +

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > +# function tracing might turn this off: > +config REGPARM > + bool > + depends on !MCOUNT > + default y are you sure -pg really needs this? I just carried this along the years and went the path of least resistence, but we should not be

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Sam Ravnborg
Hi Steven. On Thu, Jan 03, 2008 at 02:16:10AM -0500, Steven Rostedt wrote: > If CONFIG_MCOUNT is selected and /proc/sys/kernel/mcount_enabled is set to a > non-zero value the mcount routine will be called everytime we enter a kernel > function that is not marked with the "notrace" attribute. > >

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Sam Ravnborg
Hi Steven. On Thu, Jan 03, 2008 at 02:16:10AM -0500, Steven Rostedt wrote: If CONFIG_MCOUNT is selected and /proc/sys/kernel/mcount_enabled is set to a non-zero value the mcount routine will be called everytime we enter a kernel function that is not marked with the notrace attribute. The

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: +# function tracing might turn this off: +config REGPARM + bool + depends on !MCOUNT + default y are you sure -pg really needs this? I just carried this along the years and went the path of least resistence, but we should not be

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
[Added Chris Wright, Rusty and Virt list because they were involved with this issue before] On Thu, 3 Jan 2008, Ingo Molnar wrote: * Steven Rostedt [EMAIL PROTECTED] wrote: +# function tracing might turn this off: +config REGPARM + bool + depends on !MCOUNT + default y are

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Daniel Walker
On Thu, 2008-01-03 at 02:16 -0500, Steven Rostedt wrote: Index: linux-compile.git/Makefile === --- linux-compile.git.orig/Makefile 2008-01-03 01:02:28.0 -0500 +++ linux-compile.git/Makefile 2008-01-03

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Mathieu Desnoyers
* Steven Rostedt ([EMAIL PROTECTED]) wrote: ... Index: linux-compile.git/arch/x86/Kconfig === --- linux-compile.git.orig/arch/x86/Kconfig 2008-01-03 01:02:28.0 -0500 +++ linux-compile.git/arch/x86/Kconfig

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
On Thu, 3 Jan 2008, Mathieu Desnoyers wrote: . Index: linux-compile.git/arch/x86/kernel/mcount-wrapper.S === --- /dev/null 1970-01-01 00:00:00.0 + +++ linux-compile.git/arch/x86/kernel/mcount-wrapper.S

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Chris Wright
* Steven Rostedt ([EMAIL PROTECTED]) wrote: Hmm, I know paravirt-ops had an issue with mcount in the RT tree. I can't remember the exact issues, but it did have something to do with the way parameters were passed in. Chris, do you remember what the issues were? Yes, paravirt ops have a

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Chris Wright
* Steven Rostedt ([EMAIL PROTECTED]) wrote: On Thu, 3 Jan 2008, Chris Wright wrote: Yes, paravirt ops have a well-specified calling convention (register based). There was a cleanup that Andi did that caused the problem because it removed all the fastcall annotations since -mregparm=3 is

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
On Thu, 3 Jan 2008, Chris Wright wrote: Yes, paravirt ops have a well-specified calling convention (register based). There was a cleanup that Andi did that caused the problem because it removed all the fastcall annotations since -mregparm=3 is now always on for i386. Since MCOUNT disables

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Jeremy Fitzhardinge
Chris Wright wrote: * Steven Rostedt ([EMAIL PROTECTED]) wrote: Hmm, I know paravirt-ops had an issue with mcount in the RT tree. I can't remember the exact issues, but it did have something to do with the way parameters were passed in. Chris, do you remember what the issues were?

[RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-02 Thread Steven Rostedt
If CONFIG_MCOUNT is selected and /proc/sys/kernel/mcount_enabled is set to a non-zero value the mcount routine will be called everytime we enter a kernel function that is not marked with the "notrace" attribute. The mcount routine will then call a registered function if a function happens to be

[RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-02 Thread Steven Rostedt
If CONFIG_MCOUNT is selected and /proc/sys/kernel/mcount_enabled is set to a non-zero value the mcount routine will be called everytime we enter a kernel function that is not marked with the notrace attribute. The mcount routine will then call a registered function if a function happens to be