On Tue, Jun 17, 2014 at 1:12 AM, Mathieu Poirier
wrote:
> On 3 June 2014 03:09, Linus Walleij wrote:
>> On Fri, May 30, 2014 at 3:43 PM, wrote:
>>> + int read_count;
>>
>> Can this really be negative?
>
> It is useful for debugging, as an example see "tmc_release()".
On Tue, Jun 17, 2014 at 1:12 AM, Mathieu Poirier
mathieu.poir...@linaro.org wrote:
On 3 June 2014 03:09, Linus Walleij linus.wall...@linaro.org wrote:
On Fri, May 30, 2014 at 3:43 PM, mathieu.poir...@linaro.org wrote:
+ int read_count;
Can this really be negative?
Thanks for the review - please see comments in-lined.
Mathieu
On 3 June 2014 03:09, Linus Walleij wrote:
> On Fri, May 30, 2014 at 3:43 PM, wrote:
>
>> +#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata->base +
>> off)
>> +#define tmc_readl(drvdata, off)
Thanks for the review - please see comments in-lined.
Mathieu
On 3 June 2014 03:09, Linus Walleij linus.wall...@linaro.org wrote:
On Fri, May 30, 2014 at 3:43 PM, mathieu.poir...@linaro.org wrote:
+#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata-base +
off)
+#define
On Fri, May 30, 2014 at 3:43 PM, wrote:
> +#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata->base +
> off)
> +#define tmc_readl(drvdata, off)__raw_readl(drvdata->base +
> off)
Why not writel_relaxed()/readl_relaxed()?
Using __raw* accessors seem a bit
On Fri, May 30, 2014 at 3:43 PM, mathieu.poir...@linaro.org wrote:
+#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata-base +
off)
+#define tmc_readl(drvdata, off)__raw_readl(drvdata-base +
off)
Why not writel_relaxed()/readl_relaxed()?
Using __raw*
From: Pratik Patel
This driver manages CoreSight TMC (Trace Memory Controller) which
can act as a link or a sink depending upon its configuration. It
can present itself as an ETF (Embedded Trace FIFO) or ETR
(Embedded Trace Router).
ETF when configured in circular buffer mode acts as a trace
From: Pratik Patel prat...@codeaurora.org
This driver manages CoreSight TMC (Trace Memory Controller) which
can act as a link or a sink depending upon its configuration. It
can present itself as an ETF (Embedded Trace FIFO) or ETR
(Embedded Trace Router).
ETF when configured in circular buffer
8 matches
Mail list logo