Re: [RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-07-07 Thread Linus Walleij
On Tue, Jun 17, 2014 at 1:12 AM, Mathieu Poirier wrote: > On 3 June 2014 03:09, Linus Walleij wrote: >> On Fri, May 30, 2014 at 3:43 PM, wrote: >>> + int read_count; >> >> Can this really be negative? > > It is useful for debugging, as an example see "tmc_release()".

Re: [RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-07-07 Thread Linus Walleij
On Tue, Jun 17, 2014 at 1:12 AM, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 3 June 2014 03:09, Linus Walleij linus.wall...@linaro.org wrote: On Fri, May 30, 2014 at 3:43 PM, mathieu.poir...@linaro.org wrote: + int read_count; Can this really be negative?

Re: [RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-06-16 Thread Mathieu Poirier
Thanks for the review - please see comments in-lined. Mathieu On 3 June 2014 03:09, Linus Walleij wrote: > On Fri, May 30, 2014 at 3:43 PM, wrote: > >> +#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata->base + >> off) >> +#define tmc_readl(drvdata, off)

Re: [RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-06-16 Thread Mathieu Poirier
Thanks for the review - please see comments in-lined. Mathieu On 3 June 2014 03:09, Linus Walleij linus.wall...@linaro.org wrote: On Fri, May 30, 2014 at 3:43 PM, mathieu.poir...@linaro.org wrote: +#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata-base + off) +#define

Re: [RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-06-03 Thread Linus Walleij
On Fri, May 30, 2014 at 3:43 PM, wrote: > +#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata->base + > off) > +#define tmc_readl(drvdata, off)__raw_readl(drvdata->base + > off) Why not writel_relaxed()/readl_relaxed()? Using __raw* accessors seem a bit

Re: [RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-06-03 Thread Linus Walleij
On Fri, May 30, 2014 at 3:43 PM, mathieu.poir...@linaro.org wrote: +#define tmc_writel(drvdata, val, off) __raw_writel((val), drvdata-base + off) +#define tmc_readl(drvdata, off)__raw_readl(drvdata-base + off) Why not writel_relaxed()/readl_relaxed()? Using __raw*

[RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-05-30 Thread mathieu . poirier
From: Pratik Patel This driver manages CoreSight TMC (Trace Memory Controller) which can act as a link or a sink depending upon its configuration. It can present itself as an ETF (Embedded Trace FIFO) or ETR (Embedded Trace Router). ETF when configured in circular buffer mode acts as a trace

[RFC PATCH 02/11] coresight: add CoreSight TMC driver

2014-05-30 Thread mathieu . poirier
From: Pratik Patel prat...@codeaurora.org This driver manages CoreSight TMC (Trace Memory Controller) which can act as a link or a sink depending upon its configuration. It can present itself as an ETF (Embedded Trace FIFO) or ETR (Embedded Trace Router). ETF when configured in circular buffer