Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-17 Thread Ardelean, Alexandru
On Mon, 2019-09-16 at 14:43 +0100, Mark Brown wrote: > [External] > > On Mon, Sep 16, 2019 at 01:04:42PM +, Ardelean, Alexandru wrote: > > On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote: > > > That v3 seems to be a small subset of this series? > > Ack. > > V3 is the first 4 patches from

Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-16 Thread Mark Brown
On Mon, Sep 16, 2019 at 01:04:42PM +, Ardelean, Alexandru wrote: > On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote: > > That v3 seems to be a small subset of this series? > Ack. > V3 is the first 4 patches from this series. > Well, patches 3 & 4 are squashed. > I am 100% convinced that

Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-16 Thread Ardelean, Alexandru
On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote: > [External] > > On Mon, Sep 16, 2019 at 12:37:12PM +, Ardelean, Alexandru wrote: > > > > This breaks the build as there is a user of this interface. > > Ack. > > Jonathan pointed this out. > > There's a V3 that changes both this and it's

Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-16 Thread Mark Brown
On Mon, Sep 16, 2019 at 12:37:12PM +, Ardelean, Alexandru wrote: > > This breaks the build as there is a user of this interface. > Ack. > Jonathan pointed this out. > There's a V3 that changes both this and it's user (in IIO). That v3 seems to be a small subset of this series?

Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-16 Thread Ardelean, Alexandru
On Mon, 2019-09-16 at 13:25 +0100, Mark Brown wrote: > [External] > > On Fri, Sep 13, 2019 at 02:45:38PM +0300, Alexandru Ardelean wrote: > > > - u16 cs_change_delay; > > - u8 cs_change_delay_unit; > > + struct spi_delaycs_change_delay; > > This breaks the

Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-16 Thread Mark Brown
On Fri, Sep 13, 2019 at 02:45:38PM +0300, Alexandru Ardelean wrote: > - u16 cs_change_delay; > - u8 cs_change_delay_unit; > + struct spi_delaycs_change_delay; This breaks the build as there is a user of this interface. signature.asc Description: PGP

[RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-13 Thread Alexandru Ardelean
Since the logic for `spi_delay` struct + `spi_delay_exec()` has been copied from the `cs_change_delay` logic, it's natural to make this delay, the first user. The `cs_change_delay` logic requires that the default remain 10 uS, in case it is unspecified/unconfigured. So, there is some special