Re: [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-03-25 Thread Linus Walleij
On Thu, Mar 18, 2021 at 9:00 AM Enrico Weigelt, metux IT consult wrote: > Is there some compact notation for swnode's that's as small and simple > as some piece of DTS ? Yes it's really neat. It's all in and examples in e.g. the testsuite: drivers/base/test/property-entry-test.c You can just

Re: [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-03-18 Thread Enrico Weigelt, metux IT consult
On 11.03.21 11:42, Andy Shevchenko wrote: Hi, You are a bit late. We have built-in device properties (and corresponding API, which recently becomes swnode) which aims exactly this. Is there some compact notation for swnode's that's as small and simple as some piece of DTS ? My reasons for

Re: [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-03-11 Thread Andy Shevchenko
On Thu, Mar 11, 2021 at 12:20 PM Enrico Weigelt, metux IT consult wrote: > On 01.03.21 15:51, Linus Walleij wrote: > > I don't know what the idea is with this but register are not normally > > defined > > in the DTS files. The registers are determined from the compatible value. > > The idea is

Re: [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-03-11 Thread Enrico Weigelt, metux IT consult
On 01.03.21 15:51, Linus Walleij wrote: Hi, I don't know what the idea is with this but register are not normally defined in the DTS files. The registers are determined from the compatible value. The idea is basically replacing the pdata struct by oftree node. (subsequent patches in this

Re: [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-03-01 Thread Linus Walleij
On Mon, Feb 8, 2021 at 11:24 PM Enrico Weigelt, metux IT consult wrote: > Add support for probing via device tree. (...) > + pdata->gpio_num = of_property_count_elems_of_size(dev->of_node, > + "gpio-regs", > +

Re: [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-02-11 Thread Bartosz Golaszewski
On Mon, Feb 8, 2021 at 11:22 PM Enrico Weigelt, metux IT consult wrote: > > Add support for probing via device tree. > --- > drivers/gpio/gpio-amd-fch.c | 58 > + > include/dt-bindings/gpio/amd-fch-gpio.h | 36 +++ >

[RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-02-08 Thread Enrico Weigelt, metux IT consult
Add support for probing via device tree. --- drivers/gpio/gpio-amd-fch.c | 58 + include/dt-bindings/gpio/amd-fch-gpio.h | 36 +++ include/linux/platform_data/gpio/gpio-amd-fch.h | 24 ++ 3 files changed, 98 insertions(+), 20