Re: [RFC PATCH 1/1] tracepoints: tree-wide: Replace %p with %px

2020-10-14 Thread Masami Hiramatsu
On Wed, 14 Oct 2020 11:35:17 -0400 Steven Rostedt wrote: > On Thu, 15 Oct 2020 00:11:04 +0900 > Masami Hiramatsu wrote: > > > On Wed, 14 Oct 2020 09:38:13 -0400 > > Steven Rostedt wrote: > > > > > > Hmm, would you mean we always run such conversion on printing the trace > > buffer for each

Re: [RFC PATCH 1/1] tracepoints: tree-wide: Replace %p with %px

2020-10-14 Thread Steven Rostedt
On Thu, 15 Oct 2020 00:11:04 +0900 Masami Hiramatsu wrote: > On Wed, 14 Oct 2020 09:38:13 -0400 > Steven Rostedt wrote: > > > Hmm, would you mean we always run such conversion on printing the trace > buffer for each entry? It could be much overhead because we need allocate > memory (%p->%px

Re: [RFC PATCH 1/1] tracepoints: tree-wide: Replace %p with %px

2020-10-14 Thread Masami Hiramatsu
On Wed, 14 Oct 2020 09:38:13 -0400 Steven Rostedt wrote: > On Wed, 14 Oct 2020 17:59:19 +0900 > Masami Hiramatsu wrote: > > > To help debugging kernel, use %px to show real addresses on > > tracefs/trace file. > > > > Since ftrace human-readable format uses vsprintf(), all %p are > >

Re: [RFC PATCH 1/1] tracepoints: tree-wide: Replace %p with %px

2020-10-14 Thread Steven Rostedt
On Wed, 14 Oct 2020 17:59:19 +0900 Masami Hiramatsu wrote: > To help debugging kernel, use %px to show real addresses on > tracefs/trace file. > > Since ftrace human-readable format uses vsprintf(), all %p are > translated to hash values instead of pointer address. > > However, when debugging

[RFC PATCH 1/1] tracepoints: tree-wide: Replace %p with %px

2020-10-14 Thread Masami Hiramatsu
To help debugging kernel, use %px to show real addresses on tracefs/trace file. Since ftrace human-readable format uses vsprintf(), all %p are translated to hash values instead of pointer address. However, when debugging the kernel, raw address value gives a hint when comparing with the memory