Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-23 Thread Oleg Nesterov
On 04/23, Gautham R Shenoy wrote: > > On Fri, Apr 20, 2007 at 10:02:08PM +0400, Oleg Nesterov wrote: > > > > Gautham, isn't it possible to make a more simpler patch ? Just add > > PF_NOFREEZE > > check to frozen_process, > > > > static inline void frozen_process(struct task_struct *p) > >

Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-23 Thread Gautham R Shenoy
On Fri, Apr 20, 2007 at 10:02:08PM +0400, Oleg Nesterov wrote: > On 04/19, Rafael J. Wysocki wrote: > > > > On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote: > > > This patch fixes the race pointed out by Oleg Nesterov. > > > > > > * Freezer marks a thread as freezeable. > > > * The

Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-23 Thread Gautham R Shenoy
On Fri, Apr 20, 2007 at 10:02:08PM +0400, Oleg Nesterov wrote: On 04/19, Rafael J. Wysocki wrote: On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote: This patch fixes the race pointed out by Oleg Nesterov. * Freezer marks a thread as freezeable. * The thread now marks

Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-23 Thread Oleg Nesterov
On 04/23, Gautham R Shenoy wrote: On Fri, Apr 20, 2007 at 10:02:08PM +0400, Oleg Nesterov wrote: Gautham, isn't it possible to make a more simpler patch ? Just add PF_NOFREEZE check to frozen_process, static inline void frozen_process(struct task_struct *p) {

Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-20 Thread Oleg Nesterov
On 04/19, Rafael J. Wysocki wrote: > > On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote: > > This patch fixes the race pointed out by Oleg Nesterov. > > > > * Freezer marks a thread as freezeable. > > * The thread now marks itself PF_NOFREEZE causing it to > > freeze on calling

Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-20 Thread Oleg Nesterov
On 04/19, Rafael J. Wysocki wrote: On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote: This patch fixes the race pointed out by Oleg Nesterov. * Freezer marks a thread as freezeable. * The thread now marks itself PF_NOFREEZE causing it to freeze on calling try_to_freeze().

Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-19 Thread Rafael J. Wysocki
Hi, On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote: > This patch fixes the race pointed out by Oleg Nesterov. > > * Freezer marks a thread as freezeable. > * The thread now marks itself PF_NOFREEZE causing it to > freeze on calling try_to_freeze(). Thus the task is frozen, even

[RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-19 Thread Gautham R Shenoy
This patch fixes the race pointed out by Oleg Nesterov. * Freezer marks a thread as freezeable. * The thread now marks itself PF_NOFREEZE causing it to freeze on calling try_to_freeze(). Thus the task is frozen, even though it doesn't want to. * Subsequent thaw_processes() will also fail to

[RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-19 Thread Gautham R Shenoy
This patch fixes the race pointed out by Oleg Nesterov. * Freezer marks a thread as freezeable. * The thread now marks itself PF_NOFREEZE causing it to freeze on calling try_to_freeze(). Thus the task is frozen, even though it doesn't want to. * Subsequent thaw_processes() will also fail to

Re: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race

2007-04-19 Thread Rafael J. Wysocki
Hi, On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote: This patch fixes the race pointed out by Oleg Nesterov. * Freezer marks a thread as freezeable. * The thread now marks itself PF_NOFREEZE causing it to freeze on calling try_to_freeze(). Thus the task is frozen, even though