Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-08-06 Thread Philippe Schenker
On Tue, 2019-08-06 at 19:26 +0100, Mark Brown wrote: > On Tue, Aug 06, 2019 at 12:57:32PM +, Philippe Schenker wrote: > > On Mon, 2019-08-05 at 17:37 +0100, Mark Brown wrote: > > > So the capacitor on the input of the p-FET is keeping the switch > > > on? > > > When I say it's not switching wit

Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-08-06 Thread Mark Brown
On Tue, Aug 06, 2019 at 12:57:32PM +, Philippe Schenker wrote: > On Mon, 2019-08-05 at 17:37 +0100, Mark Brown wrote: > > So the capacitor on the input of the p-FET is keeping the switch on? > > When I say it's not switching with the clock I mean it's not constantly > > bouncing on and off at

Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-08-06 Thread Philippe Schenker
On Mon, 2019-08-05 at 17:37 +0100, Mark Brown wrote: > On Mon, Aug 05, 2019 at 11:07:58AM +, Philippe Schenker wrote: > > On Wed, 2019-07-31 at 22:23 +0100, Mark Brown wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doin

Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-08-05 Thread Mark Brown
On Mon, Aug 05, 2019 at 11:07:58AM +, Philippe Schenker wrote: > On Wed, 2019-07-31 at 22:23 +0100, Mark Brown wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. >

Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-08-05 Thread Philippe Schenker
On Wed, 2019-07-31 at 22:23 +0100, Mark Brown wrote: > On Tue, Jul 30, 2019 at 09:00:01PM +, Philippe Schenker wrote: > > On Tue, 2019-07-30 at 19:10 +0100, Mark Brown wrote: > > > On Tue, Jul 30, 2019 at 07:30:04PM +0200, Philippe Schenker wrote: > > > > This adds the possibility to enable a f

Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-07-31 Thread Mark Brown
On Tue, Jul 30, 2019 at 09:00:01PM +, Philippe Schenker wrote: > On Tue, 2019-07-30 at 19:10 +0100, Mark Brown wrote: > > On Tue, Jul 30, 2019 at 07:30:04PM +0200, Philippe Schenker wrote: > > > This adds the possibility to enable a fixed-regulator with a clock. > > Why? What does the hardwa

Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-07-30 Thread Philippe Schenker
On Tue, 2019-07-30 at 19:10 +0100, Mark Brown wrote: > On Tue, Jul 30, 2019 at 07:30:04PM +0200, Philippe Schenker wrote: > > From: Philippe Schenker > > > > This adds the possibility to enable a fixed-regulator with a clock. > > Why? What does the hardware which makes this make sense look like

Re: [RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-07-30 Thread Mark Brown
On Tue, Jul 30, 2019 at 07:30:04PM +0200, Philippe Schenker wrote: > From: Philippe Schenker > > This adds the possibility to enable a fixed-regulator with a clock. Why? What does the hardware which makes this make sense look like? Your cover letter didn't explain at all clearly, it just said t

[RFC PATCH 1/2] Regulator: Core: Add clock-enable to fixed-regulator

2019-07-30 Thread Philippe Schenker
From: Philippe Schenker This adds the possibility to enable a fixed-regulator with a clock. Signed-off-by: Signed-off-by: Philippe Schenker --- drivers/regulator/core.c | 15 +++ drivers/regulator/fixed.c| 6 ++ include/linux/regulator/driver.h | 3 +++ incl