Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)

2007-03-12 Thread Trent Piepho
On Tue, 13 Mar 2007, Rusty Russell wrote: > Hi Trent, > > Patch looks good, just one comment: > > On Mon, 2007-03-12 at 07:07 -0700, Trent Piepho wrote: > > + use = already_uses(a, b); > > + if (!use) { > > + printk(KERN_ERR "module %s trying to un-use a module, %s, whic

Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)

2007-03-12 Thread Rusty Russell
Hi Trent, Patch looks good, just one comment: On Mon, 2007-03-12 at 07:07 -0700, Trent Piepho wrote: > + use = already_uses(a, b); > + if (!use) { > + printk(KERN_ERR "module %s trying to un-use a module, %s, which " > + "it is not using", a->name, b

Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)

2007-03-12 Thread Trent Piepho
On Sun, 11 Mar 2007, Andrew Morton wrote: > > On Sat, 10 Mar 2007 02:31:35 -0200 Mauro Carvalho Chehab <[EMAIL > > PROTECTED]> wrote: > > From: Trent Piepho <[EMAIL PROTECTED]> > > > > When a module uses symbol_get() to increase the ref count of another > > module, there is no record what module c

Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)

2007-03-11 Thread Oleg Verych
> From: Andrew Morton > Newsgroups: gmane.linux.kernel > Subject: Re: [RFC PATCH 1/3] Add ability to keep track of callers of > symbol_(get|put) > Date: Sun, 11 Mar 2007 00:09:38 -0800 > >> On Sat, 10 Mar 2007 02:31:35 -0200 Mauro Carvalho Chehab <[EMAIL PROTECTED]

Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)

2007-03-11 Thread Andrew Morton
> On Sat, 10 Mar 2007 02:31:35 -0200 Mauro Carvalho Chehab <[EMAIL PROTECTED]> > wrote: > From: Trent Piepho <[EMAIL PROTECTED]> > > When a module uses symbol_get() to increase the ref count of another > module, there is no record what module called symbol_get(). A module > can > show up as havi

Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)

2007-03-10 Thread Rusty Russell
On Sat, 2007-03-10 at 02:31 -0200, Mauro Carvalho Chehab wrote: > From: Trent Piepho <[EMAIL PROTECTED]> > > When a module uses symbol_get() to increase the ref count of another > module, there is no record what module called symbol_get(). A module > can > show up as having other users, but there

[RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)

2007-03-09 Thread Mauro Carvalho Chehab
From: Trent Piepho <[EMAIL PROTECTED]> When a module uses symbol_get() to increase the ref count of another module, there is no record what module called symbol_get(). A module can show up as having other users, but there is no way to tell who those users are. This adds that ability to symbol_pu