Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-17 07:36, Boris Brezillon wrote: > Le Sat, 17 Jun 2017 00:46:12 +0200, > Peter Rosin a écrit : > >> Hm, it's probably too late to do it here. Planes have already been >> enabled and the engine may have started to fetch data and do the >> composition. You

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-17 07:36, Boris Brezillon wrote: > Le Sat, 17 Jun 2017 00:46:12 +0200, > Peter Rosin a écrit : > >> Hm, it's probably too late to do it here. Planes have already been >> enabled and the engine may have started to fetch data and do the >> composition. You could do that in

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Le Sat, 17 Jun 2017 00:46:12 +0200, Peter Rosin a écrit : > Hm, it's probably too late to do it here. Planes have already been > enabled and the engine may have started to fetch data and do the > composition. You could do that in ->update_plane() [1], and make it

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Le Sat, 17 Jun 2017 00:46:12 +0200, Peter Rosin a écrit : > Hm, it's probably too late to do it here. Planes have already been > enabled and the engine may have started to fetch data and do the > composition. You could do that in ->update_plane() [1], and make it a >

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hm, it's probably too late to do it here. Planes have already been enabled and the engine may have started to fetch data and do the composition. You could do that in ->update_plane() [1], and make it a per-plane thing. I'm not sure, but I think you can get the new

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hm, it's probably too late to do it here. Planes have already been enabled and the engine may have started to fetch data and do the composition. You could do that in ->update_plane() [1], and make it a per-plane thing. I'm not sure, but I think you can get the new

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-16 23:12, Peter Rosin wrote: > On 2017-06-16 18:15, Boris Brezillon wrote: >> To be very clear, I'd like you to test it through DRM ioctls, not only >> through the fbdev emulation layer. > > ...so yeah, right, I couldn't agree more. Any pointers to code w/o a bunch > of complex library

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-16 23:12, Peter Rosin wrote: > On 2017-06-16 18:15, Boris Brezillon wrote: >> To be very clear, I'd like you to test it through DRM ioctls, not only >> through the fbdev emulation layer. > > ...so yeah, right, I couldn't agree more. Any pointers to code w/o a bunch > of complex library

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-16 18:15, Boris Brezillon wrote: > Hi Peter, > > On Fri, 16 Jun 2017 17:54:04 +0200 > Peter Rosin wrote: > >> On 2017-06-16 12:01, Boris Brezillon wrote: >>> Hi Peter, >>> >>> On Fri, 16 Jun 2017 11:12:25 +0200 >>> Peter Rosin wrote: >>> All

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-16 18:15, Boris Brezillon wrote: > Hi Peter, > > On Fri, 16 Jun 2017 17:54:04 +0200 > Peter Rosin wrote: > >> On 2017-06-16 12:01, Boris Brezillon wrote: >>> Hi Peter, >>> >>> On Fri, 16 Jun 2017 11:12:25 +0200 >>> Peter Rosin wrote: >>> All layers of chips support this, the

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hi Peter, On Fri, 16 Jun 2017 17:54:04 +0200 Peter Rosin wrote: > On 2017-06-16 12:01, Boris Brezillon wrote: > > Hi Peter, > > > > On Fri, 16 Jun 2017 11:12:25 +0200 > > Peter Rosin wrote: > > > >> All layers of chips support this, the only variable is

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hi Peter, On Fri, 16 Jun 2017 17:54:04 +0200 Peter Rosin wrote: > On 2017-06-16 12:01, Boris Brezillon wrote: > > Hi Peter, > > > > On Fri, 16 Jun 2017 11:12:25 +0200 > > Peter Rosin wrote: > > > >> All layers of chips support this, the only variable is the base address > >> of the lookup

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-16 12:01, Boris Brezillon wrote: > Hi Peter, > > On Fri, 16 Jun 2017 11:12:25 +0200 > Peter Rosin wrote: > >> All layers of chips support this, the only variable is the base address >> of the lookup table in the register map. >> >> Signed-off-by: Peter Rosin

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

On 2017-06-16 12:01, Boris Brezillon wrote: > Hi Peter, > > On Fri, 16 Jun 2017 11:12:25 +0200 > Peter Rosin wrote: > >> All layers of chips support this, the only variable is the base address >> of the lookup table in the register map. >> >> Signed-off-by: Peter Rosin >> --- >>

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hi Peter, On Fri, 16 Jun 2017 11:12:25 +0200 Peter Rosin wrote: > All layers of chips support this, the only variable is the base address > of the lookup table in the register map. > > Signed-off-by: Peter Rosin > --- >

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

Hi Peter, On Fri, 16 Jun 2017 11:12:25 +0200 Peter Rosin wrote: > All layers of chips support this, the only variable is the base address > of the lookup table in the register map. > > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 48 >

[RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

All layers of chips support this, the only variable is the base address of the lookup table in the register map. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 48 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 13

[RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

All layers of chips support this, the only variable is the base address of the lookup table in the register map. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 48 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 13 +++