Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/27/2016 03:48 PM, Guenter Roeck wrote: > On 05/27/2016 01:25 AM, Neil Armstrong wrote: > [ ... ] +data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; +data->wdt_dev.min_hw_heartbeat_ms = 1; >>> >>> Does the device require a minimum time between heartbeats ? >>>

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/27/2016 03:48 PM, Guenter Roeck wrote: > On 05/27/2016 01:25 AM, Neil Armstrong wrote: > [ ... ] +data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; +data->wdt_dev.min_hw_heartbeat_ms = 1; >>> >>> Does the device require a minimum time between heartbeats ? >>>

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/27/2016 01:25 AM, Neil Armstrong wrote: [ ... ] +data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; +data->wdt_dev.min_hw_heartbeat_ms = 1; Does the device require a minimum time between heartbeats ? Just asking, because you violate it yourself below. If you want to

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/27/2016 01:25 AM, Neil Armstrong wrote: [ ... ] +data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; +data->wdt_dev.min_hw_heartbeat_ms = 1; Does the device require a minimum time between heartbeats ? Just asking, because you violate it yourself below. If you want to

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/26/2016 03:54 PM, Guenter Roeck wrote: > On 05/26/2016 12:51 AM, Neil Armstrong wrote: >> Add watchdog specific driver for Amlogic Meson GXBB SoC. >> > > Wondering - why RFC ? For these precious comments ! Thanks Guenter. > >> Signed-off-by: Neil Armstrong >>

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/26/2016 03:54 PM, Guenter Roeck wrote: > On 05/26/2016 12:51 AM, Neil Armstrong wrote: >> Add watchdog specific driver for Amlogic Meson GXBB SoC. >> > > Wondering - why RFC ? For these precious comments ! Thanks Guenter. > >> Signed-off-by: Neil Armstrong >> --- >>

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/26/2016 12:06 PM, Carlo Caione wrote: > On 26/05/16 09:51, Neil Armstrong wrote: >> Add watchdog specific driver for Amlogic Meson GXBB SoC. >> >> Signed-off-by: Neil Armstrong >> + > > [...] >> +#define DEFAULT_TIMEOUT 10 /* seconds */ >> + >> +#define

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/26/2016 12:06 PM, Carlo Caione wrote: > On 26/05/16 09:51, Neil Armstrong wrote: >> Add watchdog specific driver for Amlogic Meson GXBB SoC. >> >> Signed-off-by: Neil Armstrong >> + > > [...] >> +#define DEFAULT_TIMEOUT 10 /* seconds */ >> + >> +#define GXBB_WDT_CTRL_REG 0x0 >>

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/26/2016 12:51 AM, Neil Armstrong wrote: Add watchdog specific driver for Amlogic Meson GXBB SoC. Wondering - why RFC ? Signed-off-by: Neil Armstrong --- drivers/watchdog/Makefile | 1 + drivers/watchdog/meson_gxbb_wdt.c | 287

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 05/26/2016 12:51 AM, Neil Armstrong wrote: Add watchdog specific driver for Amlogic Meson GXBB SoC. Wondering - why RFC ? Signed-off-by: Neil Armstrong --- drivers/watchdog/Makefile | 1 + drivers/watchdog/meson_gxbb_wdt.c | 287 ++ 2

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 26/05/16 09:51, Neil Armstrong wrote: > Add watchdog specific driver for Amlogic Meson GXBB SoC. > > Signed-off-by: Neil Armstrong > + [...] > +#define DEFAULT_TIMEOUT 10 /* seconds */ > + > +#define GXBB_WDT_CTRL_REG0x0 > +#define GXBB_WDT_CTRL1_REG

Re: [RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

On 26/05/16 09:51, Neil Armstrong wrote: > Add watchdog specific driver for Amlogic Meson GXBB SoC. > > Signed-off-by: Neil Armstrong > + [...] > +#define DEFAULT_TIMEOUT 10 /* seconds */ > + > +#define GXBB_WDT_CTRL_REG0x0 > +#define GXBB_WDT_CTRL1_REG 0x4 > +#define

[RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

Add watchdog specific driver for Amlogic Meson GXBB SoC. Signed-off-by: Neil Armstrong --- drivers/watchdog/Makefile | 1 + drivers/watchdog/meson_gxbb_wdt.c | 287 ++ 2 files changed, 288 insertions(+) create mode 100644

[RFC PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

Add watchdog specific driver for Amlogic Meson GXBB SoC. Signed-off-by: Neil Armstrong --- drivers/watchdog/Makefile | 1 + drivers/watchdog/meson_gxbb_wdt.c | 287 ++ 2 files changed, 288 insertions(+) create mode 100644