RE: [RFC PATCH 2/2] ASoC: da732x: simplify code

2021-04-15 Thread Adam Thomson
On 15 April 2021 17:04, Mark Brown wrote: > On Thu, Apr 15, 2021 at 04:00:48PM +, Adam Thomson wrote: > > On 26 March 2021 22:16, Pierre-Louis Bossart wrote: > > > Apologies for the delay in getting to this. The change looks fine to me, > > although this part was EOL some time back, and I

Re: [RFC PATCH 2/2] ASoC: da732x: simplify code

2021-04-15 Thread Mark Brown
On Thu, Apr 15, 2021 at 04:00:48PM +, Adam Thomson wrote: > On 26 March 2021 22:16, Pierre-Louis Bossart wrote: > Apologies for the delay in getting to this. The change looks fine to me, > although this part was EOL some time back, and I find it hard to believe > anyone > out there has a

RE: [RFC PATCH 2/2] ASoC: da732x: simplify code

2021-04-15 Thread Adam Thomson
On 26 March 2021 22:16, Pierre-Louis Bossart wrote: > cppcheck reports a false positive: > > sound/soc/codecs/da732x.c:1161:25: warning: Either the condition > 'indiv<0' is redundant or there is division by zero at line > 1161. [zerodivcond] > fref = (da732x->sysclk / indiv); >

[RFC PATCH 2/2] ASoC: da732x: simplify code

2021-03-26 Thread Pierre-Louis Bossart
cppcheck reports a false positive: sound/soc/codecs/da732x.c:1161:25: warning: Either the condition 'indiv<0' is redundant or there is division by zero at line 1161. [zerodivcond] fref = (da732x->sysclk / indiv); ^ sound/soc/codecs/da732x.c:1158:12: note: Assuming that