Re: [RFC PATCH 2/2] net: mvneta: Add naive RSS support

2015-11-06 Thread Gregory CLEMENT
Hi Marcin, [...] >> +static int mvneta_config_rss(struct mvneta_port *pp) >> +{ >> + int cpu; >> + u32 val; >> + >> + netif_tx_stop_all_queues(pp->dev); >> + >> + /* Mask all ethernet port interrupts */ >> + mvreg_write(pp, MVNETA_INTR_NEW_MASK, 0); > > Shouldn't

Re: [RFC PATCH 2/2] net: mvneta: Add naive RSS support

2015-11-06 Thread Marcin Wojtas
Hi Gregory, 2015-11-06 19:35 GMT+01:00 Gregory CLEMENT : > This patch add the support for the RSS related ethtool > function. Currently it only use one entry in the indirection table which > allows associating an mveneta interface to a given CPU. > > Signed-off-by: Gregory CLEMENT > --- >

[RFC PATCH 2/2] net: mvneta: Add naive RSS support

2015-11-06 Thread Gregory CLEMENT
This patch add the support for the RSS related ethtool function. Currently it only use one entry in the indirection table which allows associating an mveneta interface to a given CPU. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c | 114

Re: [RFC PATCH 2/2] net: mvneta: Add naive RSS support

2015-11-06 Thread Marcin Wojtas
Hi Gregory, 2015-11-06 19:35 GMT+01:00 Gregory CLEMENT : > This patch add the support for the RSS related ethtool > function. Currently it only use one entry in the indirection table which > allows associating an mveneta interface to a given CPU. > >

[RFC PATCH 2/2] net: mvneta: Add naive RSS support

2015-11-06 Thread Gregory CLEMENT
This patch add the support for the RSS related ethtool function. Currently it only use one entry in the indirection table which allows associating an mveneta interface to a given CPU. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c |

Re: [RFC PATCH 2/2] net: mvneta: Add naive RSS support

2015-11-06 Thread Gregory CLEMENT
Hi Marcin, [...] >> +static int mvneta_config_rss(struct mvneta_port *pp) >> +{ >> + int cpu; >> + u32 val; >> + >> + netif_tx_stop_all_queues(pp->dev); >> + >> + /* Mask all ethernet port interrupts */ >> + mvreg_write(pp, MVNETA_INTR_NEW_MASK, 0); > > Shouldn't