Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions

2021-04-09 Thread David Howells
David Howells wrote: > add/remove: 2/2 grow/shrink: 15/16 up/down: 408/-599 (-191) > Function old new delta > iomap_write_end_inline - 128+128 I can get rid of the iomap_write_end_inline() increase for my config by marking

Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions

2021-04-09 Thread David Howells
Matthew Wilcox wrote: > iirc i looked at doing this as part of the folio work, and it ended up > increasing the size of the kernel. Did you run bloat-o-meter on the > result of doing this? add/remove: 2/2 grow/shrink: 15/16 up/down: 408/-599 (-191) Function o

Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions

2021-04-09 Thread David Howells
Matthew Wilcox wrote: > On Fri, Apr 09, 2021 at 11:59:17AM +0100, David Howells wrote: > > Make functions that test page bits return a bool, not an int. This means > > that the value is definitely 0 or 1 if they're used in arithmetic, rather > > than rely on test_bit() and friends to return this

Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions

2021-04-09 Thread Matthew Wilcox
On Fri, Apr 09, 2021 at 11:59:17AM +0100, David Howells wrote: > Make functions that test page bits return a bool, not an int. This means > that the value is definitely 0 or 1 if they're used in arithmetic, rather > than rely on test_bit() and friends to return this (though they probably > should)

[RFC PATCH 2/3] mm: Return bool from pagebit test functions

2021-04-09 Thread David Howells
Make functions that test page bits return a bool, not an int. This means that the value is definitely 0 or 1 if they're used in arithmetic, rather than rely on test_bit() and friends to return this (though they probably should). Signed-off-by: David Howells cc: Linus Torvalds cc: Matthew Wilcox