On Fri, 2020-08-21 at 00:17 +0206, John Ogness wrote:
> On 2020-08-20, Joe Perches wrote:
> > And here it seems like the 'for (j =...)' loop is superfluous.
>
> AFAICT it is skipping duplicate entries. In the case of a duplicate,
> only the first one is printed.
Ah, right. thanks.
On 2020-08-20, Joe Perches wrote:
> And here it seems like the 'for (j =...)' loop is superfluous.
AFAICT it is skipping duplicate entries. In the case of a duplicate,
only the first one is printed.
> Maybe something like this would be reasonable:
> ---
> drivers/tty/sysrq.c | 19
On Thu, Aug 20, 2020 at 10:48 AM Joe Perches wrote:
>
> Maybe something like this would be reasonable:
Yes. At this point this improves the code, rather than making it less legible.
Linus
On Wed, 2020-08-19 at 18:03 -0700, Linus Torvalds wrote:
> On Wed, Aug 19, 2020 at 4:26 PM John Ogness wrote:
> > Use the new pr_cont_t mechanism.
>
> This looks actively much worse than the old code.
Isn't this just a generic mechanism to simplify
the accumulation of
logging message chunks?
On Wed, Aug 19, 2020 at 4:26 PM John Ogness wrote:
>
> Use the new pr_cont_t mechanism.
This looks actively much worse than the old code.
Don't do this.
Just make pr_cont() do what it used to do.
Linus
Use the new pr_cont_t mechanism.
Signed-off-by: John Ogness
---
drivers/tty/sysrq.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index a8e39b2cdd55..be2aa816c444 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
6 matches
Mail list logo
